Re: [PATCH] ath9k_htc: Fix memory leak

[Larry Finger <Larry.Finger@lwfinger.net>]

On 01/09/2013 04:37 AM, Sujith Manoharan wrote:
> From: Sujith Manoharan <c_manoha@qca.qualcomm.com>
>
> SKBs that are allocated in the HTC layer do not have callbacks
> registered and hence ended up not being freed, Fix this by freeing
> them properly in the TX completion routine.
>
> Cc: <stable@vger.kernel.org>
> Reported-by: Larry Finger <Larry.Finger@lwfinger.net>
> Signed-off-by: Sujith Manoharan <c_manoha@qca.qualcomm.com>
> ---
>   drivers/net/wireless/ath/ath9k/htc_hst.c | 2 ++
>   1 file changed, 2 insertions(+)

Yes, your fix handles the normal case, and you can add a
Tested-by: Larry Finger <Larry.Finger@lwfinger.net>

I still have one remaining question. It is possible for the timeout code in 
htc_config_pipe_credits() to be executed, as shown below:

         time_left = wait_for_completion_timeout(&target->cmd_wait, HZ);
         if (!time_left) {
                 dev_err(target->dev, "HTC credit config timeout\n");
                 return -ETIMEDOUT;
         }

When this timeout happens, is the skb leaked?

Larry