From: Xose Vazquez Perez <xose.vazquez@gmail.com>
To: Gertjan van Wingerde <gwingerde@gmail.com>
Cc: Stanislaw Gruszka <stf_xl@wp.pl>,
"John W. Linville" <linville@tuxdriver.com>,
"linux-wireless@vger.kernel.org" <linux-wireless@vger.kernel.org>,
"users@rt2x00.serialmonkey.com" <users@rt2x00.serialmonkey.com>
Subject: Re: [PATCH] rt2x00: print chip and firmware version by default
Date: Tue, 22 Jan 2013 22:12:32 +0100 [thread overview]
Message-ID: <50FF00C0.1010402@gmail.com> (raw)
In-Reply-To: <2BB3EFC8-0B36-47DA-9FE2-13159E367F85@gmail.com>
On 01/22/2013 07:58 PM, Gertjan van Wingerde wrote:
> On 22 jan. 2013, at 17:49, Stanislaw Gruszka <stf_xl@wp.pl> wrote:
>
>> Signed-off-by: Stanislaw Gruszka <stf_xl@wp.pl>
>> Tested-by: Xose Vazquez Perez <xose.vazquez@gmail.com>
>> ---
>> drivers/net/wireless/rt2x00/rt2x00.h | 2 +-
>> drivers/net/wireless/rt2x00/rt2x00mac.c | 6 +++---
>> 2 files changed, 4 insertions(+), 4 deletions(-)
>>
>> diff --git a/drivers/net/wireless/rt2x00/rt2x00.h b/drivers/net/wireless/rt2x00/rt2x00.h
>> index 3e37c19..bef449c 100644
>> --- a/drivers/net/wireless/rt2x00/rt2x00.h
>> +++ b/drivers/net/wireless/rt2x00/rt2x00.h
>> @@ -92,7 +92,7 @@
>> #define NOTICE(__dev, __msg, __args...) \
>> DEBUG_PRINTK(__dev, KERN_NOTICE, "Notice", __msg, ##__args)
>> #define INFO(__dev, __msg, __args...) \
>> - DEBUG_PRINTK(__dev, KERN_INFO, "Info", __msg, ##__args)
>> + DEBUG_PRINTK_MSG(__dev, KERN_INFO, "Info", __msg, ##__args)
>> #define DEBUG(__dev, __msg, __args...) \
>> DEBUG_PRINTK(__dev, KERN_DEBUG, "Debug", __msg, ##__args)
>> #define EEPROM(__dev, __msg, __args...) \
>
> I think this change is good, but we should also change WARNING and
> NOTICE. Otherwise they won't be displayed if CONFIG_RT2X00_DEBUG is
> disabled, but INFO will, which would be strange.
I believe this patch is so useful and trivial enough to be included,
as is, in the next 3.8-rc .
The next steps can be done for 3.9
next prev parent reply other threads:[~2013-01-22 21:12 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-01-22 16:49 [PATCH] rt2x00: print chip and firmware version by default Stanislaw Gruszka
2013-01-22 18:58 ` Gertjan van Wingerde
2013-01-22 21:12 ` Xose Vazquez Perez [this message]
2013-01-22 22:19 ` Stanislaw Gruszka
2013-01-23 18:03 ` Gertjan van Wingerde
2013-01-22 22:22 ` Gertjan van Wingerde
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=50FF00C0.1010402@gmail.com \
--to=xose.vazquez@gmail.com \
--cc=gwingerde@gmail.com \
--cc=linux-wireless@vger.kernel.org \
--cc=linville@tuxdriver.com \
--cc=stf_xl@wp.pl \
--cc=users@rt2x00.serialmonkey.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).