From: Wen Gong <wgong@codeaurora.org>
To: Kalle Valo <kvalo@codeaurora.org>
Cc: Jouni Malinen <jouni@codeaurora.org>,
ath11k@lists.infradead.org, linux-wireless@vger.kernel.org
Subject: Re: [PATCH 3/3] ath11k: set correct NL80211_FEATURE_DYNAMIC_SMPS for WCN6855
Date: Fri, 29 Oct 2021 10:30:34 +0800 [thread overview]
Message-ID: <50c21cd4f727e61c7602a61fe37258df@codeaurora.org> (raw)
In-Reply-To: <87a6it5upc.fsf@codeaurora.org>
On 2021-10-28 18:07, Kalle Valo wrote:
> Jouni Malinen <jouni@codeaurora.org> writes:
>
>> From: Wen Gong <wgong@codeaurora.org>
>>
...
>> diff --git a/drivers/net/wireless/ath/ath11k/mac.c
>> b/drivers/net/wireless/ath/ath11k/mac.c
>> index 1f4765e43546..97a2c92b7b9b 100644
>> --- a/drivers/net/wireless/ath/ath11k/mac.c
>> +++ b/drivers/net/wireless/ath/ath11k/mac.c
>> @@ -7570,7 +7570,8 @@ static int __ath11k_mac_register(struct ath11k
>> *ar)
>> * for each band for a dual band capable radio. It will be tricky to
>> * handle it when the ht capability different for each band.
>> */
>> - if (ht_cap & WMI_HT_CAP_DYNAMIC_SMPS || ar->supports_6ghz)
>> + if (ht_cap & WMI_HT_CAP_DYNAMIC_SMPS ||
>> + (ar->supports_6ghz && !ab->hw_params.check_dynamic_smps))
>> ar->hw->wiphy->features |= NL80211_FEATURE_DYNAMIC_SMPS;
>
> Instead of a "negative" flag I reverted the test and renamed the flag
> to
> supports_dynamic_smps_6ghz. AFAIK QCN9074 is the only device supporting
> 6 GHz band so I enabled the flag only for it.
>
> Please review my changes in the pending branch:
Thanks.
the change is OK for WCN6855/QCA6390.
>
> https://git.kernel.org/pub/scm/linux/kernel/git/kvalo/ath.git/commit/?h=pending&id=cc692cfb9f2981691b39b601b37e4544ecf01136
next prev parent reply other threads:[~2021-10-29 2:30 UTC|newest]
Thread overview: 21+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-09-14 16:37 [PATCH 1/3] ath11k: Change number of TCL rings to one for QCA6390 Jouni Malinen
2021-09-14 16:37 ` [PATCH 2/3] ath11k: change return buffer manager " Jouni Malinen
2021-09-16 10:02 ` Kalle Valo
2021-09-28 15:09 ` Kalle Valo
2021-09-28 15:14 ` Kalle Valo
2021-09-29 2:42 ` bqiang
2021-10-01 6:26 ` Kalle Valo
2021-10-05 14:10 ` Kalle Valo
2021-10-25 13:02 ` Kalle Valo
2021-10-25 13:03 ` Kalle Valo
2021-09-14 16:37 ` [PATCH 3/3] ath11k: set correct NL80211_FEATURE_DYNAMIC_SMPS for WCN6855 Jouni Malinen
2021-09-16 10:08 ` Kalle Valo
2021-09-16 14:09 ` Wen Gong
2021-09-16 15:15 ` Kalle Valo
2021-10-28 10:07 ` Kalle Valo
2021-10-29 2:30 ` Wen Gong [this message]
2021-11-01 14:13 ` Kalle Valo
2021-09-28 15:12 ` [PATCH 1/3] ath11k: Change number of TCL rings to one for QCA6390 Kalle Valo
2021-09-29 2:15 ` bqiang
2021-10-05 14:06 ` Kalle Valo
2021-10-11 15:12 ` Kalle Valo
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=50c21cd4f727e61c7602a61fe37258df@codeaurora.org \
--to=wgong@codeaurora.org \
--cc=ath11k@lists.infradead.org \
--cc=jouni@codeaurora.org \
--cc=kvalo@codeaurora.org \
--cc=linux-wireless@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).