From: Larry Finger <Larry.Finger@lwfinger.net>
To: Guenter Roeck <linux@roeck-us.net>
Cc: linux-wireless@vger.kernel.org, netdev@vger.kernel.org,
Chaoming Li <chaoming_li@realsil.com.cn>,
"John W. Linville" <linville@tuxdriver.com>
Subject: Re: Potential problem in drivers/net/wireless/rtlwifi/usb.c:_rtl_rx_pre_process()
Date: Sun, 27 Jan 2013 16:11:51 -0600 [thread overview]
Message-ID: <5105A627.5000208@lwfinger.net> (raw)
In-Reply-To: <20130127211811.GA6680@roeck-us.net>
On 01/27/2013 03:18 PM, Guenter Roeck wrote:
> Hi all,
>
> while browsing through 'warning: variable ‘...’ set but not used' warnings, I
> found the following code in drivers/net/wireless/rtlwifi/usb.c:_rtl_rx_pre_process().
>
> while (!skb_queue_empty(&rx_queue)) {
> _skb = skb_dequeue(&rx_queue);
> _rtl_usb_rx_process_agg(hw, skb);
> ieee80211_rx_irqsafe(hw, skb);
> }
>
> Question: Should the parameter to _rtl_usb_rx_process_agg() and
> ieee80211_rx_irqsafe() be '_skb' instead of 'skb' ?
I think you are right and I will submit a patch to fix this.
What compiler version reported this? I use "gcc (SUSE Linux) 4.7.2 20130108
[gcc-4_7-branch revision 195012]" and I do not see this warning.
Thanks,
Larry
next prev parent reply other threads:[~2013-01-27 22:11 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-01-27 21:18 Potential problem in drivers/net/wireless/rtlwifi/usb.c:_rtl_rx_pre_process() Guenter Roeck
2013-01-27 22:11 ` Larry Finger [this message]
2013-01-27 23:52 ` Guenter Roeck
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=5105A627.5000208@lwfinger.net \
--to=larry.finger@lwfinger.net \
--cc=chaoming_li@realsil.com.cn \
--cc=linux-wireless@vger.kernel.org \
--cc=linux@roeck-us.net \
--cc=linville@tuxdriver.com \
--cc=netdev@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).