From: Ben Greear <greearb@candelatech.com>
To: Sujith Manoharan <sujith@msujith.org>
Cc: "linux-wireless@vger.kernel.org" <linux-wireless@vger.kernel.org>
Subject: Re: WARNING: at drivers/net/wireless/ath/ath9k/beacon.c:362 ath9k_beacon_tasklet+0xcc/0x5f0)
Date: Tue, 29 Jan 2013 21:53:45 -0800 [thread overview]
Message-ID: <5108B569.9090005@candelatech.com> (raw)
In-Reply-To: <20744.44999.48237.463434@gargle.gargle.HOWL>
On 01/29/2013 09:29 PM, Sujith Manoharan wrote:
> Ben Greear wrote:
>> I hit this warning in ath9k. Shortly after the machine blew up elsewhere,
>> but not sure if this is to blame or not.
>>
>> Code is slightly modified 3.7.5 (just a few patches, not my normal mass of hackings!)
>>
>> The warning that hit is the one below:
>>
>> bf = ath9k_beacon_generate(sc->hw, vif);
>> WARN_ON(!bf);
>>
>> Test case is dual-core Atom system with ath9k NIC, 10 or so virtual stations,
>> two virtual APs. Two stations send traffic to each other once everything associates, but
>> not sure it got that far when this crash happened.
>>
>
> Are these patches in your tree ?
They were not. I see the second was queued to stable, should the first one
be a stable candidate as well?
Thanks,
Ben
>
> commit 1381559ba48a04ca7c98f1b4c487bd44d0b75db5
> Author: Felix Fietkau <nbd@openwrt.org>
> Date: Sun Jan 20 18:51:53 2013 +0100
>
> ath9k: clean up processing of pending tx frames on reset
>
> Dropping packets from aggregation sessions is usually not a good idea, as
> it might upset the synchronization of the BlockAck receive window of the
> remote node. The use of the retry_tx parameter to reset/tx-drain functions
> also seemed a bit arbitrary.
> This patch removes this parameter altogether and ensures that pending tx
> frames are not dropped for no good reason.
>
> Signed-off-by: Felix Fietkau <nbd@openwrt.org>
> Signed-off-by: John W. Linville <linville@tuxdriver.com>
>
> commit 3adcf20afb585993ffee24de36d1975f6b26b120
> Author: Felix Fietkau <nbd@openwrt.org>
> Date: Wed Jan 9 16:16:54 2013 +0100
>
> ath9k: remove the WARN_ON that triggers if generating a beacon fails
>
> During teardown, mac80211 will not return a new beacon. This is normal and
> handled properly in the driver, so there's no need to spam the user with a kernel
> warning here.
>
> Cc: stable@vger.kernel.org
> Signed-off-by: Felix Fietkau <nbd@openwrt.org>
> Signed-off-by: John W. Linville <linville@tuxdriver.com>
>
>
> Sujith
>
--
Ben Greear <greearb@candelatech.com>
Candela Technologies Inc http://www.candelatech.com
next prev parent reply other threads:[~2013-01-30 5:53 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-01-30 5:18 WARNING: at drivers/net/wireless/ath/ath9k/beacon.c:362 ath9k_beacon_tasklet+0xcc/0x5f0) Ben Greear
2013-01-30 5:29 ` Sujith Manoharan
2013-01-30 5:53 ` Ben Greear [this message]
2013-01-30 6:09 ` Sujith Manoharan
2013-01-30 6:16 ` Ben Greear
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=5108B569.9090005@candelatech.com \
--to=greearb@candelatech.com \
--cc=linux-wireless@vger.kernel.org \
--cc=sujith@msujith.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).