From: Ben Greear <greearb@candelatech.com>
To: Sujith Manoharan <sujith@msujith.org>
Cc: "linux-wireless@vger.kernel.org" <linux-wireless@vger.kernel.org>
Subject: Re: WARNING: at drivers/net/wireless/ath/ath9k/beacon.c:362 ath9k_beacon_tasklet+0xcc/0x5f0)
Date: Tue, 29 Jan 2013 22:16:13 -0800 [thread overview]
Message-ID: <5108BAAD.7070306@candelatech.com> (raw)
In-Reply-To: <20744.47404.184099.495423@gargle.gargle.HOWL>
On 01/29/2013 10:09 PM, Sujith Manoharan wrote:
> Ben Greear wrote:
>> They were not. I see the second was queued to stable, should the first one
>> be a stable candidate as well?
>
> Sorry, I meant this one:
>
> commit 1adb2e2b5f85023d17eb4f95386a57029df27c88
> Author: Felix Fietkau <nbd@openwrt.org>
> Date: Wed Jan 9 16:16:53 2013 +0100
>
> ath9k: fix double-free bug on beacon generate failure
>
> When the next beacon is sent, the ath_buf from the previous run is reused.
> If getting a new beacon from mac80211 fails, bf->bf_mpdu is not reset, yet
> the skb is freed, leading to a double-free on the next beacon tx attempt,
> resulting in a system crash.
>
> Cc: stable@vger.kernel.org
> Signed-off-by: Felix Fietkau <nbd@openwrt.org>
> Signed-off-by: John W. Linville <linville@tuxdriver.com>
I did not have this one applied, and it would explain at least one
crash that I've seen.
I'll apply it (and the other you mentioned) now.
Thanks!
Ben
--
Ben Greear <greearb@candelatech.com>
Candela Technologies Inc http://www.candelatech.com
prev parent reply other threads:[~2013-01-30 6:16 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-01-30 5:18 WARNING: at drivers/net/wireless/ath/ath9k/beacon.c:362 ath9k_beacon_tasklet+0xcc/0x5f0) Ben Greear
2013-01-30 5:29 ` Sujith Manoharan
2013-01-30 5:53 ` Ben Greear
2013-01-30 6:09 ` Sujith Manoharan
2013-01-30 6:16 ` Ben Greear [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=5108BAAD.7070306@candelatech.com \
--to=greearb@candelatech.com \
--cc=linux-wireless@vger.kernel.org \
--cc=sujith@msujith.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).