* [PATCH] ath9k_htc: update RSSI values only when the device is associated
@ 2013-02-01 12:50 Bernhard Urban
2013-02-05 22:05 ` Felix Fietkau
0 siblings, 1 reply; 10+ messages in thread
From: Bernhard Urban @ 2013-02-01 12:50 UTC (permalink / raw)
To: linux-wireless, ath9k-devel, c_manoha, Sujith.Manoharan, linville,
m.sujith, nbd, shafi.wireless
Cc: markus, lewurm
add an if-guard, otherwise iw(8) reports weird signal strengths.
The behaviour was fine before this commit:
7c277349ecbd66e19fad3d949fa6ef6c131a3b62
Therefore, this patch is a partially revert of it.
In my testsetup, I have two access points:
00:12:XX within one meter physically range
c0:c1:XX ~15m, two (thin) walls
w/o patch:
00:12:XX -82.00 dBm
c0:c1:XX -84.00 dBm
with patch:
00:12:XX -45.00 dBm
c0:c1:XX -63.00 dBm
Tested with "TP-Link TL-WN722N"
Reported-by: Markus Krainz <markus@indoo.rs>
Tested-by: Markus Krainz <markus@indoo.rs>
Signed-off-by: Bernhard Urban <lewurm@gmail.com>
---
drivers/net/wireless/ath/ath9k/htc.h | 1 +
drivers/net/wireless/ath/ath9k/htc_drv_txrx.c | 29 +++++++++++++++----------
2 files changed, 19 insertions(+), 11 deletions(-)
diff --git a/drivers/net/wireless/ath/ath9k/htc.h b/drivers/net/wireless/ath/ath9k/htc.h
index b30596f..602e19b 100644
--- a/drivers/net/wireless/ath/ath9k/htc.h
+++ b/drivers/net/wireless/ath/ath9k/htc.h
@@ -22,6 +22,7 @@
#include <linux/firmware.h>
#include <linux/skbuff.h>
#include <linux/netdevice.h>
+#include <linux/etherdevice.h>
#include <linux/leds.h>
#include <linux/slab.h>
#include <net/mac80211.h>
diff --git a/drivers/net/wireless/ath/ath9k/htc_drv_txrx.c b/drivers/net/wireless/ath/ath9k/htc_drv_txrx.c
index 06cdcb7..a38435a 100644
--- a/drivers/net/wireless/ath/ath9k/htc_drv_txrx.c
+++ b/drivers/net/wireless/ath/ath9k/htc_drv_txrx.c
@@ -969,6 +969,7 @@ static bool ath9k_rx_prepare(struct ath9k_htc_priv *priv,
int hdrlen, padpos, padsize;
int last_rssi = ATH_RSSI_DUMMY_MARKER;
__le16 fc;
+ u8 is_mybeacon;
if (skb->len < HTC_RX_FRAME_HEADER_SIZE) {
ath_err(common, "Corrupted RX frame, dropping (len: %d)\n",
@@ -1060,22 +1061,28 @@ static bool ath9k_rx_prepare(struct ath9k_htc_priv *priv,
ath9k_process_rate(hw, rx_status, rxbuf->rxstatus.rs_rate,
rxbuf->rxstatus.rs_flags);
- if (rxbuf->rxstatus.rs_rssi != ATH9K_RSSI_BAD &&
- !rxbuf->rxstatus.rs_moreaggr)
- ATH_RSSI_LPF(priv->rx.last_rssi,
- rxbuf->rxstatus.rs_rssi);
+ is_mybeacon = ieee80211_is_beacon(fc) &&
+ !is_zero_ether_addr(common->curbssid) &&
+ ether_addr_equal(hdr->addr3, common->curbssid);
- last_rssi = priv->rx.last_rssi;
+ if (is_mybeacon && priv->ah->opmode == NL80211_IFTYPE_STATION) {
+ if (rxbuf->rxstatus.rs_rssi != ATH9K_RSSI_BAD &&
+ !rxbuf->rxstatus.rs_moreaggr)
+ ATH_RSSI_LPF(priv->rx.last_rssi,
+ rxbuf->rxstatus.rs_rssi);
- if (likely(last_rssi != ATH_RSSI_DUMMY_MARKER))
- rxbuf->rxstatus.rs_rssi = ATH_EP_RND(last_rssi,
- ATH_RSSI_EP_MULTIPLIER);
+ last_rssi = priv->rx.last_rssi;
- if (rxbuf->rxstatus.rs_rssi < 0)
- rxbuf->rxstatus.rs_rssi = 0;
+ if (likely(last_rssi != ATH_RSSI_DUMMY_MARKER)) {
+ s8 rssi = ATH_EP_RND(last_rssi, ATH_RSSI_EP_MULTIPLIER);
+ rxbuf->rxstatus.rs_rssi = rssi;
+ }
+
+ if (rxbuf->rxstatus.rs_rssi < 0)
+ rxbuf->rxstatus.rs_rssi = 0;
- if (ieee80211_is_beacon(fc))
priv->ah->stats.avgbrssi = rxbuf->rxstatus.rs_rssi;
+ }
rx_status->mactime = be64_to_cpu(rxbuf->rxstatus.rs_tstamp);
rx_status->band = hw->conf.channel->band;
--
1.7.9.5
^ permalink raw reply related [flat|nested] 10+ messages in thread* Re: [PATCH] ath9k_htc: update RSSI values only when the device is associated
2013-02-01 12:50 [PATCH] ath9k_htc: update RSSI values only when the device is associated Bernhard Urban
@ 2013-02-05 22:05 ` Felix Fietkau
0 siblings, 0 replies; 10+ messages in thread
From: Felix Fietkau @ 2013-02-05 22:05 UTC (permalink / raw)
To: Bernhard Urban
Cc: linux-wireless, ath9k-devel, c_manoha, Sujith.Manoharan, linville,
m.sujith, shafi.wireless, markus
On 2013-02-01 1:50 PM, Bernhard Urban wrote:
> add an if-guard, otherwise iw(8) reports weird signal strengths.
>
> The behaviour was fine before this commit:
> 7c277349ecbd66e19fad3d949fa6ef6c131a3b62
> Therefore, this patch is a partially revert of it.
I think your commit message is a bit misleading. The main problem with
signal strength reporting is not that it's missing some checks for if
the device is associated, or if the received frame is a local beacon.
The main problem is in these lines below:
> + if (likely(last_rssi != ATH_RSSI_DUMMY_MARKER)) {
> + s8 rssi = ATH_EP_RND(last_rssi, ATH_RSSI_EP_MULTIPLIER);
> + rxbuf->rxstatus.rs_rssi = rssi;
> + }
It does not make any sense to update the per-frame RSSI value with any
sort of average. ath9k filters out invalid RSSI values by ignoring rssi
for ANI when rx_stats->rs_moreaggr is set. In that case it also sets the
RX_FLAG_NO_SIGNAL_VAL flag to tell mac80211 to ignore the value for its
own signal strength averages.
- Felix
^ permalink raw reply [flat|nested] 10+ messages in thread
* [PATCH] ath9k_htc: update RSSI values only when the device is associated
@ 2012-12-01 20:21 Bernhard Urban
2012-12-01 20:26 ` Bernhard Urban
0 siblings, 1 reply; 10+ messages in thread
From: Bernhard Urban @ 2012-12-01 20:21 UTC (permalink / raw)
To: linux-wireless, ath9k-devel, c_manoha, Sujith.Manoharan, linville,
m.sujith, nbd
Cc: markus, lewurm
add an if-guard, otherwise iw(8) reports weird signal strengths.
The behaviour was fine before this commit:
7c277349ecbd66e19fad3d949fa6ef6c131a3b62
This patch is therefore a partially revert of it.
Tested with "TP-Link TL-WN722N"
Thanks to indoo.rs http://indoo.rs/ for sponsoring
Reported-by: Markus Krainz <markus@indoo.rs>
Tested-by: Markus Krainz <markus@indoo.rs>
Signed-off-by: Bernhard Urban <lewurm@gmail.com>
---
drivers/net/wireless/ath/ath9k/htc.h | 1 +
drivers/net/wireless/ath/ath9k/htc_drv_txrx.c | 29 +++++++++++++++----------
2 files changed, 19 insertions(+), 11 deletions(-)
diff --git a/drivers/net/wireless/ath/ath9k/htc.h b/drivers/net/wireless/ath/ath9k/htc.h
index 936e920..00ebf1c 100644
--- a/drivers/net/wireless/ath/ath9k/htc.h
+++ b/drivers/net/wireless/ath/ath9k/htc.h
@@ -22,6 +22,7 @@
#include <linux/firmware.h>
#include <linux/skbuff.h>
#include <linux/netdevice.h>
+#include <linux/etherdevice.h>
#include <linux/leds.h>
#include <linux/slab.h>
#include <net/mac80211.h>
diff --git a/drivers/net/wireless/ath/ath9k/htc_drv_txrx.c b/drivers/net/wireless/ath/ath9k/htc_drv_txrx.c
index 47e61d0..8b4da3d 100644
--- a/drivers/net/wireless/ath/ath9k/htc_drv_txrx.c
+++ b/drivers/net/wireless/ath/ath9k/htc_drv_txrx.c
@@ -969,6 +969,7 @@ static bool ath9k_rx_prepare(struct ath9k_htc_priv *priv,
int hdrlen, padpos, padsize;
int last_rssi = ATH_RSSI_DUMMY_MARKER;
__le16 fc;
+ u8 is_mybeacon;
if (skb->len < HTC_RX_FRAME_HEADER_SIZE) {
ath_err(common, "Corrupted RX frame, dropping (len: %d)\n",
@@ -1060,22 +1061,28 @@ static bool ath9k_rx_prepare(struct ath9k_htc_priv *priv,
ath9k_process_rate(hw, rx_status, rxbuf->rxstatus.rs_rate,
rxbuf->rxstatus.rs_flags);
- if (rxbuf->rxstatus.rs_rssi != ATH9K_RSSI_BAD &&
- !rxbuf->rxstatus.rs_moreaggr)
- ATH_RSSI_LPF(priv->rx.last_rssi,
- rxbuf->rxstatus.rs_rssi);
+ is_mybeacon = ieee80211_is_beacon(fc) &&
+ !is_zero_ether_addr(common->curbssid) &&
+ ether_addr_equal(hdr->addr3, common->curbssid);
- last_rssi = priv->rx.last_rssi;
+ if (is_mybeacon && priv->ah->opmode == NL80211_IFTYPE_STATION) {
+ if (rxbuf->rxstatus.rs_rssi != ATH9K_RSSI_BAD &&
+ !rxbuf->rxstatus.rs_moreaggr)
+ ATH_RSSI_LPF(priv->rx.last_rssi,
+ rxbuf->rxstatus.rs_rssi);
- if (likely(last_rssi != ATH_RSSI_DUMMY_MARKER))
- rxbuf->rxstatus.rs_rssi = ATH_EP_RND(last_rssi,
- ATH_RSSI_EP_MULTIPLIER);
+ last_rssi = priv->rx.last_rssi;
- if (rxbuf->rxstatus.rs_rssi < 0)
- rxbuf->rxstatus.rs_rssi = 0;
+ if (likely(last_rssi != ATH_RSSI_DUMMY_MARKER)) {
+ s8 rssi = ATH_EP_RND(last_rssi, ATH_RSSI_EP_MULTIPLIER);
+ rxbuf->rxstatus.rs_rssi = rssi;
+ }
+
+ if (rxbuf->rxstatus.rs_rssi < 0)
+ rxbuf->rxstatus.rs_rssi = 0;
- if (ieee80211_is_beacon(fc))
priv->ah->stats.avgbrssi = rxbuf->rxstatus.rs_rssi;
+ }
rx_status->mactime = be64_to_cpu(rxbuf->rxstatus.rs_tstamp);
rx_status->band = hw->conf.channel->band;
--
1.7.9.5
^ permalink raw reply related [flat|nested] 10+ messages in thread* Re: [PATCH] ath9k_htc: update RSSI values only when the device is associated
2012-12-01 20:21 Bernhard Urban
@ 2012-12-01 20:26 ` Bernhard Urban
2012-12-03 6:41 ` Mohammed Shafi
0 siblings, 1 reply; 10+ messages in thread
From: Bernhard Urban @ 2012-12-01 20:26 UTC (permalink / raw)
To: linux-wireless, ath9k-devel, c_manoha, Sujith.Manoharan, linville,
m.sujith, nbd
Cc: markus, lewurm
On Sat, Dec 1, 2012 at 9:21 PM, Bernhard Urban <lewurm@gmail.com> wrote:
> add an if-guard, otherwise iw(8) reports weird signal strengths.
>
> The behaviour was fine before this commit:
> 7c277349ecbd66e19fad3d949fa6ef6c131a3b62
> This patch is therefore a partially revert of it.
>
> Tested with "TP-Link TL-WN722N"
>
> Thanks to indoo.rs http://indoo.rs/ for sponsoring
>
> Reported-by: Markus Krainz <markus@indoo.rs>
> Tested-by: Markus Krainz <markus@indoo.rs>
> Signed-off-by: Bernhard Urban <lewurm@gmail.com>
> ---
> drivers/net/wireless/ath/ath9k/htc.h | 1 +
> drivers/net/wireless/ath/ath9k/htc_drv_txrx.c | 29 +++++++++++++++----------
> 2 files changed, 19 insertions(+), 11 deletions(-)
>
> diff --git a/drivers/net/wireless/ath/ath9k/htc.h b/drivers/net/wireless/ath/ath9k/htc.h
> index 936e920..00ebf1c 100644
> --- a/drivers/net/wireless/ath/ath9k/htc.h
> +++ b/drivers/net/wireless/ath/ath9k/htc.h
> @@ -22,6 +22,7 @@
> #include <linux/firmware.h>
> #include <linux/skbuff.h>
> #include <linux/netdevice.h>
> +#include <linux/etherdevice.h>
> #include <linux/leds.h>
> #include <linux/slab.h>
> #include <net/mac80211.h>
> diff --git a/drivers/net/wireless/ath/ath9k/htc_drv_txrx.c b/drivers/net/wireless/ath/ath9k/htc_drv_txrx.c
> index 47e61d0..8b4da3d 100644
> --- a/drivers/net/wireless/ath/ath9k/htc_drv_txrx.c
> +++ b/drivers/net/wireless/ath/ath9k/htc_drv_txrx.c
> @@ -969,6 +969,7 @@ static bool ath9k_rx_prepare(struct ath9k_htc_priv *priv,
> int hdrlen, padpos, padsize;
> int last_rssi = ATH_RSSI_DUMMY_MARKER;
> __le16 fc;
> + u8 is_mybeacon;
>
> if (skb->len < HTC_RX_FRAME_HEADER_SIZE) {
> ath_err(common, "Corrupted RX frame, dropping (len: %d)\n",
> @@ -1060,22 +1061,28 @@ static bool ath9k_rx_prepare(struct ath9k_htc_priv *priv,
> ath9k_process_rate(hw, rx_status, rxbuf->rxstatus.rs_rate,
> rxbuf->rxstatus.rs_flags);
>
> - if (rxbuf->rxstatus.rs_rssi != ATH9K_RSSI_BAD &&
> - !rxbuf->rxstatus.rs_moreaggr)
> - ATH_RSSI_LPF(priv->rx.last_rssi,
> - rxbuf->rxstatus.rs_rssi);
> + is_mybeacon = ieee80211_is_beacon(fc) &&
> + !is_zero_ether_addr(common->curbssid) &&
> + ether_addr_equal(hdr->addr3, common->curbssid);
>
> - last_rssi = priv->rx.last_rssi;
> + if (is_mybeacon && priv->ah->opmode == NL80211_IFTYPE_STATION) {
> + if (rxbuf->rxstatus.rs_rssi != ATH9K_RSSI_BAD &&
> + !rxbuf->rxstatus.rs_moreaggr)
> + ATH_RSSI_LPF(priv->rx.last_rssi,
> + rxbuf->rxstatus.rs_rssi);
>
> - if (likely(last_rssi != ATH_RSSI_DUMMY_MARKER))
> - rxbuf->rxstatus.rs_rssi = ATH_EP_RND(last_rssi,
> - ATH_RSSI_EP_MULTIPLIER);
> + last_rssi = priv->rx.last_rssi;
>
> - if (rxbuf->rxstatus.rs_rssi < 0)
> - rxbuf->rxstatus.rs_rssi = 0;
> + if (likely(last_rssi != ATH_RSSI_DUMMY_MARKER)) {
> + s8 rssi = ATH_EP_RND(last_rssi, ATH_RSSI_EP_MULTIPLIER);
> + rxbuf->rxstatus.rs_rssi = rssi;
> + }
> +
> + if (rxbuf->rxstatus.rs_rssi < 0)
> + rxbuf->rxstatus.rs_rssi = 0;
>
> - if (ieee80211_is_beacon(fc))
> priv->ah->stats.avgbrssi = rxbuf->rxstatus.rs_rssi;
> + }
>
> rx_status->mactime = be64_to_cpu(rxbuf->rxstatus.rs_tstamp);
> rx_status->band = hw->conf.channel->band;
> --
> 1.7.9.5
>
I'm sending this patch again, because I'm not sure if I messed up
something with my mail client in this reply:
http://www.mail-archive.com/ath9k-devel@lists.ath9k.org/msg09470.html
It doesn't show up on gmane for linux-wireless and I didn't get an
answer so far.
Thanks,
Bernhard
^ permalink raw reply [flat|nested] 10+ messages in thread* Re: [PATCH] ath9k_htc: update RSSI values only when the device is associated
2012-12-01 20:26 ` Bernhard Urban
@ 2012-12-03 6:41 ` Mohammed Shafi
2012-12-05 22:13 ` Bernhard Urban
0 siblings, 1 reply; 10+ messages in thread
From: Mohammed Shafi @ 2012-12-03 6:41 UTC (permalink / raw)
To: Bernhard Urban
Cc: linux-wireless, ath9k-devel, c_manoha, Sujith.Manoharan, linville,
m.sujith, nbd, markus
Hi Bernhard,
On Sun, Dec 2, 2012 at 1:56 AM, Bernhard Urban <lewurm@gmail.com> wrote:
> On Sat, Dec 1, 2012 at 9:21 PM, Bernhard Urban <lewurm@gmail.com> wrote:
>> add an if-guard, otherwise iw(8) reports weird signal strengths.
>>
>> The behaviour was fine before this commit:
>> 7c277349ecbd66e19fad3d949fa6ef6c131a3b62
>> This patch is therefore a partially revert of it.
>>
>> Tested with "TP-Link TL-WN722N"
>>
>> Thanks to indoo.rs http://indoo.rs/ for sponsoring
>>
>> Reported-by: Markus Krainz <markus@indoo.rs>
>> Tested-by: Markus Krainz <markus@indoo.rs>
>> Signed-off-by: Bernhard Urban <lewurm@gmail.com>
>> ---
>> drivers/net/wireless/ath/ath9k/htc.h | 1 +
>> drivers/net/wireless/ath/ath9k/htc_drv_txrx.c | 29 +++++++++++++++----------
>> 2 files changed, 19 insertions(+), 11 deletions(-)
>>
>> diff --git a/drivers/net/wireless/ath/ath9k/htc.h b/drivers/net/wireless/ath/ath9k/htc.h
>> index 936e920..00ebf1c 100644
>> --- a/drivers/net/wireless/ath/ath9k/htc.h
>> +++ b/drivers/net/wireless/ath/ath9k/htc.h
>> @@ -22,6 +22,7 @@
>> #include <linux/firmware.h>
>> #include <linux/skbuff.h>
>> #include <linux/netdevice.h>
>> +#include <linux/etherdevice.h>
>> #include <linux/leds.h>
>> #include <linux/slab.h>
>> #include <net/mac80211.h>
>> diff --git a/drivers/net/wireless/ath/ath9k/htc_drv_txrx.c b/drivers/net/wireless/ath/ath9k/htc_drv_txrx.c
>> index 47e61d0..8b4da3d 100644
>> --- a/drivers/net/wireless/ath/ath9k/htc_drv_txrx.c
>> +++ b/drivers/net/wireless/ath/ath9k/htc_drv_txrx.c
>> @@ -969,6 +969,7 @@ static bool ath9k_rx_prepare(struct ath9k_htc_priv *priv,
>> int hdrlen, padpos, padsize;
>> int last_rssi = ATH_RSSI_DUMMY_MARKER;
>> __le16 fc;
>> + u8 is_mybeacon;
>>
>> if (skb->len < HTC_RX_FRAME_HEADER_SIZE) {
>> ath_err(common, "Corrupted RX frame, dropping (len: %d)\n",
>> @@ -1060,22 +1061,28 @@ static bool ath9k_rx_prepare(struct ath9k_htc_priv *priv,
>> ath9k_process_rate(hw, rx_status, rxbuf->rxstatus.rs_rate,
>> rxbuf->rxstatus.rs_flags);
>>
>> - if (rxbuf->rxstatus.rs_rssi != ATH9K_RSSI_BAD &&
>> - !rxbuf->rxstatus.rs_moreaggr)
>> - ATH_RSSI_LPF(priv->rx.last_rssi,
>> - rxbuf->rxstatus.rs_rssi);
>> + is_mybeacon = ieee80211_is_beacon(fc) &&
>> + !is_zero_ether_addr(common->curbssid) &&
>> + ether_addr_equal(hdr->addr3, common->curbssid);
>>
>> - last_rssi = priv->rx.last_rssi;
>> + if (is_mybeacon && priv->ah->opmode == NL80211_IFTYPE_STATION) {
>> + if (rxbuf->rxstatus.rs_rssi != ATH9K_RSSI_BAD &&
>> + !rxbuf->rxstatus.rs_moreaggr)
>> + ATH_RSSI_LPF(priv->rx.last_rssi,
>> + rxbuf->rxstatus.rs_rssi);
should we account for IBSS mode ?
>>
>> - if (likely(last_rssi != ATH_RSSI_DUMMY_MARKER))
>> - rxbuf->rxstatus.rs_rssi = ATH_EP_RND(last_rssi,
>> - ATH_RSSI_EP_MULTIPLIER);
>> + last_rssi = priv->rx.last_rssi;
>>
>> - if (rxbuf->rxstatus.rs_rssi < 0)
>> - rxbuf->rxstatus.rs_rssi = 0;
>> + if (likely(last_rssi != ATH_RSSI_DUMMY_MARKER)) {
>> + s8 rssi = ATH_EP_RND(last_rssi, ATH_RSSI_EP_MULTIPLIER);
>> + rxbuf->rxstatus.rs_rssi = rssi;
>> + }
>> +
>> + if (rxbuf->rxstatus.rs_rssi < 0)
>> + rxbuf->rxstatus.rs_rssi = 0;
>>
>> - if (ieee80211_is_beacon(fc))
>> priv->ah->stats.avgbrssi = rxbuf->rxstatus.rs_rssi;
>> + }
please cross-verify with ath9k's ath9k_process_rssi, otherwise should be fine.
>>
>> rx_status->mactime = be64_to_cpu(rxbuf->rxstatus.rs_tstamp);
>> rx_status->band = hw->conf.channel->band;
>> --
>> 1.7.9.5
>>
>
> I'm sending this patch again, because I'm not sure if I messed up
> something with my mail client in this reply:
> http://www.mail-archive.com/ath9k-devel@lists.ath9k.org/msg09470.html
>
> It doesn't show up on gmane for linux-wireless and I didn't get an
> answer so far.
>
>
> Thanks,
> Bernhard
> --
> To unsubscribe from this list: send the line "unsubscribe linux-wireless" in
> the body of a message to majordomo@vger.kernel.org
> More majordomo info at http://vger.kernel.org/majordomo-info.html
--
thanks,
shafi
^ permalink raw reply [flat|nested] 10+ messages in thread* Re: [PATCH] ath9k_htc: update RSSI values only when the device is associated
2012-12-03 6:41 ` Mohammed Shafi
@ 2012-12-05 22:13 ` Bernhard Urban
0 siblings, 0 replies; 10+ messages in thread
From: Bernhard Urban @ 2012-12-05 22:13 UTC (permalink / raw)
To: Mohammed Shafi
Cc: linux-wireless, ath9k-devel, c_manoha, Sujith.Manoharan, linville,
m.sujith, nbd, markus
Hi Mohammed,
thanks for your comment
On Mon, Dec 3, 2012 at 7:41 AM, Mohammed Shafi <shafi.wireless@gmail.com> wrote:
> >> - last_rssi = priv->rx.last_rssi;
> >> + if (is_mybeacon && priv->ah->opmode == NL80211_IFTYPE_STATION) {
> >> + if (rxbuf->rxstatus.rs_rssi != ATH9K_RSSI_BAD &&
> >> + !rxbuf->rxstatus.rs_moreaggr)
> >> + ATH_RSSI_LPF(priv->rx.last_rssi,
> >> + rxbuf->rxstatus.rs_rssi);
>
> should we account for IBSS mode ?
Yeah, it would make sense but it changes my measureresults
significantly, although my device is never in ad-hoc mode. I already
posted a question regarding this topic:
http://www.mail-archive.com/ath9k-devel@lists.ath9k.org/msg09470.html
Thanks,
Bernhard
^ permalink raw reply [flat|nested] 10+ messages in thread
* [PATCH] ath9k_htc: update RSSI values only when the device is associated
@ 2012-11-09 17:09 Bernhard Urban
2012-11-10 8:42 ` Sujith
2012-11-10 9:15 ` Felix Fietkau
0 siblings, 2 replies; 10+ messages in thread
From: Bernhard Urban @ 2012-11-09 17:09 UTC (permalink / raw)
To: linux-wireless, ath9k-devel, c_manoha, Sujith.Manoharan, linville
Cc: markus, lewurm
add an if-guard, otherwise iw(8) reports weird signal strengths.
The behaviour was fine before this commit:
7c277349ecbd66e19fad3d949fa6ef6c131a3b62
This patch is therefore a partially revert of it.
Tested with "TP-Link TL-WN722N"
Thanks to indoo.rs http://indoo.rs/ for sponsoring
Reported-by: Markus Krainz <markus@indoo.rs>
Tested-by: Markus Krainz <markus@indoo.rs>
Signed-off-by: Bernhard Urban <lewurm@gmail.com>
---
drivers/net/wireless/ath/ath9k/htc_drv_txrx.c | 27 ++++++++++++++-----------
1 file changed, 15 insertions(+), 12 deletions(-)
diff --git a/drivers/net/wireless/ath/ath9k/htc_drv_txrx.c b/drivers/net/wireless/ath/ath9k/htc_drv_txrx.c
index 47e61d0..d0d329c 100644
--- a/drivers/net/wireless/ath/ath9k/htc_drv_txrx.c
+++ b/drivers/net/wireless/ath/ath9k/htc_drv_txrx.c
@@ -1060,22 +1060,25 @@ static bool ath9k_rx_prepare(struct ath9k_htc_priv *priv,
ath9k_process_rate(hw, rx_status, rxbuf->rxstatus.rs_rate,
rxbuf->rxstatus.rs_flags);
- if (rxbuf->rxstatus.rs_rssi != ATH9K_RSSI_BAD &&
- !rxbuf->rxstatus.rs_moreaggr)
- ATH_RSSI_LPF(priv->rx.last_rssi,
- rxbuf->rxstatus.rs_rssi);
+ if (priv->num_sta_assoc_vif != 0) {
+ if (rxbuf->rxstatus.rs_rssi != ATH9K_RSSI_BAD &&
+ !rxbuf->rxstatus.rs_moreaggr)
+ ATH_RSSI_LPF(priv->rx.last_rssi,
+ rxbuf->rxstatus.rs_rssi);
- last_rssi = priv->rx.last_rssi;
+ last_rssi = priv->rx.last_rssi;
- if (likely(last_rssi != ATH_RSSI_DUMMY_MARKER))
- rxbuf->rxstatus.rs_rssi = ATH_EP_RND(last_rssi,
- ATH_RSSI_EP_MULTIPLIER);
+ if (likely(last_rssi != ATH_RSSI_DUMMY_MARKER)) {
+ s8 rssi = ATH_EP_RND(last_rssi, ATH_RSSI_EP_MULTIPLIER);
+ rxbuf->rxstatus.rs_rssi = rssi;
+ }
- if (rxbuf->rxstatus.rs_rssi < 0)
- rxbuf->rxstatus.rs_rssi = 0;
+ if (rxbuf->rxstatus.rs_rssi < 0)
+ rxbuf->rxstatus.rs_rssi = 0;
- if (ieee80211_is_beacon(fc))
- priv->ah->stats.avgbrssi = rxbuf->rxstatus.rs_rssi;
+ if (ieee80211_is_beacon(fc))
+ priv->ah->stats.avgbrssi = rxbuf->rxstatus.rs_rssi;
+ }
rx_status->mactime = be64_to_cpu(rxbuf->rxstatus.rs_tstamp);
rx_status->band = hw->conf.channel->band;
--
1.7.9.5
^ permalink raw reply related [flat|nested] 10+ messages in thread* [PATCH] ath9k_htc: update RSSI values only when the device is associated
2012-11-09 17:09 Bernhard Urban
@ 2012-11-10 8:42 ` Sujith
2012-11-10 9:15 ` Felix Fietkau
1 sibling, 0 replies; 10+ messages in thread
From: Sujith @ 2012-11-10 8:42 UTC (permalink / raw)
To: Bernhard Urban; +Cc: linux-wireless, ath9k-devel, c_manoha, linville, markus
Bernhard Urban wrote:
> add an if-guard, otherwise iw(8) reports weird signal strengths.
>
> The behaviour was fine before this commit:
> 7c277349ecbd66e19fad3d949fa6ef6c131a3b62
> This patch is therefore a partially revert of it.
>
> Tested with "TP-Link TL-WN722N"
Looks good, but a cleaner fix would be to update the RSSI only for
beacons that are destined for the station.
Sujith
^ permalink raw reply [flat|nested] 10+ messages in thread
* Re: [PATCH] ath9k_htc: update RSSI values only when the device is associated
2012-11-09 17:09 Bernhard Urban
2012-11-10 8:42 ` Sujith
@ 2012-11-10 9:15 ` Felix Fietkau
2012-11-17 19:12 ` Bernhard Urban
1 sibling, 1 reply; 10+ messages in thread
From: Felix Fietkau @ 2012-11-10 9:15 UTC (permalink / raw)
To: Bernhard Urban
Cc: linux-wireless, ath9k-devel, c_manoha, Sujith.Manoharan, linville,
markus
On 2012-11-09 6:09 PM, Bernhard Urban wrote:
> add an if-guard, otherwise iw(8) reports weird signal strengths.
>
> The behaviour was fine before this commit:
> 7c277349ecbd66e19fad3d949fa6ef6c131a3b62
> This patch is therefore a partially revert of it.
>
> Tested with "TP-Link TL-WN722N"
>
> Thanks to indoo.rs http://indoo.rs/ for sponsoring
>
> Reported-by: Markus Krainz <markus@indoo.rs>
> Tested-by: Markus Krainz <markus@indoo.rs>
> Signed-off-by: Bernhard Urban <lewurm@gmail.com>
> ---
> drivers/net/wireless/ath/ath9k/htc_drv_txrx.c | 27 ++++++++++++++-----------
> 1 file changed, 15 insertions(+), 12 deletions(-)
>
> diff --git a/drivers/net/wireless/ath/ath9k/htc_drv_txrx.c b/drivers/net/wireless/ath/ath9k/htc_drv_txrx.c
> index 47e61d0..d0d329c 100644
> --- a/drivers/net/wireless/ath/ath9k/htc_drv_txrx.c
> +++ b/drivers/net/wireless/ath/ath9k/htc_drv_txrx.c
> @@ -1060,22 +1060,25 @@ static bool ath9k_rx_prepare(struct ath9k_htc_priv *priv,
> ath9k_process_rate(hw, rx_status, rxbuf->rxstatus.rs_rate,
> rxbuf->rxstatus.rs_flags);
>
> - if (rxbuf->rxstatus.rs_rssi != ATH9K_RSSI_BAD &&
> - !rxbuf->rxstatus.rs_moreaggr)
> - ATH_RSSI_LPF(priv->rx.last_rssi,
> - rxbuf->rxstatus.rs_rssi);
> + if (priv->num_sta_assoc_vif != 0) {
> + if (rxbuf->rxstatus.rs_rssi != ATH9K_RSSI_BAD &&
> + !rxbuf->rxstatus.rs_moreaggr)
> + ATH_RSSI_LPF(priv->rx.last_rssi,
> + rxbuf->rxstatus.rs_rssi);
>
> - last_rssi = priv->rx.last_rssi;
> + last_rssi = priv->rx.last_rssi;
>
> - if (likely(last_rssi != ATH_RSSI_DUMMY_MARKER))
> - rxbuf->rxstatus.rs_rssi = ATH_EP_RND(last_rssi,
> - ATH_RSSI_EP_MULTIPLIER);
> + if (likely(last_rssi != ATH_RSSI_DUMMY_MARKER)) {
> + s8 rssi = ATH_EP_RND(last_rssi, ATH_RSSI_EP_MULTIPLIER);
> + rxbuf->rxstatus.rs_rssi = rssi;
> + }
>
> - if (rxbuf->rxstatus.rs_rssi < 0)
> - rxbuf->rxstatus.rs_rssi = 0;
> + if (rxbuf->rxstatus.rs_rssi < 0)
> + rxbuf->rxstatus.rs_rssi = 0;
>
> - if (ieee80211_is_beacon(fc))
> - priv->ah->stats.avgbrssi = rxbuf->rxstatus.rs_rssi;
> + if (ieee80211_is_beacon(fc))
> + priv->ah->stats.avgbrssi = rxbuf->rxstatus.rs_rssi;
> + }
>
> rx_status->mactime = be64_to_cpu(rxbuf->rxstatus.rs_tstamp);
> rx_status->band = hw->conf.channel->band;
>
Please check how RSSI is handled in ath9k, and use that as reference.
The per-packet RSSI should not be set from some internal average, it
should contain the real RSSI value of the packet. This change disables
RSSI reporting for anything but station mode, which is not a good idea.
- Felix
^ permalink raw reply [flat|nested] 10+ messages in thread* Re: [PATCH] ath9k_htc: update RSSI values only when the device is associated
2012-11-10 9:15 ` Felix Fietkau
@ 2012-11-17 19:12 ` Bernhard Urban
0 siblings, 0 replies; 10+ messages in thread
From: Bernhard Urban @ 2012-11-17 19:12 UTC (permalink / raw)
To: Felix Fietkau
Cc: linux-wireless, ath9k-devel, c_manoha, Sujith.Manoharan, linville,
markus, m.sujith
Thanks for the reviews!
On Sat, Nov 10, 2012 at 9:42 AM, Sujith <m.sujith@gmail.com> wrote:
> Looks good, but a cleaner fix would be to update the RSSI only for
> beacons that are destined for the station.
You mean like in recv.c? There's a `is_mybeacon' field, which is computed in
`ath_rx_tasklet(...)' and used in `ath9k_process_rssi(...)'.
Adding this check to the if-guard changes nothing at the result, so I think
it's fine if you consider it as cleaner. See attached patch.
Btw, could you please elaborate what `is_mybeacon' represents?
On Sat, Nov 10, 2012 at 10:15 AM, Felix Fietkau <nbd@openwrt.org> wrote:
> Please check how RSSI is handled in ath9k, and use that as reference.
> The per-packet RSSI should not be set from some internal average, it
> should contain the real RSSI value of the packet. This change disables
> RSSI reporting for anything but station mode, which is not a good idea.
Replacing
if (priv->num_sta_assoc_vif != 0)
with
if (priv->ah->opmode == NL80211_IFTYPE_STATION)
works out well (which makes sense to me). However, adding
`&& priv->ah->opmode == NL80211_IFTYPE_ADHOC' (like in ath9k/recv.c) produces
bad results like before. I don't understand the effect, as my device is always
in "managed mode" according to `iw wlan0 info'. I'm right by assuming "managed
mode" is the same as NL80211_IFTYPE_STATION?
Also, I don't know what you mean with "some internal average". Can you please
elaborate that?
Thanks for your help,
Bernhard
>From fc14c46ce75044485229be5bb12682a8fffcf178 Mon Sep 17 00:00:00 2001
From: Bernhard Urban <lewurm@gmail.com>
Date: Sat, 17 Nov 2012 00:22:16 +0100
Subject: [PATCH] ath9k_htc: update RSSI values only when the device is
associated
add an if-guard, otherwise iw(8) reports weird signal strengths.
The behaviour was fine before this commit:
7c277349ecbd66e19fad3d949fa6ef6c131a3b62
This patch is therefore a partially revert of it.
Tested with "TP-Link TL-WN722N"
Thanks to indoo.rs http://indoo.rs/ for sponsoring
Reported-by: Markus Krainz <markus@indoo.rs>
Tested-by: Markus Krainz <markus@indoo.rs>
Signed-off-by: Bernhard Urban <lewurm@gmail.com>
---
drivers/net/wireless/ath/ath9k/htc.h | 1 +
drivers/net/wireless/ath/ath9k/htc_drv_txrx.c | 29 +++++++++++++++----------
2 files changed, 19 insertions(+), 11 deletions(-)
diff --git a/drivers/net/wireless/ath/ath9k/htc.h b/drivers/net/wireless/ath/ath9k/htc.h
index 936e920..00ebf1c 100644
--- a/drivers/net/wireless/ath/ath9k/htc.h
+++ b/drivers/net/wireless/ath/ath9k/htc.h
@@ -22,6 +22,7 @@
#include <linux/firmware.h>
#include <linux/skbuff.h>
#include <linux/netdevice.h>
+#include <linux/etherdevice.h>
#include <linux/leds.h>
#include <linux/slab.h>
#include <net/mac80211.h>
diff --git a/drivers/net/wireless/ath/ath9k/htc_drv_txrx.c b/drivers/net/wireless/ath/ath9k/htc_drv_txrx.c
index 47e61d0..8b4da3d 100644
--- a/drivers/net/wireless/ath/ath9k/htc_drv_txrx.c
+++ b/drivers/net/wireless/ath/ath9k/htc_drv_txrx.c
@@ -969,6 +969,7 @@ static bool ath9k_rx_prepare(struct ath9k_htc_priv *priv,
int hdrlen, padpos, padsize;
int last_rssi = ATH_RSSI_DUMMY_MARKER;
__le16 fc;
+ u8 is_mybeacon;
if (skb->len < HTC_RX_FRAME_HEADER_SIZE) {
ath_err(common, "Corrupted RX frame, dropping (len: %d)\n",
@@ -1060,22 +1061,28 @@ static bool ath9k_rx_prepare(struct ath9k_htc_priv *priv,
ath9k_process_rate(hw, rx_status, rxbuf->rxstatus.rs_rate,
rxbuf->rxstatus.rs_flags);
- if (rxbuf->rxstatus.rs_rssi != ATH9K_RSSI_BAD &&
- !rxbuf->rxstatus.rs_moreaggr)
- ATH_RSSI_LPF(priv->rx.last_rssi,
- rxbuf->rxstatus.rs_rssi);
+ is_mybeacon = ieee80211_is_beacon(fc) &&
+ !is_zero_ether_addr(common->curbssid) &&
+ ether_addr_equal(hdr->addr3, common->curbssid);
- last_rssi = priv->rx.last_rssi;
+ if (is_mybeacon && priv->ah->opmode == NL80211_IFTYPE_STATION) {
+ if (rxbuf->rxstatus.rs_rssi != ATH9K_RSSI_BAD &&
+ !rxbuf->rxstatus.rs_moreaggr)
+ ATH_RSSI_LPF(priv->rx.last_rssi,
+ rxbuf->rxstatus.rs_rssi);
- if (likely(last_rssi != ATH_RSSI_DUMMY_MARKER))
- rxbuf->rxstatus.rs_rssi = ATH_EP_RND(last_rssi,
- ATH_RSSI_EP_MULTIPLIER);
+ last_rssi = priv->rx.last_rssi;
- if (rxbuf->rxstatus.rs_rssi < 0)
- rxbuf->rxstatus.rs_rssi = 0;
+ if (likely(last_rssi != ATH_RSSI_DUMMY_MARKER)) {
+ s8 rssi = ATH_EP_RND(last_rssi, ATH_RSSI_EP_MULTIPLIER);
+ rxbuf->rxstatus.rs_rssi = rssi;
+ }
+
+ if (rxbuf->rxstatus.rs_rssi < 0)
+ rxbuf->rxstatus.rs_rssi = 0;
- if (ieee80211_is_beacon(fc))
priv->ah->stats.avgbrssi = rxbuf->rxstatus.rs_rssi;
+ }
rx_status->mactime = be64_to_cpu(rxbuf->rxstatus.rs_tstamp);
rx_status->band = hw->conf.channel->band;
--
1.7.9.5
^ permalink raw reply related [flat|nested] 10+ messages in thread
end of thread, other threads:[~2013-02-05 22:05 UTC | newest]
Thread overview: 10+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2013-02-01 12:50 [PATCH] ath9k_htc: update RSSI values only when the device is associated Bernhard Urban
2013-02-05 22:05 ` Felix Fietkau
-- strict thread matches above, loose matches on Subject: below --
2012-12-01 20:21 Bernhard Urban
2012-12-01 20:26 ` Bernhard Urban
2012-12-03 6:41 ` Mohammed Shafi
2012-12-05 22:13 ` Bernhard Urban
2012-11-09 17:09 Bernhard Urban
2012-11-10 8:42 ` Sujith
2012-11-10 9:15 ` Felix Fietkau
2012-11-17 19:12 ` Bernhard Urban
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).