From: Xose Vazquez Perez <xose.vazquez@gmail.com>
To: Larry Finger <Larry.Finger@lwfinger.net>
Cc: Thomas Rosenkranz <tom.rosary@googlemail.com>,
linux-wireless <linux-wireless@vger.kernel.org>
Subject: Re: FW: 0bda:819a RTL8188CUS WLAN doesn't work out of the box in downstream and upstreamkernel
Date: Wed, 06 Feb 2013 01:03:17 +0100 [thread overview]
Message-ID: <51119DC5.8020200@gmail.com> (raw)
In-Reply-To: <511199A1.8000207@lwfinger.net>
On 02/06/2013 12:45 AM, Larry Finger wrote:
>> Then, remove the "new_id" facility of the driver.
>>
>> *Or* fix the driver. rt2x00 handles correctly any
>> kind of unknown device.
>
> The attached patch will fix the oops when a foreign new_id is inserted. I will be submitting it soon.
> Index: wireless-testing-new/drivers/net/wireless/rtlwifi/usb.c
> ===================================================================
> --- wireless-testing-new.orig/drivers/net/wireless/rtlwifi/usb.c
> +++ wireless-testing-new/drivers/net/wireless/rtlwifi/usb.c
> @@ -977,6 +977,9 @@ int rtl_usb_probe(struct usb_interface *
> rtl_dbgp_flag_init(hw);
> /* Init IO handler */
> _rtl_usb_io_handler_init(&udev->dev, hw);
> + if (!rtlpriv->cfg || !rtlpriv->cfg->ops ||
> + !rtlpriv->cfg->ops->read_chip_version)
> + return -ENODEV;
> rtlpriv->cfg->ops->read_chip_version(hw);
> /*like read eeprom and so on */
> rtlpriv->cfg->ops->read_eeprom_info(hw);
>
How about pci devices(rtlwifi/pci.c) ?
thank you.
next prev parent reply other threads:[~2013-02-06 0:03 UTC|newest]
Thread overview: 16+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-02-04 21:41 FW: 0bda:819a RTL8188CUS WLAN doesn't work out of the box in downstream and upstreamkernel Xose Vazquez Perez
[not found] ` <CAOAX8-k-Nbx4Om8fkEHRW2jmZCxKpsMY6oEZMAvdEQpXWn9Mdw@mail.gmail.com>
2013-02-04 23:13 ` Larry Finger
2013-02-04 23:26 ` Xose Vazquez Perez
[not found] ` <CAOAX8-kFtWuwEvz9v7hBzOwtohJx0NezrDHC0iVwXF29YYSCgQ@mail.gmail.com>
2013-02-05 18:33 ` Thomas Rosenkranz
2013-02-05 19:03 ` Larry Finger
[not found] ` <CAOAX8-mMsXu5h-7q2EJEc9SehWS=yqAb4YvbfOVBQKhdH+LqTQ@mail.gmail.com>
2013-02-05 18:36 ` Fwd: " Thomas Rosenkranz
2013-02-05 19:55 ` Xose Vazquez Perez
2013-02-05 20:23 ` Larry Finger
2013-02-05 21:18 ` Thomas Rosenkranz
2013-02-05 21:28 ` Xose Vazquez Perez
2013-02-05 21:54 ` Larry Finger
2013-02-05 22:37 ` Xose Vazquez Perez
2013-02-05 23:45 ` Larry Finger
2013-02-06 0:03 ` Xose Vazquez Perez [this message]
-- strict thread matches above, loose matches on Subject: below --
2013-02-04 17:50 Thomas Rosenkranz
2013-02-04 19:49 ` Larry Finger
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=51119DC5.8020200@gmail.com \
--to=xose.vazquez@gmail.com \
--cc=Larry.Finger@lwfinger.net \
--cc=linux-wireless@vger.kernel.org \
--cc=tom.rosary@googlemail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).