* [PATCH] rtlwifi: Rework Kconfig
@ 2013-02-12 19:45 Larry Finger
2013-02-12 19:52 ` Larry Finger
0 siblings, 1 reply; 5+ messages in thread
From: Larry Finger @ 2013-02-12 19:45 UTC (permalink / raw)
To: John W Linville; +Cc: linux-wireless
#
# For a description of the syntax of this configuration file,
# see Documentation/kbuild/kconfig-language.txt.
#
mainmenu "Linux/$ARCH $KERNELVERSION Kernel Configuration"
config SRCARCH
string
option env="SRCARCH"
source "arch/$SRCARCH/Kconfig"
^ permalink raw reply [flat|nested] 5+ messages in thread
* [PATCH] rtlwifi: Rework Kconfig
@ 2013-02-12 19:45 Larry Finger
2013-02-12 19:54 ` Joe Perches
0 siblings, 1 reply; 5+ messages in thread
From: Larry Finger @ 2013-02-12 19:45 UTC (permalink / raw)
To: John W Linville; +Cc: linux-wireless
As the number of drivers in the rtlwifi family has grown, the Kconfig
section for them has grown unwieldy. This change has two effects: (1)
Variable RTLWIFI_DEBUG is documented, and (2) the entries for the
drivers that depend on RTLWIFI and indented.
Signed-off-by: Larry Finger <Larry.Finger@lwfinger.net>
---
John,
This patch has no particular urgency. It makes no functional
change in the kernel,
Thanks,
Larry
---
Kconfig | 50 +++++++++++++++++++++++++-------------------------
1 file changed, 25 insertions(+), 25 deletions(-)
---
Index: wireless-testing-new/drivers/net/wireless/rtlwifi/Kconfig
===================================================================
--- wireless-testing-new.orig/drivers/net/wireless/rtlwifi/Kconfig
+++ wireless-testing-new/drivers/net/wireless/rtlwifi/Kconfig
@@ -1,8 +1,26 @@
+config RTLWIFI
+ tristate "Realtek wireless card support"
+ depends on MAC80211
+ select FW_LOADER
+ ---help---
+ This is common code for RTL8192CE/RTL8192CU/RTL8192SE/RTL8723AE
+ drivers. This module does nothing by itself - the various front-end
+ drivers need to be enabled to support any desired devices.
+
+ If you choose to build as a module, it'll be called rtlwifi.
+
+config RTLWIFI_DEBUG
+ bool "Debugging output for rtlwifi driver family"
+ depends on RTLWIFI
+ default y
+ ---help---
+ This option is needed for the "debug=n" module option to produce any
+ output. For embedded or other memory-limited systems, choose "N".
+ For all other systems, or if in doubt, use "Y".
+
config RTL8192CE
tristate "Realtek RTL8192CE/RTL8188CE Wireless Network Adapter"
- depends on MAC80211 && PCI
- select FW_LOADER
- select RTLWIFI
+ depends on RTLWIFI && PCI
select RTL8192C_COMMON
---help---
This is the driver for Realtek RTL8192CE/RTL8188CE 802.11n PCIe
@@ -12,9 +30,7 @@ config RTL8192CE
config RTL8192SE
tristate "Realtek RTL8192SE/RTL8191SE PCIe Wireless Network Adapter"
- depends on MAC80211 && PCI
- select FW_LOADER
- select RTLWIFI
+ depends on RTLWIFI && PCI
---help---
This is the driver for Realtek RTL8192SE/RTL8191SE 802.11n PCIe
wireless network adapters.
@@ -23,9 +39,7 @@ config RTL8192SE
config RTL8192DE
tristate "Realtek RTL8192DE/RTL8188DE PCIe Wireless Network Adapter"
- depends on MAC80211 && PCI
- select FW_LOADER
- select RTLWIFI
+ depends on RTLWIFI && PCI
---help---
This is the driver for Realtek RTL8192DE/RTL8188DE 802.11n PCIe
wireless network adapters.
@@ -34,9 +48,7 @@ config RTL8192DE
config RTL8723AE
tristate "Realtek RTL8723AE PCIe Wireless Network Adapter"
- depends on MAC80211 && PCI && EXPERIMENTAL
- select FW_LOADER
- select RTLWIFI
+ depends on RTLWIFI && PCI
---help---
This is the driver for Realtek RTL8723AE 802.11n PCIe
wireless network adapters.
@@ -45,9 +57,7 @@ config RTL8723AE
config RTL8192CU
tristate "Realtek RTL8192CU/RTL8188CU USB Wireless Network Adapter"
- depends on MAC80211 && USB
- select FW_LOADER
- select RTLWIFI
+ depends on RTLWIFI && USB
select RTL8192C_COMMON
---help---
This is the driver for Realtek RTL8192CU/RTL8188CU 802.11n USB
@@ -55,16 +65,6 @@ config RTL8192CU
If you choose to build it as a module, it will be called rtl8192cu
-config RTLWIFI
- tristate
- depends on RTL8192CE || RTL8192CU || RTL8192SE || RTL8192DE || RTL8723AE
- default m
-
-config RTLWIFI_DEBUG
- bool "Additional debugging output"
- depends on RTL8192CE || RTL8192CU || RTL8192SE || RTL8192DE || RTL8723AE
- default y
-
config RTL8192C_COMMON
tristate
depends on RTL8192CE || RTL8192CU
^ permalink raw reply [flat|nested] 5+ messages in thread
* Re: [PATCH] rtlwifi: Rework Kconfig
2013-02-12 19:45 [PATCH] rtlwifi: Rework Kconfig Larry Finger
@ 2013-02-12 19:52 ` Larry Finger
0 siblings, 0 replies; 5+ messages in thread
From: Larry Finger @ 2013-02-12 19:52 UTC (permalink / raw)
To: John W Linville; +Cc: linux-wireless
On 02/12/2013 01:45 PM, Larry Finger wrote:
> #
> # For a description of the syntax of this configuration file,
> # see Documentation/kbuild/kconfig-language.txt.
> #
> mainmenu "Linux/$ARCH $KERNELVERSION Kernel Configuration"
>
> config SRCARCH
> string
> option env="SRCARCH"
>
> source "arch/$SRCARCH/Kconfig"
In case there is any confusion, this is garbage and resulted from an operator
problem. The other E-mail with the same subject is correct.
Larry
^ permalink raw reply [flat|nested] 5+ messages in thread
* Re: [PATCH] rtlwifi: Rework Kconfig
2013-02-12 19:45 Larry Finger
@ 2013-02-12 19:54 ` Joe Perches
2013-02-12 20:18 ` Larry Finger
0 siblings, 1 reply; 5+ messages in thread
From: Joe Perches @ 2013-02-12 19:54 UTC (permalink / raw)
To: Larry Finger; +Cc: John W Linville, linux-wireless
On Tue, 2013-02-12 at 13:45 -0600, Larry Finger wrote:
> As the number of drivers in the rtlwifi family has grown, the Kconfig
> section for them has grown unwieldy. This change has two effects: (1)
> Variable RTLWIFI_DEBUG is documented, and (2) the entries for the
> drivers that depend on RTLWIFI and indented.
trivial note below:
> +++ wireless-testing-new/drivers/net/wireless/rtlwifi/Kconfig
> @@ -1,8 +1,26 @@
[]
> +config RTLWIFI_DEBUG
> + bool "Debugging output for rtlwifi driver family"
> + depends on RTLWIFI
> + default y
> + ---help---
> + This option is needed for the "debug=n" module option to produce any
> + output. For embedded or other memory-limited systems, choose "N".
> + For all other systems, or if in doubt, use "Y".
using "debug=n" here can be a bit confusing given the
"N" and "Y" that follow it.
maybe debug=<0x...> module parameter to control debug
message level output.
^ permalink raw reply [flat|nested] 5+ messages in thread
* Re: [PATCH] rtlwifi: Rework Kconfig
2013-02-12 19:54 ` Joe Perches
@ 2013-02-12 20:18 ` Larry Finger
0 siblings, 0 replies; 5+ messages in thread
From: Larry Finger @ 2013-02-12 20:18 UTC (permalink / raw)
To: Joe Perches; +Cc: John W Linville, linux-wireless
On 02/12/2013 01:54 PM, Joe Perches wrote:
> On Tue, 2013-02-12 at 13:45 -0600, Larry Finger wrote:
>> As the number of drivers in the rtlwifi family has grown, the Kconfig
>> section for them has grown unwieldy. This change has two effects: (1)
>> Variable RTLWIFI_DEBUG is documented, and (2) the entries for the
>> drivers that depend on RTLWIFI and indented.
>
> trivial note below:
>
>> +++ wireless-testing-new/drivers/net/wireless/rtlwifi/Kconfig
>> @@ -1,8 +1,26 @@
> []
>> +config RTLWIFI_DEBUG
>> + bool "Debugging output for rtlwifi driver family"
>> + depends on RTLWIFI
>> + default y
>> + ---help---
>> + This option is needed for the "debug=n" module option to produce any
>> + output. For embedded or other memory-limited systems, choose "N".
>> + For all other systems, or if in doubt, use "Y".
>
> using "debug=n" here can be a bit confusing given the
> "N" and "Y" that follow it.
>
> maybe debug=<0x...> module parameter to control debug
> message level output.
How about the following:
This option must be "Y" for the module option for dynamic debugging
to produce any output. For embedded or other memory-limited systems,
choose "N". If in doubt, choose "Y".
Larry
^ permalink raw reply [flat|nested] 5+ messages in thread
end of thread, other threads:[~2013-02-12 20:18 UTC | newest]
Thread overview: 5+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2013-02-12 19:45 [PATCH] rtlwifi: Rework Kconfig Larry Finger
2013-02-12 19:52 ` Larry Finger
-- strict thread matches above, loose matches on Subject: below --
2013-02-12 19:45 Larry Finger
2013-02-12 19:54 ` Joe Perches
2013-02-12 20:18 ` Larry Finger
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).