From: Larry Finger <Larry.Finger@lwfinger.net>
To: Joe Perches <joe@perches.com>
Cc: John W Linville <linville@tuxdriver.com>, linux-wireless@vger.kernel.org
Subject: Re: [PATCH] rtlwifi: Rework Kconfig
Date: Tue, 12 Feb 2013 14:18:29 -0600 [thread overview]
Message-ID: <511AA395.8000802@lwfinger.net> (raw)
In-Reply-To: <1360698872.17456.11.camel@joe-AO722>
On 02/12/2013 01:54 PM, Joe Perches wrote:
> On Tue, 2013-02-12 at 13:45 -0600, Larry Finger wrote:
>> As the number of drivers in the rtlwifi family has grown, the Kconfig
>> section for them has grown unwieldy. This change has two effects: (1)
>> Variable RTLWIFI_DEBUG is documented, and (2) the entries for the
>> drivers that depend on RTLWIFI and indented.
>
> trivial note below:
>
>> +++ wireless-testing-new/drivers/net/wireless/rtlwifi/Kconfig
>> @@ -1,8 +1,26 @@
> []
>> +config RTLWIFI_DEBUG
>> + bool "Debugging output for rtlwifi driver family"
>> + depends on RTLWIFI
>> + default y
>> + ---help---
>> + This option is needed for the "debug=n" module option to produce any
>> + output. For embedded or other memory-limited systems, choose "N".
>> + For all other systems, or if in doubt, use "Y".
>
> using "debug=n" here can be a bit confusing given the
> "N" and "Y" that follow it.
>
> maybe debug=<0x...> module parameter to control debug
> message level output.
How about the following:
This option must be "Y" for the module option for dynamic debugging
to produce any output. For embedded or other memory-limited systems,
choose "N". If in doubt, choose "Y".
Larry
next prev parent reply other threads:[~2013-02-12 20:18 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-02-12 19:45 [PATCH] rtlwifi: Rework Kconfig Larry Finger
2013-02-12 19:54 ` Joe Perches
2013-02-12 20:18 ` Larry Finger [this message]
-- strict thread matches above, loose matches on Subject: below --
2013-02-12 19:45 Larry Finger
2013-02-12 19:52 ` Larry Finger
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=511AA395.8000802@lwfinger.net \
--to=larry.finger@lwfinger.net \
--cc=joe@perches.com \
--cc=linux-wireless@vger.kernel.org \
--cc=linville@tuxdriver.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).