linux-wireless.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Ben Greear <greearb@candelatech.com>
To: Johannes Berg <johannes@sipsolutions.net>
Cc: "linux-wireless@vger.kernel.org" <linux-wireless@vger.kernel.org>
Subject: Re: Crash on removal of 400 interfaces (3.7.6+)
Date: Tue, 19 Feb 2013 16:39:23 -0800	[thread overview]
Message-ID: <51241B3B.9030405@candelatech.com> (raw)
In-Reply-To: <51240EE6.9040201@candelatech.com>

On 02/19/2013 03:46 PM, Ben Greear wrote:
> On 02/19/2013 03:24 PM, Ben Greear wrote:
>> On 02/19/2013 02:52 PM, Ben Greear wrote:
>>> On 02/18/2013 02:16 PM, Johannes Berg wrote:
>>>> On Mon, 2013-02-18 at 14:14 -0800, Ben Greear wrote:
>>>>> We often see crashes in work-queue processing when deleting
>>>>> lots of wifi station interfaces.  I'm guessing that there is probably
>>>>> a work item that was not properly un-registered before deleting
>>>>> memory.  I have backported some wifi fixes from upstream, so
>>>>> maybe they are to blame, but in case anyone has any suggestions
>>>>> for places to look, please let me know.
>>>>
>>>> Enable CONFIG_DEBUG_OBJECTS and CONFIG_DEBUG_OBJECTS_WORK :)
>>>
>>> That did not catch anything.
>
> So, maybe the problem is in the sta_quiesce logic.
>
> It cancels the work items before it stops the timers, so
> I think it could re-add the work before the timers are
> stopped??

Maybe not just this, at least.  In my case, I'm never seeing the
sta_quiesce code called at all..I guess it is just for cases
where we are quiescing the hardware.

So, what is supposed to clean up these work items (and timers?)
when we are deleting an interface?

Thanks,
Ben

-- 
Ben Greear <greearb@candelatech.com>
Candela Technologies Inc  http://www.candelatech.com


      reply	other threads:[~2013-02-20  0:39 UTC|newest]

Thread overview: 6+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2013-02-18 22:14 Crash on removal of 400 interfaces (3.7.6+) Ben Greear
2013-02-18 22:16 ` Johannes Berg
2013-02-19 22:52   ` Ben Greear
2013-02-19 23:24     ` Ben Greear
2013-02-19 23:46       ` Ben Greear
2013-02-20  0:39         ` Ben Greear [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=51241B3B.9030405@candelatech.com \
    --to=greearb@candelatech.com \
    --cc=johannes@sipsolutions.net \
    --cc=linux-wireless@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).