* Dead code in brcms_c_compute_rspec
@ 2013-02-24 13:20 Rafał Miłecki
2013-02-25 10:22 ` Arend van Spriel
0 siblings, 1 reply; 2+ messages in thread
From: Rafał Miłecki @ 2013-02-24 13:20 UTC (permalink / raw)
To: brcm80211 development; +Cc: linux-wireless
Hey,
I was looking for adding support for more devices in b43 and wanted to
check how did you handled reading PHY type/id from rxchan/chanstat
(it's a part of hardware-specific part of RX header).
In rate.c you have brcms_c_compute_rspec which does:
phy_type = ((rxh->RxChan & RXS_CHAN_PHYTYPE_MASK) >> RXS_CHAN_PHYTYPE_SHIFT);
(you duplicate BRCMS_CHAN_PHYTYPE by the way).
The problem is that:
#define RXS_CHAN_PHYTYPE_MASK 0x0007
and you're comparing the result to the
#define PHY_TYPE_LCN 8
which looks like a minor dead code for me.
You may want to fix that.
--
Rafał
^ permalink raw reply [flat|nested] 2+ messages in thread
* Re: Dead code in brcms_c_compute_rspec
2013-02-24 13:20 Dead code in brcms_c_compute_rspec Rafał Miłecki
@ 2013-02-25 10:22 ` Arend van Spriel
0 siblings, 0 replies; 2+ messages in thread
From: Arend van Spriel @ 2013-02-25 10:22 UTC (permalink / raw)
To: Rafał Miłecki; +Cc: brcm80211 development, linux-wireless
On 02/24/13 14:20, Rafał Miłecki wrote:
> Hey,
>
> I was looking for adding support for more devices in b43 and wanted to
> check how did you handled reading PHY type/id from rxchan/chanstat
> (it's a part of hardware-specific part of RX header).
>
> In rate.c you have brcms_c_compute_rspec which does:
> phy_type = ((rxh->RxChan& RXS_CHAN_PHYTYPE_MASK)>> RXS_CHAN_PHYTYPE_SHIFT);
> (you duplicate BRCMS_CHAN_PHYTYPE by the way).
>
> The problem is that:
> #define RXS_CHAN_PHYTYPE_MASK 0x0007
> and you're comparing the result to the
> #define PHY_TYPE_LCN 8
> which looks like a minor dead code for me.
>
> You may want to fix that.
>
Thanks, Rafał
That does not seem right. I will look into this.
Gr. AvS
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2013-02-25 10:23 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2013-02-24 13:20 Dead code in brcms_c_compute_rspec Rafał Miłecki
2013-02-25 10:22 ` Arend van Spriel
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).