From: Hauke Mehrtens <hauke@hauke-m.de>
To: Arend van Spriel <arend@broadcom.com>
Cc: linville@tuxdriver.com, linux-wireless@vger.kernel.org,
brcm80211-dev-list@broadcom.com
Subject: Re: [PATCH] brcmsmac: export firmware version to ethtool
Date: Mon, 25 Feb 2013 20:05:30 +0100 [thread overview]
Message-ID: <512BB5FA.8050206@hauke-m.de> (raw)
In-Reply-To: <512B72BE.5050808@broadcom.com>
On 02/25/2013 03:18 PM, Arend van Spriel wrote:
> On 02/24/13 16:41, Hauke Mehrtens wrote:
>> This exports the firmware version in use to userspace through ethtool.
>>
>> root@OpenWrt:/# ethtool -i wlan0
>> firmware-version: 610.812
>
> This info is already available under debugfs although I prefer your
> formatting :-) :
I used the same formating b43 uses, I do not know what's the official
formating for this firmware version number.
Writing the firmware version to wiphy->fw_version is the official way to
do this and many drivers already are exporting their firmware version in
this way.
I would prefer export the firmware version this way and also add it to
the hardware info in debugfs, where it already is.
Hauke
prev parent reply other threads:[~2013-02-25 19:05 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-02-24 15:41 [PATCH] brcmsmac: export firmware version to ethtool Hauke Mehrtens
2013-02-25 14:18 ` Arend van Spriel
2013-02-25 19:05 ` Hauke Mehrtens [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=512BB5FA.8050206@hauke-m.de \
--to=hauke@hauke-m.de \
--cc=arend@broadcom.com \
--cc=brcm80211-dev-list@broadcom.com \
--cc=linux-wireless@vger.kernel.org \
--cc=linville@tuxdriver.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).