From: Larry Finger <Larry.Finger@lwfinger.net>
To: shuah.khan@hp.com
Cc: brudley@broadcom.com, arend@broadcom.com, frankyl@broadcom.com,
linville@tuxdriver.com, seth.forshee@canonical.com,
pieterpg@broadcom.com, linux-wireless@vger.kernel.org,
brcm80211-dev-list@broadcom.com, netdev@vger.kernel.org,
LKML <linux-kernel@vger.kernel.org>,
shuahkhan@gmail.com
Subject: Re: [PATCH] net/wireless/brcm80211: remove PCI_BUS define from defs.h to fix warnings
Date: Mon, 04 Mar 2013 19:28:08 -0600 [thread overview]
Message-ID: <51354A28.3040607@lwfinger.net> (raw)
In-Reply-To: <1362445374.4591.28.camel@lorien2>
On 03/04/2013 07:02 PM, Shuah Khan wrote:
> PCI_BUS defined in defs.h results in warnings from all brcm80211 source files
> including defs.h. This define is not used in brcm80211. Removing this define
> fixes the warning.
>
> In file included from drivers/net/wireless/brcm80211/brcmfmac/dhd_sdio.c:35:0:
> drivers/net/wireless/brcm80211/include/defs.h:23:0: warning: "PCI_BUS" redefined [enabled by default]
> include/uapi/linux/pci.h:36:0: note: this is the location of the previous definition
> CC [M] drivers/net/wireless/b43legacy/dma.o
> CC [M] drivers/net/wireless/brcm80211/brcmfmac/bcmsdh.o
> CC [M] drivers/net/wireless/b43legacy/pio.o
> In file included from drivers/net/wireless/brcm80211/brcmfmac/bcmsdh.c:29:0:
> drivers/net/wireless/brcm80211/include/defs.h:23:0: warning: "PCI_BUS" redefined [enabled by default]
> include/uapi/linux/pci.h:36:0: note: this is the location of the previous definition
> In file included from drivers/net/wireless/brcm80211/brcmfmac/bcmsdh.c:29:0:
> drivers/net/wireless/brcm80211/include/defs.h:23:0: warning: "PCI_BUS" redefined [enabled by default]
> include/uapi/linux/pci.h:36:0: note: this is the location of the previous definition
Strange, I do not see PCI_BUS defined anywhere in the include/ branch in either
3.8 or 3.9. In addition, I don't get these warnings. What is different in your
system?
Larry
>
> Signed-off-by: Shuah Khan <shuah.khan@hp.com>
> ---
> drivers/net/wireless/brcm80211/include/defs.h | 1 -
> 1 file changed, 1 deletion(-)
>
> diff --git a/drivers/net/wireless/brcm80211/include/defs.h b/drivers/net/wireless/brcm80211/include/defs.h
> index fb7cbcf..3608436 100644
> --- a/drivers/net/wireless/brcm80211/include/defs.h
> +++ b/drivers/net/wireless/brcm80211/include/defs.h
> @@ -20,7 +20,6 @@
> #include <linux/types.h>
>
> #define SI_BUS 0
> -#define PCI_BUS 1
> #define PCMCIA_BUS 2
> #define SDIO_BUS 3
> #define JTAG_BUS 4
>
next prev parent reply other threads:[~2013-03-05 1:28 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-03-05 1:02 [PATCH] net/wireless/brcm80211: remove PCI_BUS define from defs.h to fix warnings Shuah Khan
2013-03-05 1:28 ` Larry Finger [this message]
2013-03-05 4:08 ` Shuah Khan
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=51354A28.3040607@lwfinger.net \
--to=larry.finger@lwfinger.net \
--cc=arend@broadcom.com \
--cc=brcm80211-dev-list@broadcom.com \
--cc=brudley@broadcom.com \
--cc=frankyl@broadcom.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-wireless@vger.kernel.org \
--cc=linville@tuxdriver.com \
--cc=netdev@vger.kernel.org \
--cc=pieterpg@broadcom.com \
--cc=seth.forshee@canonical.com \
--cc=shuah.khan@hp.com \
--cc=shuahkhan@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox