From: Larry Finger <Larry.Finger@lwfinger.net>
To: "Rafał Miłecki" <zajec5@gmail.com>
Cc: Joe Perches <joe@perches.com>, Hauke Mehrtens <hauke@hauke-m.de>,
linville@tuxdriver.com, linux-wireless@vger.kernel.org
Subject: Re: [PATCH] ssb: fix unaligned access to mac address
Date: Sun, 10 Mar 2013 12:35:26 -0500 [thread overview]
Message-ID: <513CC45E.7090402@lwfinger.net> (raw)
In-Reply-To: <CACna6rzNTfcuDOdpQrvbeWa4YhgDm_j6nkJ0OwbrLqCjh+qWJQ@mail.gmail.com>
On 03/10/2013 06:36 AM, Rafał Miłecki wrote:
>
> Feel free to fix. I've another 3 regressions to track...
Upon further investigation, the flipping of the MAC bytes was not due to "ssb:
pci: Standardize a function to get mac address", or "ssb: fix unaligned access
to mac address". For other reasons, I had to run 3.8 today and found the
flipping, even though neither patch was installed. Joe and Hauke are blameless -
they merely reproduced the existing bug. I have no real desire to find out when
that error was introduced as I am not an archeologist. Note that b43legacy does
not have the problem, thus it was introduced after the split of those two variants.
I will submit the fix.
Larry
next prev parent reply other threads:[~2013-03-10 17:35 UTC|newest]
Thread overview: 17+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-02-16 13:25 [PATCH] ssb: fix unaligned access to mac address Hauke Mehrtens
2013-02-18 10:10 ` Johannes Berg
2013-02-18 16:09 ` Rafał Miłecki
2013-02-20 17:31 ` Joe Perches
2013-02-20 17:56 ` Larry Finger
2013-02-20 18:29 ` Joe Perches
2013-02-20 19:17 ` Hauke Mehrtens
2013-02-20 20:11 ` Joe Perches
2013-02-21 3:34 ` Larry Finger
2013-03-09 23:02 ` Rafał Miłecki
2013-03-09 23:31 ` Larry Finger
2013-03-09 23:56 ` Larry Finger
2013-03-10 11:36 ` Rafał Miłecki
2013-03-10 17:35 ` Larry Finger [this message]
2013-03-10 20:57 ` Rafał Miłecki
2013-02-20 20:16 ` [PATCH 2/2] ssb: Convert ssb_printk to ssb_<level> Joe Perches
2013-02-20 19:07 ` [PATCH] ssb: fix unaligned access to mac address Joe Perches
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=513CC45E.7090402@lwfinger.net \
--to=larry.finger@lwfinger.net \
--cc=hauke@hauke-m.de \
--cc=joe@perches.com \
--cc=linux-wireless@vger.kernel.org \
--cc=linville@tuxdriver.com \
--cc=zajec5@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).