Re: [PATCH] ath9k: Allow over-riding reg-domain.

[Ben Greear <greearb@candelatech.com>]

On 03/11/2013 01:17 PM, Felix Fietkau wrote:
> On 2013-03-11 8:51 PM, Ben Greear wrote:
>> On 03/11/2013 12:05 PM, John W. Linville wrote:
>>> On Mon, Mar 11, 2013 at 09:45:06AM -0700, greearb@candelatech.com wrote:
>>>> From: Ben Greear <greearb@candelatech.com>
>>>>
>>>> Otherwise, can't get the Sparklan AR9380 NICs to be
>>>> 5Ghz APs, since they are in world-roaming domain by
>>>> default.  Add this to /etc/modprobe.d/ath9k.conf:
>>>>
>>>> options ath9k override_eeprom_regdomain=0
>>>>
>>>> Signed-off-by: Ben Greear <greearb@candelatech.com>
>>>
>>> Why "=0" to enable it?  Just to make it more confusing?
>>
>> You are just setting the country code...and country-code 0 seems
>> to at least open up the US regulatory domain so we use it
>> by default.
>>
>> You can use any country code you wish here.
> I'd like to have less fugly module parameter hackery please. How about
> either using CONFIG_CFG80211_CERTIFICATION_ONUS the way it was intended,
> or adding another config option that makes it bail out of
> ath_regd_init_wiphy() early, thus still processing the EEPROM regdomain
> hint and not making it binding.

I am not sure what you are suggesting.  I enabled this override
only when ONUS is selected because I wanted it clear that users
were taking their regulatory compliance into their own hands.

I always want the module option at least visible so that
you don't have to muck with modprobe.conf just to get ath9k.ko
to load when it's compiled differently.

For the second part, you want the ability to set the regdomain
be a compile-time option like CONFIG_ATH9K_OVERRIDE_REGDOMAIN
or something like that?

Thanks,
Ben

>
> - Felix
>


-- 
Ben Greear <greearb@candelatech.com>
Candela Technologies Inc  http://www.candelatech.com