* [PATCH] ssb: pci: Fix flipping of MAC address
@ 2013-03-11 20:38 Larry Finger
2013-03-13 18:18 ` John W. Linville
0 siblings, 1 reply; 3+ messages in thread
From: Larry Finger @ 2013-03-11 20:38 UTC (permalink / raw)
To: John W Linville; +Cc: b43-dev, netdev, linux-wireless, zajec5
Since commit e565275 entitled "ssb: pci: Standardize a function to get mac
address", the SPROM readout of the MAC has had the values flipped so that
00:11:22:33:44:55 became 11:00:33:22:55:44. The fix has been tested on both
little- and big-endian architectures.
Reported-by: Rafał Miłecki <zajec5@gmail.com>
Signed-off-by: Larry Finger <Larry.Finger@lwfinger.net>
---
John,
This bug was introduced in 3.9, and should be fixed there.
Thanks,
Larry
---
Index: wireless-testing-new/drivers/ssb/pci.c
===================================================================
--- wireless-testing-new.orig/drivers/ssb/pci.c
+++ wireless-testing-new/drivers/ssb/pci.c
@@ -234,8 +234,8 @@ static void sprom_get_mac(char *mac, con
{
int i;
for (i = 0; i < 3; i++) {
- *mac++ = in[i];
*mac++ = in[i] >> 8;
+ *mac++ = in[i];
}
}
^ permalink raw reply [flat|nested] 3+ messages in thread
* Re: [PATCH] ssb: pci: Fix flipping of MAC address
2013-03-11 20:38 [PATCH] ssb: pci: Fix flipping of MAC address Larry Finger
@ 2013-03-13 18:18 ` John W. Linville
2013-03-13 19:14 ` Larry Finger
0 siblings, 1 reply; 3+ messages in thread
From: John W. Linville @ 2013-03-13 18:18 UTC (permalink / raw)
To: Larry Finger; +Cc: b43-dev, netdev, linux-wireless, zajec5
On Mon, Mar 11, 2013 at 03:38:26PM -0500, Larry Finger wrote:
> Since commit e565275 entitled "ssb: pci: Standardize a function to get mac
> address", the SPROM readout of the MAC has had the values flipped so that
> 00:11:22:33:44:55 became 11:00:33:22:55:44. The fix has been tested on both
> little- and big-endian architectures.
>
> Reported-by: Rafał Miłecki <zajec5@gmail.com>
> Signed-off-by: Larry Finger <Larry.Finger@lwfinger.net>
> ---
>
> John,
>
> This bug was introduced in 3.9, and should be fixed there.
>
> Thanks,
>
> Larry
> ---
>
> Index: wireless-testing-new/drivers/ssb/pci.c
> ===================================================================
> --- wireless-testing-new.orig/drivers/ssb/pci.c
> +++ wireless-testing-new/drivers/ssb/pci.c
> @@ -234,8 +234,8 @@ static void sprom_get_mac(char *mac, con
> {
> int i;
> for (i = 0; i < 3; i++) {
> - *mac++ = in[i];
> *mac++ = in[i] >> 8;
> + *mac++ = in[i];
> }
> }
Actually, FWIW it seems to have been introduced in commit
e5652756ff36ed9e1283121f788e6a17117efcab, which is slated for 3.10.
I'm happy to merge it in wireless-next.
John
--
John W. Linville Someday the world will need a hero, and you
linville@tuxdriver.com might be all we have. Be ready.
^ permalink raw reply [flat|nested] 3+ messages in thread
* Re: [PATCH] ssb: pci: Fix flipping of MAC address
2013-03-13 18:18 ` John W. Linville
@ 2013-03-13 19:14 ` Larry Finger
0 siblings, 0 replies; 3+ messages in thread
From: Larry Finger @ 2013-03-13 19:14 UTC (permalink / raw)
To: John W. Linville; +Cc: b43-dev, netdev, linux-wireless, zajec5
On 03/13/2013 01:18 PM, John W. Linville wrote:
> On Mon, Mar 11, 2013 at 03:38:26PM -0500, Larry Finger wrote:
>> Since commit e565275 entitled "ssb: pci: Standardize a function to get mac
>> address", the SPROM readout of the MAC has had the values flipped so that
>> 00:11:22:33:44:55 became 11:00:33:22:55:44. The fix has been tested on both
>> little- and big-endian architectures.
>>
>> Reported-by: Rafał Miłecki <zajec5@gmail.com>
>> Signed-off-by: Larry Finger <Larry.Finger@lwfinger.net>
>> ---
>>
>> John,
>>
>> This bug was introduced in 3.9, and should be fixed there.
>>
>> Thanks,
>>
>> Larry
>> ---
>>
>> Index: wireless-testing-new/drivers/ssb/pci.c
>> ===================================================================
>> --- wireless-testing-new.orig/drivers/ssb/pci.c
>> +++ wireless-testing-new/drivers/ssb/pci.c
>> @@ -234,8 +234,8 @@ static void sprom_get_mac(char *mac, con
>> {
>> int i;
>> for (i = 0; i < 3; i++) {
>> - *mac++ = in[i];
>> *mac++ = in[i] >> 8;
>> + *mac++ = in[i];
>> }
>> }
>
> Actually, FWIW it seems to have been introduced in commit
> e5652756ff36ed9e1283121f788e6a17117efcab, which is slated for 3.10.
> I'm happy to merge it in wireless-next.
After further checking, I agree that it is not in 3.9. As long as the fix is
merged before 3.10, all will be OK.
Sorry for the confusion.
Larry
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2013-03-13 19:14 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2013-03-11 20:38 [PATCH] ssb: pci: Fix flipping of MAC address Larry Finger
2013-03-13 18:18 ` John W. Linville
2013-03-13 19:14 ` Larry Finger
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).