* [PATCH] mac80211: Don't restart sta-timer if not associated.
@ 2013-03-14 22:17 greearb
2013-03-14 23:00 ` Ben Greear
0 siblings, 1 reply; 2+ messages in thread
From: greearb @ 2013-03-14 22:17 UTC (permalink / raw)
To: linux-wireless; +Cc: Ben Greear
From: Ben Greear <greearb@candelatech.com>
I found another crash when deleting lots of virtual stations
in a congested environment. I think the problem is that
the ieee80211_mlme_notify_scan_completed could call
ieee80211_restart_sta_timer for a non-associated interface
that was about to be deleted.
With the following patch I am unable to reproduce the
crash.
Signed-off-by: Ben Greear <greearb@candelatech.com>
---
:100644 100644 81e0619... a1cc8c4... M net/mac80211/mlme.c
net/mac80211/mlme.c | 3 +++
1 files changed, 3 insertions(+), 0 deletions(-)
diff --git a/net/mac80211/mlme.c b/net/mac80211/mlme.c
index 81e0619..a1cc8c4 100644
--- a/net/mac80211/mlme.c
+++ b/net/mac80211/mlme.c
@@ -2931,6 +2931,9 @@ static void ieee80211_restart_sta_timer(struct ieee80211_sub_if_data *sdata)
u32 flags;
if (sdata->vif.type == NL80211_IFTYPE_STATION) {
+ if (unlikely(!sdata->u.mgd.associated))
+ return;
+
__ieee80211_stop_poll(sdata);
/* let's probe the connection once */
--
1.7.3.4
^ permalink raw reply related [flat|nested] 2+ messages in thread* Re: [PATCH] mac80211: Don't restart sta-timer if not associated.
2013-03-14 22:17 [PATCH] mac80211: Don't restart sta-timer if not associated greearb
@ 2013-03-14 23:00 ` Ben Greear
0 siblings, 0 replies; 2+ messages in thread
From: Ben Greear @ 2013-03-14 23:00 UTC (permalink / raw)
To: greearb; +Cc: linux-wireless
On 03/14/2013 03:17 PM, greearb@candelatech.com wrote:
> From: Ben Greear <greearb@candelatech.com>
>
> I found another crash when deleting lots of virtual stations
> in a congested environment. I think the problem is that
> the ieee80211_mlme_notify_scan_completed could call
> ieee80211_restart_sta_timer for a non-associated interface
> that was about to be deleted.
>
> With the following patch I am unable to reproduce the
> crash.
Nevermind..this seems to break association...will work on
this some more.
Ben
>
> Signed-off-by: Ben Greear <greearb@candelatech.com>
> ---
> :100644 100644 81e0619... a1cc8c4... M net/mac80211/mlme.c
> net/mac80211/mlme.c | 3 +++
> 1 files changed, 3 insertions(+), 0 deletions(-)
>
> diff --git a/net/mac80211/mlme.c b/net/mac80211/mlme.c
> index 81e0619..a1cc8c4 100644
> --- a/net/mac80211/mlme.c
> +++ b/net/mac80211/mlme.c
> @@ -2931,6 +2931,9 @@ static void ieee80211_restart_sta_timer(struct ieee80211_sub_if_data *sdata)
> u32 flags;
>
> if (sdata->vif.type == NL80211_IFTYPE_STATION) {
> + if (unlikely(!sdata->u.mgd.associated))
> + return;
> +
> __ieee80211_stop_poll(sdata);
>
> /* let's probe the connection once */
>
--
Ben Greear <greearb@candelatech.com>
Candela Technologies Inc http://www.candelatech.com
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2013-03-14 23:00 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2013-03-14 22:17 [PATCH] mac80211: Don't restart sta-timer if not associated greearb
2013-03-14 23:00 ` Ben Greear
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).