linux-wireless.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Felix Fietkau <nbd@openwrt.org>
To: Ben Greear <greearb@candelatech.com>
Cc: "linux-wireless@vger.kernel.org" <linux-wireless@vger.kernel.org>
Subject: Re: Optimizing performance for lots of virtual stations.
Date: Fri, 15 Mar 2013 00:12:35 +0100	[thread overview]
Message-ID: <51425963.2000904@openwrt.org> (raw)
In-Reply-To: <5142074C.1060708@candelatech.com>

On 2013-03-14 6:22 PM, Ben Greear wrote:
> I've been doing some performance testing, and having lots of
> stations causes quite a drag:  total throughput with 1 station: 250Mbps TCP throughput,
> total with 50 stations:  225 Mbps, and with 128 stations: 20-40Mbps (it varies a lot..not so sure why).
> 
> I poked around in the rx logic and it seems the rx-data path is fairly
> clean for data packets.  But, from what I can tell, each beacon is going
> to cause an skb_copy() call and a queued work-item for each station interface,
> and there are going to be lots of beacons per second in most scenarios...
> 
> I was wondering if this could be optimized a bit to special case beacons
> and not make a new copy (or possibly move some of the beacon handling
> logic up to the radio object and out of the sdata).
> 
> And of course, it could be there are more important optimizations...I'm curious
> if anyone is aware of any other code that should be optimized to have better
> performance with lots of stations...
How about doing some profiling with lots of stations - that should
hopefully reveal where the real bottleneck is.
By the way, with that many stations and low throughput, is the CPU usage
on your system significantly higher, or could it just be some extra
latency introduced somewhere else in the code?

- Felix


  reply	other threads:[~2013-03-14 23:12 UTC|newest]

Thread overview: 7+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2013-03-14 17:22 Optimizing performance for lots of virtual stations Ben Greear
2013-03-14 23:12 ` Felix Fietkau [this message]
2013-03-14 23:18   ` Ben Greear
2013-03-15  1:44     ` Felix Fietkau
2013-03-15  3:26       ` Ben Greear
2013-03-15 17:14         ` Ben Greear
2013-03-15 17:50           ` Ben Greear

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=51425963.2000904@openwrt.org \
    --to=nbd@openwrt.org \
    --cc=greearb@candelatech.com \
    --cc=linux-wireless@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).