linux-wireless.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Larry Finger <Larry.Finger@lwfinger.net>
To: Jussi Kivilinna <jussi.kivilinna@iki.fi>
Cc: linux-wireless@vger.kernel.org,
	Chaoming Li <chaoming_li@realsil.com.cn>,
	"John W. Linville" <linville@tuxdriver.com>
Subject: Re: [PATCH] rtlwifi: usb: add missing freeing of skbuff
Date: Sun, 17 Mar 2013 12:16:48 -0500	[thread overview]
Message-ID: <5145FA80.7040209@lwfinger.net> (raw)
In-Reply-To: <20130317095404.23346.42853.stgit@localhost6.localdomain6>

On 03/17/2013 04:54 AM, Jussi Kivilinna wrote:
> Signed-off-by: Jussi Kivilinna <jussi.kivilinna@iki.fi>
> ---
>   drivers/net/wireless/rtlwifi/usb.c |    1 +
>   1 file changed, 1 insertion(+)
>
> diff --git a/drivers/net/wireless/rtlwifi/usb.c b/drivers/net/wireless/rtlwifi/usb.c
> index b5c80b5..41dce83 100644
> --- a/drivers/net/wireless/rtlwifi/usb.c
> +++ b/drivers/net/wireless/rtlwifi/usb.c
> @@ -850,6 +850,7 @@ static void _rtl_usb_transmit(struct ieee80211_hw *hw, struct sk_buff *skb,
>   	if (unlikely(!_urb)) {
>   		RT_TRACE(rtlpriv, COMP_ERR, DBG_EMERG,
>   			 "Can't allocate urb. Drop skb!\n");
> +		kfree_skb(skb);
>   		return;
>   	}
>   	_rtl_submit_tx_urb(hw, _urb);
>

Acked-by: Larry Finger <Larry.Finger@lwfinger.net>

John - Add Stable as Cc.

Good catch. Thanks,

Larry



      reply	other threads:[~2013-03-17 17:16 UTC|newest]

Thread overview: 2+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2013-03-17  9:54 [PATCH] rtlwifi: usb: add missing freeing of skbuff Jussi Kivilinna
2013-03-17 17:16 ` Larry Finger [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=5145FA80.7040209@lwfinger.net \
    --to=larry.finger@lwfinger.net \
    --cc=chaoming_li@realsil.com.cn \
    --cc=jussi.kivilinna@iki.fi \
    --cc=linux-wireless@vger.kernel.org \
    --cc=linville@tuxdriver.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).