Re: [PATCH] rt2x00: make the driver build for Ralink SoC

[Gabor Juhos <juhosg@openwrt.org>]

2013.03.20. 22:29 keltezéssel, Gertjan van Wingerde írta:
> 
> 
> Sent from my iPad
> 
> On 20 mrt. 2013, at 20:48, John Crispin <blogic@openwrt.org> wrote:
> 
>> Fix up the dependencies to make the driver actually compile on Ralink WiSoC.
>>
>> Signed-off-by: John Crispin <blogic@openwrt.org>
> 
> I don't think this is a proper way to handle this. rt2x00pci.c was only
> meant to be used for PCI devices; introducing the use of CONFIG_PCI in that file
> doesn't seem appropriate to me.

Well, CONFIG_PCI is also used in rt2800pci.c. The root cause of the problem is
that rt2800pci (despite its name) is used to drive the built-in wireless MAC of
various SoCs. This is because handling of the PCI and of the SoC built-in
devices is quite similar. However regardless of the underlying bus type,
rt2800pci uses several functions exported from rt2x00pci so it should always
select RT2X00_LIB_PCI.

The rt2x00pci_{probe,remove,suspend,resume} handlers from rt2x00pci are not used
by rt2800pci if PCI disabled. However the presence of that functions in rt2x00
causes build error if the driver is compiled with disabled PCI support.

If we properly want to fix the issue, lots of functions should be renamed and
should be moved into separate modules. The name of these new modules could be
rt2x00mmio and rt2800mmio for example.

Adding CONFIG_PCI to rt2x00pci could be a temporary solution until that is not done.

-Gabor