From: Ben Greear <greearb@candelatech.com>
To: Johannes Berg <johannes@sipsolutions.net>
Cc: linux-wireless@vger.kernel.org
Subject: Re: [PATCH v3] mac80211: Optimize sta lookup for many VIFs
Date: Wed, 27 Mar 2013 11:35:09 -0700 [thread overview]
Message-ID: <51533BDD.9010700@candelatech.com> (raw)
In-Reply-To: <1364326932.8319.15.camel@jlt4.sipsolutions.net>
On 03/26/2013 12:42 PM, Johannes Berg wrote:
> On Mon, 2013-03-25 at 17:57 -0700, greearb@candelatech.com wrote:
>
>> v3: Use rcu_dereference_protected as suggested.
>
> Heh.
>
>> + some_sta = rcu_dereference_protected(sta->sdata->some_sta, 1);
>
> No no no, you're supposed to give it a proper argument like
> "lockdep_is_held(&local->sta_mtx)"
Before I screw this up again..do you prefer that I line up
method arguments and go over 80 character line length, or
force the argument leftward to meet the 80 char limit?
I see no good way to make it fit in 80 chars and also
line up properly.
Thanks,
Ben
>
> johannes
>
--
Ben Greear <greearb@candelatech.com>
Candela Technologies Inc http://www.candelatech.com
next prev parent reply other threads:[~2013-03-27 18:35 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-03-26 0:57 [PATCH v3] mac80211: Optimize sta lookup for many VIFs greearb
2013-03-26 19:42 ` Johannes Berg
2013-03-27 18:35 ` Ben Greear [this message]
2013-03-27 19:48 ` Johannes Berg
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=51533BDD.9010700@candelatech.com \
--to=greearb@candelatech.com \
--cc=johannes@sipsolutions.net \
--cc=linux-wireless@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).