From: "Piotr Haber" <phaber@broadcom.com>
To: "Joseph Salisbury" <joseph.salisbury@canonical.com>
Cc: "John W. Linville" <linville@tuxdriver.com>,
arend@broadcom.com, pieterpg@broadcom.com, meuleman@broadcom.com,
LKML <linux-kernel@vger.kernel.org>,
brudley@broadcom.com, frankyl@broadcom.com,
linux-wireless@vger.kernel.org, brcm80211-dev-list@broadcom.com,
netdev@vger.kernel.org
Subject: Re: [v3.8, v3.9] [Regression] brcmsmac: move PHY functions
Date: Tue, 2 Apr 2013 11:02:39 +0200 [thread overview]
Message-ID: <515A9EAF.4010005@broadcom.com> (raw)
In-Reply-To: <5159A559.4000808@canonical.com>
On 04/01/13 17:18, Joseph Salisbury wrote:
> On 04/01/2013 10:42 AM, John W. Linville wrote:
>> On Fri, Mar 29, 2013 at 03:52:39PM -0400, Joseph Salisbury wrote:
>>> Hi Piotr,
>>>
>>> A bug was opened against the Ubuntu kernel[0]. After a kernel
>>> bisect, it was found that reverting the following commit resolved
>>> this bug:
>>>
>>> commit b83576341664957978e125f5f5db2f15496980b1
>>> Author: Piotr Haber <phaber@broadcom.com>
>>> Date: Wed Nov 28 21:44:09 2012 +0100
>>>
>>> brcmsmac: move PHY functions
>>>
>>> The regression was introduced as of v3.8-rc1. The regression still
>>> exists in v3.9-rc4.
>>>
>>> I see that you are the author of this patch, so I wanted to run this
>>> by you. I was thinking of requesting a revert for v3.9, but I
>>> wanted to get your feedback first.
>>>
>>>
>>> Thanks,
>>>
>>> Joe
>>>
>>> [0] http://pad.lv/1131914
>> I recently reverted b6fc28a1, which is the follow-on to that patch.
>> The revert is _not_ in 3.9-rc5.
>>
>> Could you try reverting that patch instead? Does that fix the issue
>> for you?
>>
>> John
>
> Hi John,
>
> Thanks for the response.
>
> Yes, reverting commit b6fc28a1 does resolve this bug. That is the appropriate fix for this issue.
> Thanks for the assistance.
>
> Thanks,
>
> Joe
>
>
>
>
Hi Joe,
could you elaborate a little bit on your failure scenario?
In bug report you say it happens after suspend/resume, are there any other scenarios you see this
behaviour? (like disassociation/association without suspend)
Also you mention it comes back after some time - what is the time needed?
We had reports of problems on 4313 with this patch (that's why the revert was done) but so far i
assumed it was a total breakdown, in your case this seem like a transient issue.
One more thing, could you provide info about your hardware by sending me contents of:
<debugfs_mount>/brcmsmac/bcma0:0/hardware
Kind regards
Piotr
next prev parent reply other threads:[~2013-04-02 9:02 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-03-29 19:52 [v3.8, v3.9] [Regression] brcmsmac: move PHY functions Joseph Salisbury
2013-04-01 14:42 ` John W. Linville
2013-04-01 15:18 ` Joseph Salisbury
2013-04-02 9:02 ` Piotr Haber [this message]
2013-04-03 15:28 ` Joseph Salisbury
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=515A9EAF.4010005@broadcom.com \
--to=phaber@broadcom.com \
--cc=arend@broadcom.com \
--cc=brcm80211-dev-list@broadcom.com \
--cc=brudley@broadcom.com \
--cc=frankyl@broadcom.com \
--cc=joseph.salisbury@canonical.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-wireless@vger.kernel.org \
--cc=linville@tuxdriver.com \
--cc=meuleman@broadcom.com \
--cc=netdev@vger.kernel.org \
--cc=pieterpg@broadcom.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).