* [PATCH] ath9k: Re-enable interrupts after a channel change failure
@ 2013-04-01 14:22 Robert Shade
2013-04-01 16:25 ` Adrian Chadd
2013-04-01 17:40 ` Felix Fietkau
0 siblings, 2 replies; 6+ messages in thread
From: Robert Shade @ 2013-04-01 14:22 UTC (permalink / raw)
To: linux-wireless, ath9k-devel; +Cc: Adrian Chadd
Re-enable interrupts after a channel change failure, since
ath_complete_reset will not be called. Also schedule a reset as a
best effort method to recover the chip from whatever state caused the
channel change failure.
Signed-off-by: Robert Shade <robert.shade@gmail.com>
---
drivers/net/wireless/ath/ath9k/main.c | 6 ++++++
1 files changed, 6 insertions(+), 0 deletions(-)
diff --git a/drivers/net/wireless/ath/ath9k/main.c
b/drivers/net/wireless/ath/ath9k/main.c
index 24650fd..0567ac9 100644
--- a/drivers/net/wireless/ath/ath9k/main.c
+++ b/drivers/net/wireless/ath/ath9k/main.c
@@ -280,6 +280,12 @@ static int ath_reset_internal(struct ath_softc
*sc, struct ath9k_channel *hchan)
if (r) {
ath_err(common,
"Unable to reset channel, reset status %d\n", r);
+
+ ath9k_hw_set_interrupts(ah);
+ ath9k_hw_enable_interrupts(ah);
+
+ ath9k_queue_reset(sc, RESET_TYPE_BB_HANG);
+
goto out;
}
--
1.7.1
^ permalink raw reply related [flat|nested] 6+ messages in thread
* Re: [PATCH] ath9k: Re-enable interrupts after a channel change failure
2013-04-01 14:22 [PATCH] ath9k: Re-enable interrupts after a channel change failure Robert Shade
@ 2013-04-01 16:25 ` Adrian Chadd
2013-04-01 17:43 ` John W. Linville
2013-04-01 17:40 ` Felix Fietkau
1 sibling, 1 reply; 6+ messages in thread
From: Adrian Chadd @ 2013-04-01 16:25 UTC (permalink / raw)
To: Robert Shade; +Cc: linux-wireless, ath9k-devel
You filed a bug against this, right? Can you mention the bug report in there?
(What's the "blessed" way to mention a bugzilla.kernel.org bug in a
linux git commit?)
adrian
On 1 April 2013 07:22, Robert Shade <robert.shade@gmail.com> wrote:
> Re-enable interrupts after a channel change failure, since
> ath_complete_reset will not be called. Also schedule a reset as a
> best effort method to recover the chip from whatever state caused the
> channel change failure.
>
> Signed-off-by: Robert Shade <robert.shade@gmail.com>
> ---
> drivers/net/wireless/ath/ath9k/main.c | 6 ++++++
> 1 files changed, 6 insertions(+), 0 deletions(-)
>
> diff --git a/drivers/net/wireless/ath/ath9k/main.c
> b/drivers/net/wireless/ath/ath9k/main.c
> index 24650fd..0567ac9 100644
> --- a/drivers/net/wireless/ath/ath9k/main.c
> +++ b/drivers/net/wireless/ath/ath9k/main.c
> @@ -280,6 +280,12 @@ static int ath_reset_internal(struct ath_softc
> *sc, struct ath9k_channel *hchan)
> if (r) {
> ath_err(common,
> "Unable to reset channel, reset status %d\n", r);
> +
> + ath9k_hw_set_interrupts(ah);
> + ath9k_hw_enable_interrupts(ah);
> +
> + ath9k_queue_reset(sc, RESET_TYPE_BB_HANG);
> +
> goto out;
> }
>
> --
> 1.7.1
^ permalink raw reply [flat|nested] 6+ messages in thread
* Re: [PATCH] ath9k: Re-enable interrupts after a channel change failure
2013-04-01 14:22 [PATCH] ath9k: Re-enable interrupts after a channel change failure Robert Shade
2013-04-01 16:25 ` Adrian Chadd
@ 2013-04-01 17:40 ` Felix Fietkau
2013-04-02 12:03 ` Robert Shade
1 sibling, 1 reply; 6+ messages in thread
From: Felix Fietkau @ 2013-04-01 17:40 UTC (permalink / raw)
To: Robert Shade; +Cc: linux-wireless, ath9k-devel, Adrian Chadd
On 2013-04-01 4:22 PM, Robert Shade wrote:
> Re-enable interrupts after a channel change failure, since
> ath_complete_reset will not be called. Also schedule a reset as a
> best effort method to recover the chip from whatever state caused the
> channel change failure.
>
> Signed-off-by: Robert Shade <robert.shade@gmail.com>
Your patch is badly whitespace damaged.
> ---
> drivers/net/wireless/ath/ath9k/main.c | 6 ++++++
> 1 files changed, 6 insertions(+), 0 deletions(-)
>
> diff --git a/drivers/net/wireless/ath/ath9k/main.c
> b/drivers/net/wireless/ath/ath9k/main.c
> index 24650fd..0567ac9 100644
> --- a/drivers/net/wireless/ath/ath9k/main.c
> +++ b/drivers/net/wireless/ath/ath9k/main.c
> @@ -280,6 +280,12 @@ static int ath_reset_internal(struct ath_softc
> *sc, struct ath9k_channel *hchan)
> if (r) {
> ath_err(common,
> "Unable to reset channel, reset status %d\n", r);
> +
> + ath9k_hw_set_interrupts(ah);
Why the call to ath9k_hw_set_interrupts here?
> + ath9k_hw_enable_interrupts(ah);
> +
> + ath9k_queue_reset(sc, RESET_TYPE_BB_HANG);
> +
> goto out;
> }
^ permalink raw reply [flat|nested] 6+ messages in thread
* Re: [PATCH] ath9k: Re-enable interrupts after a channel change failure
2013-04-01 16:25 ` Adrian Chadd
@ 2013-04-01 17:43 ` John W. Linville
0 siblings, 0 replies; 6+ messages in thread
From: John W. Linville @ 2013-04-01 17:43 UTC (permalink / raw)
To: Adrian Chadd; +Cc: Robert Shade, linux-wireless, ath9k-devel
On Mon, Apr 01, 2013 at 09:25:43AM -0700, Adrian Chadd wrote:
> You filed a bug against this, right? Can you mention the bug report in there?
>
> (What's the "blessed" way to mention a bugzilla.kernel.org bug in a
> linux git commit?)
I usually just include the URL. "Fixes Bug #12345" would suffice as well.
--
John W. Linville Someday the world will need a hero, and you
linville@tuxdriver.com might be all we have. Be ready.
^ permalink raw reply [flat|nested] 6+ messages in thread
* Re: [PATCH] ath9k: Re-enable interrupts after a channel change failure
2013-04-01 17:40 ` Felix Fietkau
@ 2013-04-02 12:03 ` Robert Shade
2013-04-02 12:24 ` Felix Fietkau
0 siblings, 1 reply; 6+ messages in thread
From: Robert Shade @ 2013-04-02 12:03 UTC (permalink / raw)
To: Felix Fietkau; +Cc: linux-wireless, ath9k-devel, Adrian Chadd
On Mon, Apr 1, 2013 at 1:40 PM, Felix Fietkau <nbd@openwrt.org> wrote:
> Your patch is badly whitespace damaged.
Ouch, must be the gmail web client. I'll resubmit a fixed one.
> Why the call to ath9k_hw_set_interrupts here?
Simply because that's what ath_complete_reset does
^ permalink raw reply [flat|nested] 6+ messages in thread
* Re: [PATCH] ath9k: Re-enable interrupts after a channel change failure
2013-04-02 12:03 ` Robert Shade
@ 2013-04-02 12:24 ` Felix Fietkau
0 siblings, 0 replies; 6+ messages in thread
From: Felix Fietkau @ 2013-04-02 12:24 UTC (permalink / raw)
To: Robert Shade; +Cc: linux-wireless, ath9k-devel, Adrian Chadd
On 2013-04-02 2:03 PM, Robert Shade wrote:
> On Mon, Apr 1, 2013 at 1:40 PM, Felix Fietkau <nbd@openwrt.org> wrote:
>> Your patch is badly whitespace damaged.
>
> Ouch, must be the gmail web client. I'll resubmit a fixed one.
>
>> Why the call to ath9k_hw_set_interrupts here?
>
> Simply because that's what ath_complete_reset does
OK. You can leave it out, because it's not required for
interrupt-disable refcounting, and it will be called again after a
successful reset.
- Felix
^ permalink raw reply [flat|nested] 6+ messages in thread
end of thread, other threads:[~2013-04-02 12:24 UTC | newest]
Thread overview: 6+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2013-04-01 14:22 [PATCH] ath9k: Re-enable interrupts after a channel change failure Robert Shade
2013-04-01 16:25 ` Adrian Chadd
2013-04-01 17:43 ` John W. Linville
2013-04-01 17:40 ` Felix Fietkau
2013-04-02 12:03 ` Robert Shade
2013-04-02 12:24 ` Felix Fietkau
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).