From: "Arend van Spriel" <arend@broadcom.com>
To: "Johannes Berg" <johannes@sipsolutions.net>
Cc: "John W. Linville" <linville@tuxdriver.com>,
linux-wireless <linux-wireless@vger.kernel.org>
Subject: Re: [PATCH for-3.9] brcmsmac: request firmware in .start() callback
Date: Wed, 3 Apr 2013 11:27:09 +0200 [thread overview]
Message-ID: <515BF5ED.1090100@broadcom.com> (raw)
In-Reply-To: <1364979327.8351.7.camel@jlt4.sipsolutions.net>
On 04/03/2013 10:55 AM, Johannes Berg wrote:
> On Wed, 2013-04-03 at 10:41 +0200, Arend van Spriel wrote:
>> The firmware is requested from user-space. To assure the request
>> can be handled it is recommended to do the request upon IFF_UP.
>> For a mac80211 driver the .start() callback can be considered
>> the equivalent.
>
> FWIW, many drivers now don't do it on IFF_UP/start any more but do
> request_firmware_nowait() in probe and only finish probing and
> registering with mac80211 when they have the firmware file. This is
> necessary if you have any device/driver capabilities that depend on the
> firmware that need to be known before registering with mac80211.
Thanks, Johannes
I do recall looking into async firmware request API a while ago. Right
now we do not need it for brcmsmac, but we may need to move to that when
support for more devices comes in.
Gr. AvS
next prev parent reply other threads:[~2013-04-03 9:27 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-04-03 8:41 [PATCH for-3.9] brcmsmac: request firmware in .start() callback Arend van Spriel
2013-04-03 8:55 ` Johannes Berg
2013-04-03 9:27 ` Arend van Spriel [this message]
2013-04-03 18:49 ` John W. Linville
2013-04-04 9:36 ` Arend van Spriel
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=515BF5ED.1090100@broadcom.com \
--to=arend@broadcom.com \
--cc=johannes@sipsolutions.net \
--cc=linux-wireless@vger.kernel.org \
--cc=linville@tuxdriver.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).