From: Larry Finger <Larry.Finger@lwfinger.net>
To: David Howells <dhowells@redhat.com>
Cc: seanm@seanm.ca, gregkh@suse.de, viro@ZenIV.linux.org.uk,
awong1@novell.com, linux-wireless@vger.kernel.org
Subject: Re: The rtl8192e procfs-based debug interface seems very broken
Date: Mon, 08 Apr 2013 17:31:44 -0500 [thread overview]
Message-ID: <51634550.3090300@lwfinger.net> (raw)
In-Reply-To: <17570.1365415364@warthog.procyon.org.uk>
On 04/08/2013 05:02 AM, David Howells wrote:
> The procfs-based debug interface in:
>
> drivers/staging/rtl8192e/rtl8192e/rtl_debug.c
>
> seems to be very broken because:
>
> (1) proc_get_stats_ap() walks ieee->network_list with no locking.
>
> (2) There is no locking against normal driver operations whilst we wangle the
> device registers. Admittedly, this may not modify the device state since
> all the pages appear memory-mapped rather than bank-swapped - but if
> there are any read-to-ack type regs, then this is bad.
>
> (3) We send the device commands and await replies - again without locking
> against the normal driver (eg. proc_get_cam_register_*()).
David,
That whole driver is quite broken.
My initial response would be to delete the whole procfs structure. I have one of
those devices, but I never use it. At the moment, I do not have time to add
locking and test the changes.
Larry
next prev parent reply other threads:[~2013-04-08 22:31 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-04-08 10:02 The rtl8192e procfs-based debug interface seems very broken David Howells
2013-04-08 22:31 ` Larry Finger [this message]
2013-04-08 22:46 ` Sean MacLennan
2013-04-08 22:59 ` Larry Finger
2013-04-09 1:18 ` Sean MacLennan
2013-04-09 1:28 ` Al Viro
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=51634550.3090300@lwfinger.net \
--to=larry.finger@lwfinger.net \
--cc=awong1@novell.com \
--cc=dhowells@redhat.com \
--cc=gregkh@suse.de \
--cc=linux-wireless@vger.kernel.org \
--cc=seanm@seanm.ca \
--cc=viro@ZenIV.linux.org.uk \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).