linux-wireless.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
* The rtl8192e procfs-based debug interface seems very broken
@ 2013-04-08 10:02 David Howells
  2013-04-08 22:31 ` Larry Finger
  0 siblings, 1 reply; 6+ messages in thread
From: David Howells @ 2013-04-08 10:02 UTC (permalink / raw)
  To: seanm, gregkh, viro; +Cc: dhowells, awong1, linux-wireless


The procfs-based debug interface in:

	drivers/staging/rtl8192e/rtl8192e/rtl_debug.c

seems to be very broken because:

 (1) proc_get_stats_ap() walks ieee->network_list with no locking.

 (2) There is no locking against normal driver operations whilst we wangle the
     device registers.  Admittedly, this may not modify the device state since
     all the pages appear memory-mapped rather than bank-swapped - but if
     there are any read-to-ack type regs, then this is bad.

 (3) We send the device commands and await replies - again without locking
     against the normal driver (eg. proc_get_cam_register_*()).

David

^ permalink raw reply	[flat|nested] 6+ messages in thread

end of thread, other threads:[~2013-04-09  1:28 UTC | newest]

Thread overview: 6+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2013-04-08 10:02 The rtl8192e procfs-based debug interface seems very broken David Howells
2013-04-08 22:31 ` Larry Finger
2013-04-08 22:46   ` Sean MacLennan
2013-04-08 22:59     ` Larry Finger
2013-04-09  1:18       ` Sean MacLennan
2013-04-09  1:28         ` Al Viro

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).