From: Ping-Ke Shih <pkshih@realtek.com>
To: Chelsy Ratnawat <chelsyratnawat2001@gmail.com>, <pkshih@realtek.com>
Cc: <colin.i.king@gmail.com>, <johannes.berg@intel.com>,
<bhelgaas@google.com>, <arnd@arndb.de>,
<linux-wireless@vger.kernel.org>,
Chelsy Ratnawat <chelsyratnawat2001@gmail.com>
Subject: Re: [PATCH v2] rtlwifi: rtl8821ae: Remove dead code in rtl8821ae_update_hal_rate_table()
Date: Wed, 29 Apr 2026 10:55:08 +0800 [thread overview]
Message-ID: <5164841d-9ba8-43fa-bb4e-36608118cabe@RTKEXHMBS03.realtek.com.tw> (raw)
In-Reply-To: <20260407123427.14612-1-chelsyratnawat2001@gmail.com>
Chelsy Ratnawat <chelsyratnawat2001@gmail.com> wrote:
> The variable 'mimo_ps' is initialized to IEEE80211_SMPS_OFF and never
> modified throughout the function. This makes the condition checking for
> IEEE80211_SMPS_STATIC always evaluate to false, rendering the entire
> if-branch unreachable dead code.
>
> The error was reported by Coverity Scan.
>
> Signed-off-by: Chelsy Ratnawat <chelsyratnawat2001@gmail.com>
> Acked-by: Ping-Ke Shih <pkshih@realtek.com>
1 patch(es) applied to rtw-next branch of rtw.git, thanks.
d603f2cfa623 wifi: rtlwifi: rtl8821ae: Remove dead code in rtl8821ae_update_hal_rate_table()
---
https://github.com/pkshih/rtw.git
prev parent reply other threads:[~2026-04-29 2:55 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-04-07 12:34 [PATCH v2] rtlwifi: rtl8821ae: Remove dead code in rtl8821ae_update_hal_rate_table() Chelsy Ratnawat
2026-04-08 1:47 ` Ping-Ke Shih
2026-04-29 2:55 ` Ping-Ke Shih [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=5164841d-9ba8-43fa-bb4e-36608118cabe@RTKEXHMBS03.realtek.com.tw \
--to=pkshih@realtek.com \
--cc=arnd@arndb.de \
--cc=bhelgaas@google.com \
--cc=chelsyratnawat2001@gmail.com \
--cc=colin.i.king@gmail.com \
--cc=johannes.berg@intel.com \
--cc=linux-wireless@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox