Re: [Patch] mac80211: SMPS for AP Mode

[Vivekananda Holla <vivekanandah@posedge.com>]

hi Johannes,

do you mean the IEEE80211_TX_RC_USE_RTS_CTS flag to set RTS/CTS protection for the packet?

I did not use this based on the below understanding

my understanding for SMPS is that a station system does not need to send an RTS packet before frame transmission for SMPS however an AP system needs to send out an RTS frame.

hence, I defined a new txinfo flag which tells the lower driver (if AP) to send RTS frame if the station for which the packet is scheduled is dynamic SMPS to set the RTS frame for the same.

awaiting your feedback

thanks and regards
Vivek



On 04/10/2013 02:25 PM, Johannes Berg wrote:
> On Wed, 2013-04-10 at 14:24 +0530, Vivekananda Holla wrote:
>> Patch for SMPS mode for AP. This is to define a new ieee80211_tx_info flag to allow a lower AP driver to set RTS/CTS protection for a dynamic SMPS station
>>
>> Signed-off-by: Vivekananda Holla <vivekanandah@posedge.com>
>> ---
>>  include/net/mac80211.h             |    4 ++++
>>  net/mac80211/rc80211_minstrel_ht.c |    3 +++
>>  2 files changed, 7 insertions(+), 0 deletions(-)
>>
>> diff --git a/include/net/mac80211.h b/include/net/mac80211.h
>> index 64faf01..48a950c 100644
>> --- a/include/net/mac80211.h
>> +++ b/include/net/mac80211.h
>> @@ -458,6 +458,9 @@ struct ieee80211_bss_conf {
>>   * @IEEE80211_TX_CTL_DONTFRAG: Don't fragment this packet even if it
>>   *    would be fragmented by size (this is optional, only used for
>>   *    monitor injection).
>> + * @IEEE80211_TX_CTL_SMPS_SET_RTS: set the RTS/CTS protection mechanism
>> + *    for the packet at AP when SMPS mode at the station is 
>> + *    dynamic SMPS.
> Huh? No ... There are perfectly usable flags already inside each rate.
>
> johannes
>