From: Hauke Mehrtens <hauke@hauke-m.de>
To: Arend van Spriel <arend@broadcom.com>
Cc: "John W. Linville" <linville@tuxdriver.com>,
linux-wireless <linux-wireless@vger.kernel.org>,
Hante Meuleman <meuleman@broadcom.com>
Subject: Re: [PATCH 11/15] brcmfmac: define and use platform specific data for SDIO.
Date: Fri, 12 Apr 2013 01:15:22 +0200 [thread overview]
Message-ID: <5167440A.3040205@hauke-m.de> (raw)
In-Reply-To: <5166B608.8030803@broadcom.com>
On 04/11/2013 03:09 PM, Arend van Spriel wrote:
> On 04/11/2013 02:06 PM, Hauke Mehrtens wrote:
>> On 04/11/2013 01:28 PM, Arend van Spriel wrote:
>>> From: Hante Meuleman <meuleman@broadcom.com>
>>>
>>> This patch adds support for platform specific data for SDIO
>>> fullmac devices. Currently OOB interrupts are configured by Kconfig
>>> BRCMFMAC_SDIO_OOB but that is now determined dynamically by checking
>>> availibility of platform data.
>>>
>>> Reviewed-by: Arend Van Spriel <arend@broadcom.com>
>>> Reviewed-by: Franky (Zhenhui) Lin <frankyl@broadcom.com>
>>> Reviewed-by: Pieter-Paul Giesberts <pieterpg@broadcom.com>
>>> Reviewed-by: Piotr Haber <phaber@broadcom.com>
>>> Signed-off-by: Hante Meuleman <meuleman@broadcom.com>
>>> Signed-off-by: Arend van Spriel <arend@broadcom.com>
>>> ---
>>> drivers/net/wireless/brcm80211/Kconfig | 9 --
>>> drivers/net/wireless/brcm80211/brcmfmac/bcmsdh.c | 155
>>> ++++++++++----------
>>> .../net/wireless/brcm80211/brcmfmac/bcmsdh_sdmmc.c | 114
>>> ++++----------
>>> drivers/net/wireless/brcm80211/brcmfmac/dhd_sdio.c | 29 ++--
>>> .../net/wireless/brcm80211/brcmfmac/sdio_host.h | 6 +-
>>> include/linux/brcmfmac_platform.h | 125
>>> ++++++++++++++++
>>> 6 files changed, 251 insertions(+), 187 deletions(-)
>>> create mode 100644 include/linux/brcmfmac_platform.h
>>>
>>
>> ....
>>
>>> --- /dev/null
>>> +++ b/include/linux/brcmfmac_platform.h
>>
>> This should be placed into include/linux/platform_data/
>>
>
> Are you sure. This file specifies the platform data API so it does not
> contain actual platform_data. At first glance this folder seems to
> contain board specific platform data, but did not look closely.
I think, all the files in include/linux/platform_data/*.h are defining
some struct used in pdev->dev.platform_data in various drivers. The
content of such structs is mostly located in the arch code where the SoC
gets initialized, but I am not sure about this.
Hauke
next prev parent reply other threads:[~2013-04-11 23:16 UTC|newest]
Thread overview: 23+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-04-11 11:28 [PATCH 00/15] brcmfmac: new device support and fixes Arend van Spriel
2013-04-11 11:28 ` [PATCH 01/15] brcmfmac: support save&restore firmware feature Arend van Spriel
2013-04-11 11:28 ` [PATCH 02/15] brcmfmac: aggregate dongle ram access interface Arend van Spriel
2013-04-11 11:28 ` [PATCH 03/15] brcmfmac: move chip download state code to sdio_chip.c Arend van Spriel
2013-04-11 11:28 ` [PATCH 04/15] brcmutil: add new d11 interface support Arend van Spriel
2013-04-11 11:28 ` [PATCH 05/15] brcmfmac: adopt new d11 interface Arend van Spriel
2013-04-11 11:28 ` [PATCH 06/15] brcmfmac: add support for dongle ARM CR4 core Arend van Spriel
2013-04-11 11:28 ` [PATCH 07/15] brcmfmac: setup SDIO reset behavior Arend van Spriel
2013-04-11 11:28 ` [PATCH 08/15] brcmfmac: add BCM4335 sdio interface support Arend van Spriel
2013-04-11 11:28 ` [PATCH 09/15] brcmfmac: Add 43143 SDIO support Arend van Spriel
2013-04-11 11:28 ` [PATCH 10/15] brcmfmac: Add drive strength programming for SDIO 43143 Arend van Spriel
2013-04-11 11:28 ` [PATCH 11/15] brcmfmac: define and use platform specific data for SDIO Arend van Spriel
2013-04-11 12:06 ` Hauke Mehrtens
2013-04-11 13:09 ` Arend van Spriel
2013-04-11 23:15 ` Hauke Mehrtens [this message]
2013-04-12 7:44 ` Arend van Spriel
2013-04-12 8:55 ` [PATCH V2 " Arend van Spriel
2013-04-11 11:28 ` [PATCH 12/15] brcmfmac: obtain iftype for firmware-signal descriptor lookup Arend van Spriel
2013-04-11 15:08 ` [PATCH V2 " Arend van Spriel
2013-04-11 11:28 ` [PATCH 13/15] brcmfmac: pass ifp pointer in brcmf_fws_find_mac_desc() Arend van Spriel
2013-04-11 11:28 ` [PATCH 14/15] brcmfmac: rename brcmf_fws_mac_desc_ready() Arend van Spriel
2013-04-11 15:12 ` [PATCH V2 " Arend van Spriel
2013-04-11 11:29 ` [PATCH 15/15] brcmfmac: remove ifidx variable from brcmf_fws_process_skb() Arend van Spriel
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=5167440A.3040205@hauke-m.de \
--to=hauke@hauke-m.de \
--cc=arend@broadcom.com \
--cc=linux-wireless@vger.kernel.org \
--cc=linville@tuxdriver.com \
--cc=meuleman@broadcom.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).