Linux wireless drivers development
 help / color / mirror / Atom feed
From: Troy Kisky <troy.kisky@boundarydevices.com>
To: Bing Zhao <bzhao@marvell.com>
Cc: linux-wireless@vger.kernel.org,
	"John W. Linville" <linville@tuxdriver.com>,
	Doug Anderson <dianders@chromium.org>,
	Paul Stewart <pstew@chromium.org>,
	Yogesh Powar <yogeshp@marvell.com>,
	Avinash Patil <patila@marvell.com>,
	Amitkumar Karwar <akarwar@marvell.com>,
	Nishant Sarmukadam <nishants@marvell.com>,
	Frank Huang <frankh@marvell.com>
Subject: Re: [PATCH 2/2] mwifiex: remove redundant initialization for bss_descriptor
Date: Thu, 11 Apr 2013 18:01:49 -0700	[thread overview]
Message-ID: <51675CFD.8030603@boundarydevices.com> (raw)
In-Reply-To: <1365727993-20941-2-git-send-email-bzhao@marvell.com>

On 4/11/2013 5:53 PM, Bing Zhao wrote:
> Initialization of bss_descriptor is unnecessary as the entire
> structure will be overwritten by a memcpy.
>
> Reported-by: Doug Anderson <dianders@chromium.org>
> Reviewed-by: Doug Anderson <dianders@chromium.org>
> Reviewed-by: Paul Stewart <pstew@chromium.org>
> Signed-off-by: Bing Zhao <bzhao@marvell.com>
> Signed-off-by: Yogesh Ashok Powar <yogeshp@marvell.com>
> ---
>   drivers/net/wireless/mwifiex/scan.c |   29 -----------------------------
>   1 files changed, 0 insertions(+), 29 deletions(-)
>
> diff --git a/drivers/net/wireless/mwifiex/scan.c b/drivers/net/wireless/mwifiex/scan.c
> index 37b24e8..9cf5d8f 100644
> --- a/drivers/net/wireless/mwifiex/scan.c
> +++ b/drivers/net/wireless/mwifiex/scan.c
> @@ -1500,36 +1500,7 @@ static int mwifiex_update_curr_bss_params(struct mwifiex_private *priv,
>   	if (ret)
>   		goto done;
>   
> -	/* Update current bss descriptor parameters */
>   	spin_lock_irqsave(&priv->curr_bcn_buf_lock, flags);
> -	priv->curr_bss_params.bss_descriptor.bcn_wpa_ie = NULL;
> -	priv->curr_bss_params.bss_descriptor.wpa_offset = 0;
> -	priv->curr_bss_params.bss_descriptor.bcn_rsn_ie = NULL;
> -	priv->curr_bss_params.bss_descriptor.rsn_offset = 0;
> -	priv->curr_bss_params.bss_descriptor.bcn_wapi_ie = NULL;
> -	priv->curr_bss_params.bss_descriptor.wapi_offset = 0;
> -	priv->curr_bss_params.bss_descriptor.bcn_ht_cap = NULL;
> -	priv->curr_bss_params.bss_descriptor.ht_cap_offset = 0;
> -	priv->curr_bss_params.bss_descriptor.bcn_ht_oper = NULL;
> -	priv->curr_bss_params.bss_descriptor.ht_info_offset = 0;
> -	priv->curr_bss_params.bss_descriptor.bcn_bss_co_2040 = NULL;
> -	priv->curr_bss_params.bss_descriptor.bss_co_2040_offset = 0;
> -	priv->curr_bss_params.bss_descriptor.bcn_ext_cap = NULL;
> -	priv->curr_bss_params.bss_descriptor.ext_cap_offset = 0;
> -	priv->curr_bss_params.bss_descriptor.beacon_buf = NULL;
> -	priv->curr_bss_params.bss_descriptor.beacon_buf_size = 0;
> -	priv->curr_bss_params.bss_descriptor.bcn_vht_cap = NULL;
> -	priv->curr_bss_params.bss_descriptor.vht_cap_offset = 0;
> -	priv->curr_bss_params.bss_descriptor.bcn_vht_oper = NULL;
> -	priv->curr_bss_params.bss_descriptor.vht_info_offset = 0;
> -	priv->curr_bss_params.bss_descriptor.oper_mode = NULL;
> -	priv->curr_bss_params.bss_descriptor.oper_mode_offset = 0;
> -
> -	/* Disable 11ac by default. Enable it only where there
> -	 * exist VHT_CAP IE in AP beacon
> -	 */
> -	priv->curr_bss_params.bss_descriptor.disable_11ac = true;
> -

Should the = true line be moved below the memcpy?  Your way produces
the same behavior, but was it buggy before?
>   	/* Make a copy of current BSSID descriptor */
>   	memcpy(&priv->curr_bss_params.bss_descriptor, bss_desc,
>   	       sizeof(priv->curr_bss_params.bss_descriptor));


  reply	other threads:[~2013-04-12  1:01 UTC|newest]

Thread overview: 4+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2013-04-12  0:53 [PATCH 1/2] mwifiex: fix use-after-free in beacon_ie processing Bing Zhao
2013-04-12  0:53 ` [PATCH 2/2] mwifiex: remove redundant initialization for bss_descriptor Bing Zhao
2013-04-12  1:01   ` Troy Kisky [this message]
2013-04-12  1:45     ` Bing Zhao

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=51675CFD.8030603@boundarydevices.com \
    --to=troy.kisky@boundarydevices.com \
    --cc=akarwar@marvell.com \
    --cc=bzhao@marvell.com \
    --cc=dianders@chromium.org \
    --cc=frankh@marvell.com \
    --cc=linux-wireless@vger.kernel.org \
    --cc=linville@tuxdriver.com \
    --cc=nishants@marvell.com \
    --cc=patila@marvell.com \
    --cc=pstew@chromium.org \
    --cc=yogeshp@marvell.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox