Re: [PATCH 11/15] brcmfmac: define and use platform specific data for SDIO.

["Arend van Spriel" <arend@broadcom.com>]

On 04/12/2013 01:15 AM, Hauke Mehrtens wrote:
> On 04/11/2013 03:09 PM, Arend van Spriel wrote:
>> On 04/11/2013 02:06 PM, Hauke Mehrtens wrote:
>>> On 04/11/2013 01:28 PM, Arend van Spriel wrote:
>>>> From: Hante Meuleman <meuleman@broadcom.com>
>>>>
>>>> This patch adds support for platform specific data for SDIO
>>>> fullmac devices. Currently OOB interrupts are configured by Kconfig
>>>> BRCMFMAC_SDIO_OOB but that is now determined dynamically by checking
>>>> availibility of platform data.
>>>>
>>>> Reviewed-by: Arend Van Spriel <arend@broadcom.com>
>>>> Reviewed-by: Franky (Zhenhui) Lin <frankyl@broadcom.com>
>>>> Reviewed-by: Pieter-Paul Giesberts <pieterpg@broadcom.com>
>>>> Reviewed-by: Piotr Haber <phaber@broadcom.com>
>>>> Signed-off-by: Hante Meuleman <meuleman@broadcom.com>
>>>> Signed-off-by: Arend van Spriel <arend@broadcom.com>
>>>> ---
>>>>    drivers/net/wireless/brcm80211/Kconfig             |    9 --
>>>>    drivers/net/wireless/brcm80211/brcmfmac/bcmsdh.c   |  155
>>>> ++++++++++----------
>>>>    .../net/wireless/brcm80211/brcmfmac/bcmsdh_sdmmc.c |  114
>>>> ++++----------
>>>>    drivers/net/wireless/brcm80211/brcmfmac/dhd_sdio.c |   29 ++--
>>>>    .../net/wireless/brcm80211/brcmfmac/sdio_host.h    |    6 +-
>>>>    include/linux/brcmfmac_platform.h                  |  125
>>>> ++++++++++++++++
>>>>    6 files changed, 251 insertions(+), 187 deletions(-)
>>>>    create mode 100644 include/linux/brcmfmac_platform.h
>>>>
>>>
>>> ....
>>>
>>>> --- /dev/null
>>>> +++ b/include/linux/brcmfmac_platform.h
>>>
>>> This should be placed into include/linux/platform_data/
>>>
>>
>> Are you sure. This file specifies the platform data API so it does not
>> contain actual platform_data. At first glance this folder seems to
>> contain board specific platform data, but did not look closely.
>
> I think, all the files in include/linux/platform_data/*.h are defining
> some struct used in pdev->dev.platform_data in various drivers. The
> content of such structs is mostly located in the arch code where the SoC
> gets initialized, but I am not sure about this.

Hi Hauke,

I did some more digging in there and I think you are right. I will send 
a replacement patch to John.

Thanks & Regards,
Arend