From: Felix Fietkau <nbd@openwrt.org>
To: Johannes Berg <johannes@sipsolutions.net>
Cc: linux-wireless@vger.kernel.org
Subject: Re: [PATCH 3/5] mac80211: improve the rate control API
Date: Mon, 15 Apr 2013 16:27:12 +0200 [thread overview]
Message-ID: <516C0E40.3020502@openwrt.org> (raw)
In-Reply-To: <1366033473.8361.26.camel@jlt4.sipsolutions.net>
On 2013-04-15 3:44 PM, Johannes Berg wrote:
> On Sun, 2013-04-14 at 00:03 +0200, Felix Fietkau wrote:
>
>> +EXPORT_SYMBOL(rate_control_set_rates);
>
> I don't think that needs to be exported (at least not now)?
Just thought I'd let driver-implemented rate control modules access it
as well if they want to.
> I suspect that the answer to my question in patch 2 lies here, if the
> rate control updates the table then would it not just update the table
> when the protection mechanism needs to be changed? There should be
> triggers for that, rather than having to check the "use_cts" variables
> on every packet, and if they aren't complete that should be fixed?
I guess we could do some further work on that, but for now I wanted to
keep things simple by having only the rate control module touch the
table (and not have it care about CTS protection).
- Felix
next prev parent reply other threads:[~2013-04-15 14:27 UTC|newest]
Thread overview: 13+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-04-13 22:03 [PATCH 1/5] mac80211: fix and optimize MCS mask handling Felix Fietkau
2013-04-13 22:03 ` [PATCH 2/5] mac80211: fix CTS protection handling Felix Fietkau
2013-04-13 22:03 ` [PATCH 3/5] mac80211: improve the rate control API Felix Fietkau
2013-04-13 22:03 ` [PATCH 4/5] mac80211/minstrel_ht: use the new " Felix Fietkau
2013-04-13 22:03 ` [PATCH 5/5] mac80211/minstrel: " Felix Fietkau
2013-04-15 13:44 ` [PATCH 3/5] mac80211: improve the " Johannes Berg
2013-04-15 14:27 ` Felix Fietkau [this message]
2013-04-16 10:03 ` Karl Beldan
2013-04-16 10:44 ` Felix Fietkau
2013-04-15 13:40 ` [PATCH 2/5] mac80211: fix CTS protection handling Johannes Berg
2013-04-15 14:24 ` Felix Fietkau
2013-04-15 13:38 ` [PATCH 1/5] mac80211: fix and optimize MCS mask handling Johannes Berg
2013-04-15 14:19 ` Felix Fietkau
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=516C0E40.3020502@openwrt.org \
--to=nbd@openwrt.org \
--cc=johannes@sipsolutions.net \
--cc=linux-wireless@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).