Re: [PATCH 3/5] mac80211: improve the rate control API

[Felix Fietkau <nbd@openwrt.org>]

On 2013-04-16 12:03 PM, Karl Beldan wrote:
> On Sun, Apr 14, 2013 at 12:03:44AM +0200, Felix Fietkau wrote:
>> Allow rate control modules to pass a rate selection table to mac80211
>> and the driver. This allows drivers to fetch the most recent rate
>> selection from the sta pointer for already buffered frames. This allows
>> rate control to respond faster to sudden link changes and it is also a
>> step towards adding minstrel_ht support to drivers like iwlwifi.
>> 
>> When a driver sets IEEE80211_HW_SUPPORTS_RC_TABLE, mac80211 will not
>> fill info->control.rates with rates from the rate table (to preserve
>> explicit overrides by the rate control module). The driver then
>> explicitly calls ieee80211_get_tx_rates to merge overrides from
>> info->control.rates with defaults from the sta rate table.
>> 
>> Signed-off-by: Felix Fietkau <nbd@openwrt.org>
> 
> I gave it a try, I hope you won't mind the feedback for the typos.
> It does not compile:
> error: ‘struct ieee80211_tx_data’ has no member named ‘rate’
> it likely misses the diff for ieee80211_i.h, however that's what I did
> to quickly run without IEEE80211_HW_SUPPORTS_RC_TABLE so far.
Thanks. Will fix and send v2 later today.

- Felix