linux-wireless.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
* [PATCH] mac80211: cosmetics for minstrel_debugfs
@ 2013-04-17 12:08 Karl Beldan
  2013-04-17 14:32 ` Felix Fietkau
  2013-04-17 15:10 ` Johannes Berg
  0 siblings, 2 replies; 3+ messages in thread
From: Karl Beldan @ 2013-04-17 12:08 UTC (permalink / raw)
  To: Johannes Berg; +Cc: linux-wireless, Karl Beldan, Karl Beldan, Felix Fietkau

From: Karl Beldan <karl.beldan@rivierawaves.com>

This changes the minstrel stats ouput from:

rate     throughput  ewma prob   this prob  this succ/attempt   success    attempts
 BCD   6         0.0        0.0        0.0          0(  0)          0           0

to:

rate      throughput  ewma prob  this prob  this succ/attempt   success    attempts
 BCD   6         0.0        0.0        0.0             0(  0)         0           0

Signed-off-by: Karl Beldan <karl.beldan@rivierawaves.com>
---
 net/mac80211/rc80211_minstrel_debugfs.c | 4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)

diff --git a/net/mac80211/rc80211_minstrel_debugfs.c b/net/mac80211/rc80211_minstrel_debugfs.c
index d104834..fd0b9ca 100644
--- a/net/mac80211/rc80211_minstrel_debugfs.c
+++ b/net/mac80211/rc80211_minstrel_debugfs.c
@@ -68,7 +68,7 @@ minstrel_stats_open(struct inode *inode, struct file *file)
 
 	file->private_data = ms;
 	p = ms->buf;
-	p += sprintf(p, "rate     throughput  ewma prob   this prob  "
+	p += sprintf(p, "rate      throughput  ewma prob  this prob  "
 			"this succ/attempt   success    attempts\n");
 	for (i = 0; i < mi->n_rates; i++) {
 		struct minstrel_rate *mr = &mi->r[i];
@@ -86,7 +86,7 @@ minstrel_stats_open(struct inode *inode, struct file *file)
 		eprob = MINSTREL_TRUNC(mr->probability * 1000);
 
 		p += sprintf(p, "  %6u.%1u   %6u.%1u   %6u.%1u        "
-				"%3u(%3u)   %8llu    %8llu\n",
+				"   %3u(%3u)  %8llu    %8llu\n",
 				tp / 10, tp % 10,
 				eprob / 10, eprob % 10,
 				prob / 10, prob % 10,
-- 
1.8.2


^ permalink raw reply related	[flat|nested] 3+ messages in thread

* Re: [PATCH] mac80211: cosmetics for minstrel_debugfs
  2013-04-17 12:08 [PATCH] mac80211: cosmetics for minstrel_debugfs Karl Beldan
@ 2013-04-17 14:32 ` Felix Fietkau
  2013-04-17 15:10 ` Johannes Berg
  1 sibling, 0 replies; 3+ messages in thread
From: Felix Fietkau @ 2013-04-17 14:32 UTC (permalink / raw)
  To: Karl Beldan; +Cc: Johannes Berg, linux-wireless, Karl Beldan

On 2013-04-17 2:08 PM, Karl Beldan wrote:
> From: Karl Beldan <karl.beldan@rivierawaves.com>
> 
> This changes the minstrel stats ouput from:
> 
> rate     throughput  ewma prob   this prob  this succ/attempt   success    attempts
>  BCD   6         0.0        0.0        0.0          0(  0)          0           0
> 
> to:
> 
> rate      throughput  ewma prob  this prob  this succ/attempt   success    attempts
>  BCD   6         0.0        0.0        0.0             0(  0)         0           0
> 
> Signed-off-by: Karl Beldan <karl.beldan@rivierawaves.com>
Acked-by: Felix Fietkau <nbd@openwrt.org>



^ permalink raw reply	[flat|nested] 3+ messages in thread

* Re: [PATCH] mac80211: cosmetics for minstrel_debugfs
  2013-04-17 12:08 [PATCH] mac80211: cosmetics for minstrel_debugfs Karl Beldan
  2013-04-17 14:32 ` Felix Fietkau
@ 2013-04-17 15:10 ` Johannes Berg
  1 sibling, 0 replies; 3+ messages in thread
From: Johannes Berg @ 2013-04-17 15:10 UTC (permalink / raw)
  To: Karl Beldan; +Cc: linux-wireless, Karl Beldan, Felix Fietkau

On Wed, 2013-04-17 at 14:08 +0200, Karl Beldan wrote:
> From: Karl Beldan <karl.beldan@rivierawaves.com>
> 
> This changes the minstrel stats ouput from:
> 
> rate     throughput  ewma prob   this prob  this succ/attempt   success    attempts
>  BCD   6         0.0        0.0        0.0          0(  0)          0           0
> 
> to:
> 
> rate      throughput  ewma prob  this prob  this succ/attempt   success    attempts
>  BCD   6         0.0        0.0        0.0             0(  0)         0           0

Applied this and your other patch ("optimize minstrel_ewma")

johannes


^ permalink raw reply	[flat|nested] 3+ messages in thread

end of thread, other threads:[~2013-04-17 15:10 UTC | newest]

Thread overview: 3+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2013-04-17 12:08 [PATCH] mac80211: cosmetics for minstrel_debugfs Karl Beldan
2013-04-17 14:32 ` Felix Fietkau
2013-04-17 15:10 ` Johannes Berg

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).