* [PATCH -next] brcmfmac: fix error return code in brcmf_fws_init()
@ 2013-04-19 2:10 Wei Yongjun
2013-04-19 8:10 ` Arend van Spriel
0 siblings, 1 reply; 2+ messages in thread
From: Wei Yongjun @ 2013-04-19 2:10 UTC (permalink / raw)
To: brudley, arend, frankyl, meuleman, linville, pieterpg, phaber
Cc: yongjun_wei, linux-wireless, brcm80211-dev-list
From: Wei Yongjun <yongjun_wei@trendmicro.com.cn>
Fix to return a negative error code from the error handling
case instead of 0, as done elsewhere in this function.
Signed-off-by: Wei Yongjun <yongjun_wei@trendmicro.com.cn>
---
drivers/net/wireless/brcm80211/brcmfmac/fwsignal.c | 5 +++--
1 file changed, 3 insertions(+), 2 deletions(-)
diff --git a/drivers/net/wireless/brcm80211/brcmfmac/fwsignal.c b/drivers/net/wireless/brcm80211/brcmfmac/fwsignal.c
index 1bcd58c..df2ac2f 100644
--- a/drivers/net/wireless/brcm80211/brcmfmac/fwsignal.c
+++ b/drivers/net/wireless/brcm80211/brcmfmac/fwsignal.c
@@ -1875,8 +1875,9 @@ int brcmf_fws_init(struct brcmf_pub *drvr)
goto fail;
}
- if (brcmf_fweh_register(drvr, BRCMF_E_FIFO_CREDIT_MAP,
- brcmf_fws_notify_credit_map)) {
+ rc = brcmf_fweh_register(drvr, BRCMF_E_FIFO_CREDIT_MAP,
+ brcmf_fws_notify_credit_map);
+ if (rc) {
brcmf_err("register credit map handler failed\n");
goto fail;
}
^ permalink raw reply related [flat|nested] 2+ messages in thread* Re: [PATCH -next] brcmfmac: fix error return code in brcmf_fws_init()
2013-04-19 2:10 [PATCH -next] brcmfmac: fix error return code in brcmf_fws_init() Wei Yongjun
@ 2013-04-19 8:10 ` Arend van Spriel
0 siblings, 0 replies; 2+ messages in thread
From: Arend van Spriel @ 2013-04-19 8:10 UTC (permalink / raw)
To: Wei Yongjun
Cc: brudley, frankyl, meuleman, linville, pieterpg, phaber,
yongjun_wei, linux-wireless, brcm80211-dev-list
On 04/19/2013 04:10 AM, Wei Yongjun wrote:
> From: Wei Yongjun <yongjun_wei@trendmicro.com.cn>
>
> Fix to return a negative error code from the error handling
> case instead of 0, as done elsewhere in this function.
>
Thanks for the patch. However, I would like to solve it differently. I
will sent out a patch for handling this.
Regards,
Arend
> Signed-off-by: Wei Yongjun <yongjun_wei@trendmicro.com.cn>
> ---
> drivers/net/wireless/brcm80211/brcmfmac/fwsignal.c | 5 +++--
> 1 file changed, 3 insertions(+), 2 deletions(-)
>
> diff --git a/drivers/net/wireless/brcm80211/brcmfmac/fwsignal.c b/drivers/net/wireless/brcm80211/brcmfmac/fwsignal.c
> index 1bcd58c..df2ac2f 100644
> --- a/drivers/net/wireless/brcm80211/brcmfmac/fwsignal.c
> +++ b/drivers/net/wireless/brcm80211/brcmfmac/fwsignal.c
> @@ -1875,8 +1875,9 @@ int brcmf_fws_init(struct brcmf_pub *drvr)
> goto fail;
> }
>
> - if (brcmf_fweh_register(drvr, BRCMF_E_FIFO_CREDIT_MAP,
> - brcmf_fws_notify_credit_map)) {
> + rc = brcmf_fweh_register(drvr, BRCMF_E_FIFO_CREDIT_MAP,
> + brcmf_fws_notify_credit_map);
> + if (rc) {
> brcmf_err("register credit map handler failed\n");
> goto fail;
> }
>
>
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2013-04-19 8:11 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2013-04-19 2:10 [PATCH -next] brcmfmac: fix error return code in brcmf_fws_init() Wei Yongjun
2013-04-19 8:10 ` Arend van Spriel
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).