Re: [PATCH v3 04/12] wifi: rtlwifi: Add rtl8192du/table.{c,h}

[Ping-Ke Shih <pkshih@realtek.com>]

On Wed, 2024-03-20 at 21:36 +0200, Bitterblue Smith wrote:
> 
> These contain the MAC, BB, RF, and AGC initialisation tables for
> RTL8192DU.
> 
> Signed-off-by: Bitterblue Smith <rtl8821cerfe2@gmail.com>
> ---
> v3:
>  - No change.
> 
> v2:
>  - Patch is new in v2, split from patch 3/3 in v1.
> ---
>  .../realtek/rtlwifi/rtl8192du/table.c         | 1675 +++++++++++++++++
>  .../realtek/rtlwifi/rtl8192du/table.h         |   30 +
>  2 files changed, 1705 insertions(+)
>  create mode 100644 drivers/net/wireless/realtek/rtlwifi/rtl8192du/table.c
>  create mode 100644 drivers/net/wireless/realtek/rtlwifi/rtl8192du/table.h
> 
> diff --git a/drivers/net/wireless/realtek/rtlwifi/rtl8192du/table.c
> b/drivers/net/wireless/realtek/rtlwifi/rtl8192du/table.c
> new file mode 100644
> index 000000000000..6f571255c1a5
> --- /dev/null
> +++ b/drivers/net/wireless/realtek/rtlwifi/rtl8192du/table.c
> @@ -0,0 +1,1675 @@
> +// SPDX-License-Identifier: GPL-2.0
> +/* Copyright(c) 2009-2012  Realtek Corporation.*/
> +
> +#include <linux/types.h>
> +
> +#include "table.h"
> +
> +u32 rtl8192du_phy_reg_2tarray[PHY_REG_2T_ARRAYLENGTH] = {

static const ?

> +
> +u32 rtl8192du_phy_reg_array_pg[PHY_REG_ARRAY_PG_LENGTH] = {

static const ?

[...]

> diff --git a/drivers/net/wireless/realtek/rtlwifi/rtl8192du/table.h
> b/drivers/net/wireless/realtek/rtlwifi/rtl8192du/table.h
> new file mode 100644
> index 000000000000..71d943158c5f
> --- /dev/null
> +++ b/drivers/net/wireless/realtek/rtlwifi/rtl8192du/table.h
> @@ -0,0 +1,30 @@
> +/* SPDX-License-Identifier: GPL-2.0 */
> +/* Copyright(c) 2009-2012  Realtek Corporation.*/
> +
> +#ifndef __RTL92DE_TABLE__H_
> +#define __RTL92DE_TABLE__H_
> +
> +/*Created on  2011/ 1/14,  1:35*/

Not sure what it means? In fact, version info is added in these tables
already.

> +
> +#define PHY_REG_2T_ARRAYLENGTH 372
> +extern u32 rtl8192du_phy_reg_2tarray[PHY_REG_2T_ARRAYLENGTH];
> +#define PHY_REG_ARRAY_PG_LENGTH 624
> +extern u32 rtl8192du_phy_reg_array_pg[PHY_REG_ARRAY_PG_LENGTH];
> +#define RADIOA_2T_ARRAYLENGTH 378
> +extern u32 rtl8192du_radioa_2tarray[RADIOA_2T_ARRAYLENGTH];
> +#define RADIOB_2T_ARRAYLENGTH 384
> +extern u32 rtl8192du_radiob_2tarray[RADIOB_2T_ARRAYLENGTH];
> +#define RADIOA_2T_INT_PA_ARRAYLENGTH 378
> +extern u32 rtl8192du_radioa_2t_int_paarray[RADIOA_2T_INT_PA_ARRAYLENGTH];
> +#define RADIOB_2T_INT_PA_ARRAYLENGTH 384
> +extern u32 rtl8192du_radiob_2t_int_paarray[RADIOB_2T_INT_PA_ARRAYLENGTH];
> +#define MAC_2T_ARRAYLENGTH 192
> +extern u32 rtl8192du_mac_2tarray[MAC_2T_ARRAYLENGTH];
> +#define AGCTAB_ARRAYLENGTH 386
> +extern u32 rtl8192du_agctab_array[AGCTAB_ARRAYLENGTH];
> +#define AGCTAB_5G_ARRAYLENGTH 194
> +extern u32 rtl8192du_agctab_5garray[AGCTAB_5G_ARRAYLENGTH];
> +#define AGCTAB_2G_ARRAYLENGTH 194
> +extern u32 rtl8192du_agctab_2garray[AGCTAB_2G_ARRAYLENGTH];
> +
> +#endif
> --
> 2.43.2