linux-wireless.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Felix Fietkau <nbd@openwrt.org>
To: Karl Beldan <karl.beldan@gmail.com>
Cc: linux-wireless@vger.kernel.org, johannes@sipsolutions.net
Subject: Re: [PATCH v3 1/3] mac80211: improve the rate control API
Date: Fri, 19 Apr 2013 16:15:16 +0200	[thread overview]
Message-ID: <51715174.8000105@openwrt.org> (raw)
In-Reply-To: <20130419140653.GB8341@magnum.frso.rivierawaves.com>

On 2013-04-19 4:06 PM, Karl Beldan wrote:
> On Fri, Apr 19, 2013 at 03:01:15PM +0200, Felix Fietkau wrote:
>> +	if (!(rates[0].flags & IEEE80211_TX_RC_MCS)) {
>> +		s8 baserate = 0;
>> +
>> +		rate = &sband->bitrates[rates[0].idx];
>> +
>> +		for (i = 0; i < sband->n_bitrates; i++) {
>> +			/* must be a basic rate */
>> +			if (!(vif->bss_conf.basic_rates & BIT(i)))
>> +				continue;
> [...]
>> -	if (!(info->control.rates[0].flags & IEEE80211_TX_RC_MCS)) {
>> -		u32 basic_rates = tx->sdata->vif.bss_conf.basic_rates;
>> -		s8 baserate = basic_rates ? ffs(basic_rates - 1) : 0;
>> -
>> -		rate = &sband->bitrates[info->control.rates[0].idx];
>> -
>> -		for (i = 0; i < sband->n_bitrates; i++) {
>> -			/* must be a basic rate */
>> -			if (!(basic_rates & BIT(i)))
>> -				continue;
> 
> The moved code doesn't match, missing 5253ffb.
Oh, I must have overlooked it during the merge. Will send v4, thanks.

- Felix


      reply	other threads:[~2013-04-19 14:15 UTC|newest]

Thread overview: 7+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2013-04-19 13:01 [PATCH v3 1/3] mac80211: improve the rate control API Felix Fietkau
2013-04-19 13:01 ` [PATCH v3 2/3] mac80211/minstrel_ht: use the new " Felix Fietkau
2013-04-19 14:16   ` Karl Beldan
2013-04-19 14:52     ` Felix Fietkau
2013-04-19 13:01 ` [PATCH v3 3/3] mac80211/minstrel: " Felix Fietkau
2013-04-19 14:06 ` [PATCH v3 1/3] mac80211: improve the " Karl Beldan
2013-04-19 14:15   ` Felix Fietkau [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=51715174.8000105@openwrt.org \
    --to=nbd@openwrt.org \
    --cc=johannes@sipsolutions.net \
    --cc=karl.beldan@gmail.com \
    --cc=linux-wireless@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).