From: Ben Greear <greearb@candelatech.com>
To: "linux-wireless@vger.kernel.org" <linux-wireless@vger.kernel.org>
Subject: Question on ieee80211_tx_status
Date: Tue, 23 Apr 2013 12:12:51 -0700 [thread overview]
Message-ID: <5176DD33.9000100@candelatech.com> (raw)
It appears that ieee80211_tx_status also scales poorly
when using large numbers of virtual stations connected
to a single AP, due to for_each_sta_info(local, hdr->addr1, sta, tmp)...
I'm going to try using the vif-hashing to make this faster,
but first a question:
Since it matches on MAC addresses, should it
just return at the bottom of the loop since it has
found a match, and MACs are supposed to be unique?
for_each_sta_info(local, hdr->addr1, sta, tmp) {
/* skip wrong virtual interface */
if (!ether_addr_equal(hdr->addr2, sta->sdata->vif.addr))
continue;
...
If so, that would be a good improvement since the hash can easily
be turned into a linear search even in AP mode (without all of
my virtual-station scenarios)...
Thanks,
Ben
--
Ben Greear <greearb@candelatech.com>
Candela Technologies Inc http://www.candelatech.com
next reply other threads:[~2013-04-23 19:12 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-04-23 19:12 Ben Greear [this message]
2013-04-24 11:12 ` Question on ieee80211_tx_status Johannes Berg
2013-04-24 16:00 ` Ben Greear
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=5176DD33.9000100@candelatech.com \
--to=greearb@candelatech.com \
--cc=linux-wireless@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).