From: "Arend van Spriel" <arend@broadcom.com>
To: "Kalle Valo" <kvalo@adurom.com>
Cc: "Johannes Berg" <johannes@sipsolutions.net>,
linux-wireless@vger.kernel.org
Subject: Re: [RFC v2] cfg80211: Android P2P-Device workaround
Date: Wed, 24 Apr 2013 21:16:20 +0200 [thread overview]
Message-ID: <51782F84.6070605@broadcom.com> (raw)
In-Reply-To: <87ehe05hgc.fsf@purkki.adurom.net>
On 04/24/2013 12:52 PM, Kalle Valo wrote:
> Johannes Berg <johannes@sipsolutions.net> writes:
>
>> On Wed, 2013-04-24 at 13:11 +0300, Kalle Valo wrote:
>>> Johannes Berg <johannes@sipsolutions.net> writes:
>>>
>>>> +#ifndef CONFIG_CFG80211_ANDROID_P2P_HACK
>>>> if (WARN_ON(wdev->netdev))
>>>> return;
>>>> +#endif
>>>
>>> With my favorite kernel macro, config_enabled(), you could get rid of
>>> quite a lot of the ugly ifdefs.
>>
>> Yeah, but as long as this isn't going upstream I don't really want to
>> though since then it touches the code and is less obvious. Anyway we'll
>> see.
>
> Ah, makes send.
>
> FWIW, I think we should push this, and other wireless Android support,
> upstream. We should first get them to use upstream interfaces and then
> start fixing the problematic areas one by one.
I agree. Another big hurdle I see are the android driver private ioctls.
Do you have a good knowledge about those? I think some of those already
have a nl80211 equivalent.
Maybe it would be good to update twiki [1] on wireless.kernel.org with
such information. It seems a bit outdated.
Regards,
Arend
[1] http://wireless.kernel.org/en/developers/Documentation/Android
prev parent reply other threads:[~2013-04-24 19:16 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-04-24 8:26 [RFC v2] cfg80211: Android P2P-Device workaround Johannes Berg
2013-04-24 10:11 ` Kalle Valo
2013-04-24 10:44 ` Johannes Berg
2013-04-24 10:52 ` Kalle Valo
2013-04-24 19:16 ` Arend van Spriel [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=51782F84.6070605@broadcom.com \
--to=arend@broadcom.com \
--cc=johannes@sipsolutions.net \
--cc=kvalo@adurom.com \
--cc=linux-wireless@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).