linux-wireless.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: "Arend van Spriel" <arend@broadcom.com>
To: "Marcel Holtmann" <marcel@holtmann.org>
Cc: "Johannes Berg" <johannes@sipsolutions.net>,
	linux-wireless@vger.kernel.org
Subject: Re: [RFC] cfg80211: Android P2P-Device workaround
Date: Thu, 25 Apr 2013 11:03:20 +0200	[thread overview]
Message-ID: <5178F158.60103@broadcom.com> (raw)
In-Reply-To: <F323F29D-5EF8-4D01-A4B3-F9AF12326012@holtmann.org>

On 04/24/2013 04:29 PM, Marcel Holtmann wrote:
> Hi Arend,
>
>>>>> +config CFG80211_ANDROID_P2P_HACK
>>>>> +	bool "Android P2P netdevice hack"
>>>>> +	depends on CFG80211
>>>>> +	depends on !CFG80211_WEXT
>>>>> +	help
>>>>> +	  Enable this option for Android P2P w/ P2P Device.
>>>>> +
>>>>
>>>> do you really think this is a good idea? Wouldn't it be better if
>>>> Android just gets its userspace fixed. This way, they never will and
>>>> you carry this workaround forever.
>>>
>>> Well, I'm about 50/50 on whether to merge this. On the one hand, it's a
>>> very simple patch to carry out of tree, on the other hand more than one
>>> person will need it.
>>>
>>
>> Here is one who needs it. I consider this patch as a temporary solution, but it would be good to have it upstream. We would be using compat-drivers to backport the upstream brcmfmac to the android kernel, which also takes care of cfg80211.
>
> why do I get the feeling that the root-cause for this stupid p2p0 device is the Broadcom binary only driver  ;)

Hi Marcel,

Just like you I can only guess, but you are probably right except that 
the broadcom driver introducing this p2p0 device was propbably the 
bcmdhd driver which is available in android repositories.

Because of the design of the firmware (which is binary) going for a 
net_device was the most straightforward and also because wpa_supplicant 
is all about net_device interfaces.

> I feel like being back in the world of Wireless Extensions ;)

I hear you and we are still not fully rid of that.

Gr. AvS


      reply	other threads:[~2013-04-25  9:03 UTC|newest]

Thread overview: 8+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2013-04-23 12:45 [RFC] cfg80211: Android P2P-Device workaround Johannes Berg
2013-04-23 14:50 ` Marcel Holtmann
2013-04-23 16:42   ` Johannes Berg
2013-04-24  8:13     ` Arend van Spriel
2013-04-24  8:28       ` Johannes Berg
2013-04-24  8:31       ` Johannes Berg
2013-04-24 14:29       ` Marcel Holtmann
2013-04-25  9:03         ` Arend van Spriel [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=5178F158.60103@broadcom.com \
    --to=arend@broadcom.com \
    --cc=johannes@sipsolutions.net \
    --cc=linux-wireless@vger.kernel.org \
    --cc=marcel@holtmann.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).