* [PATCH] NFC: Add missing RFKILL dependency for Kconfig
@ 2013-04-26 17:58 Marcel Holtmann
2013-04-26 18:06 ` Randy Dunlap
2013-04-26 23:19 ` Samuel Ortiz
0 siblings, 2 replies; 3+ messages in thread
From: Marcel Holtmann @ 2013-04-26 17:58 UTC (permalink / raw)
To: linux-wireless
Since the NFC subsystem gained RFKILL support, it needs to be able
to build properly with whatever option for RFKILL has been selected.
on i386:
net/built-in.o: In function `nfc_unregister_device':
(.text+0x6a36d): undefined reference to `rfkill_unregister'
net/built-in.o: In function `nfc_unregister_device':
(.text+0x6a378): undefined reference to `rfkill_destroy'
net/built-in.o: In function `nfc_register_device':
(.text+0x6a493): undefined reference to `rfkill_alloc'
net/built-in.o: In function `nfc_register_device':
(.text+0x6a4a4): undefined reference to `rfkill_register'
net/built-in.o: In function `nfc_register_device':
(.text+0x6a4b3): undefined reference to `rfkill_destroy'
net/built-in.o: In function `nfc_dev_up':
(.text+0x6a8e8): undefined reference to `rfkill_blocked'
when CONFIG_RFKILL=m but NFC is builtin.
Reported-by: Randy Dunlap <rdunlap@infradead.org>
Signed-off-by: Marcel Holtmann <marcel@holtmann.org>
---
net/nfc/Kconfig | 1 +
1 file changed, 1 insertion(+)
diff --git a/net/nfc/Kconfig b/net/nfc/Kconfig
index 60c3bbb..28afdb1 100644
--- a/net/nfc/Kconfig
+++ b/net/nfc/Kconfig
@@ -4,6 +4,7 @@
menuconfig NFC
depends on NET
+ depends on RFKILL || !RFKILL
tristate "NFC subsystem support"
default n
help
--
1.8.1.4
^ permalink raw reply related [flat|nested] 3+ messages in thread
* Re: [PATCH] NFC: Add missing RFKILL dependency for Kconfig
2013-04-26 17:58 [PATCH] NFC: Add missing RFKILL dependency for Kconfig Marcel Holtmann
@ 2013-04-26 18:06 ` Randy Dunlap
2013-04-26 23:19 ` Samuel Ortiz
1 sibling, 0 replies; 3+ messages in thread
From: Randy Dunlap @ 2013-04-26 18:06 UTC (permalink / raw)
To: Marcel Holtmann; +Cc: linux-wireless
On 04/26/13 10:58, Marcel Holtmann wrote:
> Since the NFC subsystem gained RFKILL support, it needs to be able
> to build properly with whatever option for RFKILL has been selected.
>
> on i386:
>
> net/built-in.o: In function `nfc_unregister_device':
> (.text+0x6a36d): undefined reference to `rfkill_unregister'
> net/built-in.o: In function `nfc_unregister_device':
> (.text+0x6a378): undefined reference to `rfkill_destroy'
> net/built-in.o: In function `nfc_register_device':
> (.text+0x6a493): undefined reference to `rfkill_alloc'
> net/built-in.o: In function `nfc_register_device':
> (.text+0x6a4a4): undefined reference to `rfkill_register'
> net/built-in.o: In function `nfc_register_device':
> (.text+0x6a4b3): undefined reference to `rfkill_destroy'
> net/built-in.o: In function `nfc_dev_up':
> (.text+0x6a8e8): undefined reference to `rfkill_blocked'
>
> when CONFIG_RFKILL=m but NFC is builtin.
>
> Reported-by: Randy Dunlap <rdunlap@infradead.org>
> Signed-off-by: Marcel Holtmann <marcel@holtmann.org>
Acked-by: Randy Dunlap <rdunlap@infradead.org>
Thanks.
> ---
> net/nfc/Kconfig | 1 +
> 1 file changed, 1 insertion(+)
>
> diff --git a/net/nfc/Kconfig b/net/nfc/Kconfig
> index 60c3bbb..28afdb1 100644
> --- a/net/nfc/Kconfig
> +++ b/net/nfc/Kconfig
> @@ -4,6 +4,7 @@
>
> menuconfig NFC
> depends on NET
> + depends on RFKILL || !RFKILL
> tristate "NFC subsystem support"
> default n
> help
>
--
~Randy
^ permalink raw reply [flat|nested] 3+ messages in thread
* Re: [PATCH] NFC: Add missing RFKILL dependency for Kconfig
2013-04-26 17:58 [PATCH] NFC: Add missing RFKILL dependency for Kconfig Marcel Holtmann
2013-04-26 18:06 ` Randy Dunlap
@ 2013-04-26 23:19 ` Samuel Ortiz
1 sibling, 0 replies; 3+ messages in thread
From: Samuel Ortiz @ 2013-04-26 23:19 UTC (permalink / raw)
To: Marcel Holtmann; +Cc: linux-wireless
Hi Marcel,
On Fri, 2013-04-26 at 10:58 -0700, Marcel Holtmann wrote:
> Since the NFC subsystem gained RFKILL support, it needs to be able
> to build properly with whatever option for RFKILL has been selected.
>
> on i386:
>
> net/built-in.o: In function `nfc_unregister_device':
> (.text+0x6a36d): undefined reference to `rfkill_unregister'
> net/built-in.o: In function `nfc_unregister_device':
> (.text+0x6a378): undefined reference to `rfkill_destroy'
> net/built-in.o: In function `nfc_register_device':
> (.text+0x6a493): undefined reference to `rfkill_alloc'
> net/built-in.o: In function `nfc_register_device':
> (.text+0x6a4a4): undefined reference to `rfkill_register'
> net/built-in.o: In function `nfc_register_device':
> (.text+0x6a4b3): undefined reference to `rfkill_destroy'
> net/built-in.o: In function `nfc_dev_up':
> (.text+0x6a8e8): undefined reference to `rfkill_blocked'
>
> when CONFIG_RFKILL=m but NFC is builtin.
>
> Reported-by: Randy Dunlap <rdunlap@infradead.org>
> Signed-off-by: Marcel Holtmann <marcel@holtmann.org>
> ---
> net/nfc/Kconfig | 1 +
> 1 file changed, 1 insertion(+)
Applied to nfc-next, thanks.
Cheers,
Samuel.
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2013-04-26 23:35 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2013-04-26 17:58 [PATCH] NFC: Add missing RFKILL dependency for Kconfig Marcel Holtmann
2013-04-26 18:06 ` Randy Dunlap
2013-04-26 23:19 ` Samuel Ortiz
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).