linux-wireless.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: "Arend van Spriel" <arend@broadcom.com>
To: "Johannes Berg" <johannes@sipsolutions.net>
Cc: linux-wireless@vger.kernel.org,
	"Johannes Berg" <johannes.berg@intel.com>
Subject: Re: [RFC v4] cfg80211: Android P2P-Device workaround
Date: Mon, 29 Apr 2013 15:50:53 +0200	[thread overview]
Message-ID: <517E7ABD.9000505@broadcom.com> (raw)
In-Reply-To: <1367238384-26722-1-git-send-email-johannes@sipsolutions.net>

On 04/29/2013 02:26 PM, Johannes Berg wrote:
> From: Johannes Berg <johannes.berg@intel.com>
>
> Android requires a "p2p0" netdev to exist for P2P Device
> functionality, and will even set it "UP" to start the P2P
> Device functionality.

You can blame Broadcom for that ;-)

> This is a hack to provide it so not only is Android happy
> but also the current version of wpa_supplicant can work
> with P2P-Device functionality without needing changes to
> support the P2P-Device commands, just a little bit to not
> attempt to change the interface type to station.

Reading the subject I was going to say it is not only Android 
workaround, but the commit message also covers non-android use-case.

I will give it another spin. What changed compared to v3.

Regards,
Arend

> Signed-off-by: Johannes Berg <johannes.berg@intel.com>
> ---
>   include/net/cfg80211.h |   4 ++
>   net/wireless/Kconfig   |   7 +++
>   net/wireless/Makefile  |   1 +
>   net/wireless/android.c | 147 +++++++++++++++++++++++++++++++++++++++++++++++++
>   net/wireless/core.c    |  14 +++++
>   net/wireless/core.h    |   6 ++
>   net/wireless/nl80211.c |  63 +++++++++++++++++++++
>   7 files changed, 242 insertions(+)
>   create mode 100644 net/wireless/android.c
>



  reply	other threads:[~2013-04-29 13:51 UTC|newest]

Thread overview: 14+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2013-04-29 12:26 [RFC v4] cfg80211: Android P2P-Device workaround Johannes Berg
2013-04-29 13:50 ` Arend van Spriel [this message]
2013-04-29 13:53   ` Johannes Berg
2013-04-29 16:32 ` Marcel Holtmann
2013-04-30 13:38 ` Sreenath
2013-04-30 13:43   ` Johannes Berg
2013-05-02 10:03 ` Arend van Spriel
2013-05-02 10:06   ` Johannes Berg
2013-05-02 19:17     ` Arend van Spriel
2013-05-07 10:20       ` Johannes Berg
2013-05-23  3:18         ` YanBo
2013-05-23  9:40           ` Johannes Berg
2013-05-23 14:40             ` YanBo
2013-05-23 16:08               ` Johannes Berg

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=517E7ABD.9000505@broadcom.com \
    --to=arend@broadcom.com \
    --cc=johannes.berg@intel.com \
    --cc=johannes@sipsolutions.net \
    --cc=linux-wireless@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).