From: Gabor Juhos <juhosg@openwrt.org>
To: "John W. Linville" <linville@tuxdriver.com>
Cc: Gertjan van Wingerde <gwingerde@gmail.com>,
"linux-wireless@vger.kernel.org" <linux-wireless@vger.kernel.org>,
rt2x00 Users List <users@rt2x00.serialmonkey.com>
Subject: Re: [PATCH 7/7] rt2x00: rt2x00dev: use rt2x00dev->bcn->limit
Date: Thu, 02 May 2013 09:36:11 +0200 [thread overview]
Message-ID: <5182176B.20707@openwrt.org> (raw)
In-Reply-To: <CAL1gcdNg8YD9_uecmHjHggW6-M_yF5fis+7PNRhAABihmmMQzQ@mail.gmail.com>
2013.05.01. 22:08 keltezéssel, Gertjan van Wingerde írta:
> On Wed, May 1, 2013 at 5:17 PM, Gabor Juhos <juhosg@openwrt.org> wrote:
>> The beacon data queue is initialized already,
>> so fetch the number of the queue entries from
>> that instead of using the entry_num field of
>> the data queue descriptor.
>>
>> The two values are the same, and the use of the
>> rt2x00dev->bcn->limit value allows us to get rid
>> of a superfluous pointer dereference.
>>
>> Signed-off-by: Gabor Juhos <juhosg@openwrt.org>
>
> Acked-by: Gertjan van Wingerde <gwingerde@gmail.com>
John, please ignore the last patch. This depends on other patches which were not
included in the series. Without those it causes the following warning:
[ 11.990000] WARNING: at net/wireless/core.c:476 wiphy_register+0x570/0x680()
[ 12.000000] Modules linked in: rt73usb(+) rt61pci rt2800lib rt2500usb
rt2500pci rt2400pci rt2x00usb rt2x00pci rt2x00mmio r
t2x00lib crc_itu_t leds_gpio gpio_keys_polled input_polldev input_core
[ 12.040000] Call Trace:
[ 12.050000] [<80305288>] dump_stack+0x8/0x34
[ 12.050000] [<80025498>] warn_slowpath_common+0x78/0xa8
[ 12.060000] [<800254e0>] warn_slowpath_null+0x18/0x24
[ 12.070000] [<802a156c>] wiphy_register+0x570/0x680
[ 12.080000] [<802c71bc>] ieee80211_register_hw+0x450/0x8a4
[ 12.090000] [<c017b03c>] rt2x00lib_probe_dev+0x7a0/0x90c [rt2x00lib]
[ 12.110000] [<c019e320>] rt2x00usb_probe+0x15c/0x4b8 [rt2x00usb]
[ 12.120000] [<801d1f74>] usb_probe_interface+0xf8/0x234
[ 12.130000] [<8019f810>] driver_probe_device+0xa0/0x2bc
[ 12.140000] [<8019fae8>] __driver_attach+0xbc/0xc4
[ 12.150000] [<8019dcf4>] bus_for_each_dev+0x5c/0xa8
[ 12.160000] [<8019edec>] bus_add_driver+0x110/0x278
[ 12.170000] [<8019fe44>] driver_register+0x90/0x1a0
[ 12.180000] [<801d1480>] usb_register_driver+0x84/0x170
[ 12.190000] [<80004570>] do_one_initcall+0x160/0x1f0
[ 12.200000] [<800643e8>] load_module+0x17f0/0x1f54
[ 12.210000] [<80064c00>] sys_init_module+0xb4/0xec
[ 12.220000] [<8000de70>] stack_done+0x20/0x40
[ 12.230000]
[ 12.230000] ---[ end trace b1452c251acfb9c2 ]---
I will resend this as a part of another patch-set. Sorry for the inconvenience.
Thanks,
Gabor
next prev parent reply other threads:[~2013-05-02 7:35 UTC|newest]
Thread overview: 21+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-05-01 15:17 [PATCH 0/7] rt2x00: avoid a few superfluous pointer dereferences Gabor Juhos
2013-05-01 15:17 ` [PATCH 1/7] rt2x00: rt2x00dev: use rt2x00dev->tx->limit Gabor Juhos
2013-05-01 20:05 ` Gertjan van Wingerde
2013-06-03 17:09 ` [rt2x00-users] " Jakub Kicinski
2013-06-03 20:32 ` Gabor Juhos
2013-05-01 15:17 ` [PATCH 2/7] rt2x00: rt61pci: " Gabor Juhos
2013-05-01 20:06 ` Gertjan van Wingerde
2013-05-01 15:17 ` [PATCH 3/7] rt2x00: rt2800pci: " Gabor Juhos
2013-05-01 20:06 ` Gertjan van Wingerde
2013-05-01 15:17 ` [PATCH 4/7] rt2x00: rt2800usb: use rt2x00dev->rx->limit Gabor Juhos
2013-05-01 20:07 ` Gertjan van Wingerde
2013-05-01 15:17 ` [PATCH 5/7] rt2x00: rt2800lib: use rt2x00dev->bcn->winfo_size Gabor Juhos
2013-05-01 20:07 ` Gertjan van Wingerde
2013-05-01 15:17 ` [PATCH 6/7] rt2x00: rt2x00dev: defer operational mode detection Gabor Juhos
2013-05-01 20:08 ` Gertjan van Wingerde
2013-05-01 15:17 ` [PATCH 7/7] rt2x00: rt2x00dev: use rt2x00dev->bcn->limit Gabor Juhos
2013-05-01 20:08 ` Gertjan van Wingerde
2013-05-02 7:36 ` Gabor Juhos [this message]
2013-05-22 18:53 ` John W. Linville
2013-05-01 20:10 ` [PATCH 0/7] rt2x00: avoid a few superfluous pointer dereferences Gertjan van Wingerde
2013-05-01 20:41 ` Gabor Juhos
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=5182176B.20707@openwrt.org \
--to=juhosg@openwrt.org \
--cc=gwingerde@gmail.com \
--cc=linux-wireless@vger.kernel.org \
--cc=linville@tuxdriver.com \
--cc=users@rt2x00.serialmonkey.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).