* [PATCH V3] rtlwifi: rtl8192cu: Add new USB ID
@ 2013-05-15 15:03 Larry Finger
2013-05-15 20:23 ` Sergei Shtylyov
0 siblings, 1 reply; 5+ messages in thread
From: Larry Finger @ 2013-05-15 15:03 UTC (permalink / raw)
To: linville; +Cc: linux-wireless, Albert Pool, netdev, Larry Finger
From: Albert Pool <albertpool@solcon.nl>
This adds the USB ID of the On Networks N300MA, clone of Netgear WNA3100M.
Signed-off-by: Albert Pool <albertpool@solcon.nl>
Signed-off-by: Larry Finger <Larry.Finger@lwfinger.net>
Reported-by: Ana Rey <Anazul77@hotmail.com>
---
John,
Please use this version. V2 still had some whitespace errors that I fixed.
Albert,
Please use scripts/checkpatch.pl to check the patch before you send it.
Thanks,
Larry
---
drivers/net/wireless/rtlwifi/rtl8192cu/sw.c | 1 +
1 file changed, 1 insertion(+)
diff --git a/drivers/net/wireless/rtlwifi/rtl8192cu/sw.c b/drivers/net/wireless/rtlwifi/rtl8192cu/sw.c
index 23d640a..18da6de 100644
--- a/drivers/net/wireless/rtlwifi/rtl8192cu/sw.c
+++ b/drivers/net/wireless/rtlwifi/rtl8192cu/sw.c
@@ -349,6 +349,7 @@ static struct usb_device_id rtl8192c_usb_ids[] = {
{RTL_USB_DEVICE(0x07aa, 0x0056, rtl92cu_hal_cfg)}, /*ATKK-Gemtek*/
{RTL_USB_DEVICE(0x07b8, 0x8178, rtl92cu_hal_cfg)}, /*Funai -Abocom*/
{RTL_USB_DEVICE(0x0846, 0x9021, rtl92cu_hal_cfg)}, /*Netgear-Sercomm*/
+ {RTL_USB_DEVICE(0x0846, 0xf001, rtl92cu_hal_cfg)}, /*On Netwrks N300MA*/
{RTL_USB_DEVICE(0x0b05, 0x17ab, rtl92cu_hal_cfg)}, /*ASUS-Edimax*/
{RTL_USB_DEVICE(0x0bda, 0x8186, rtl92cu_hal_cfg)}, /*Realtek 92CE-VAU*/
{RTL_USB_DEVICE(0x0df6, 0x0061, rtl92cu_hal_cfg)}, /*Sitecom-Edimax*/
--
1.8.1.4
^ permalink raw reply related [flat|nested] 5+ messages in thread
* Re: [PATCH V3] rtlwifi: rtl8192cu: Add new USB ID
2013-05-15 15:03 [PATCH V3] rtlwifi: rtl8192cu: Add new USB ID Larry Finger
@ 2013-05-15 20:23 ` Sergei Shtylyov
2013-05-15 20:34 ` Larry Finger
0 siblings, 1 reply; 5+ messages in thread
From: Sergei Shtylyov @ 2013-05-15 20:23 UTC (permalink / raw)
To: Larry Finger; +Cc: linville, linux-wireless, Albert Pool, netdev
Hello.
On 05/15/2013 07:03 PM, Larry Finger wrote:
> From: Albert Pool <albertpool@solcon.nl>
>
> This adds the USB ID of the On Networks N300MA, clone of Netgear WNA3100M.
>
> Signed-off-by: Albert Pool <albertpool@solcon.nl>
> Signed-off-by: Larry Finger <Larry.Finger@lwfinger.net>
> Reported-by: Ana Rey <Anazul77@hotmail.com>
> ---
>
> John,
>
> Please use this version. V2 still had some whitespace errors that I fixed.
>
> Albert,
>
> Please use scripts/checkpatch.pl to check the patch before you send it.
>
> Thanks,
>
> Larry
> ---
>
> drivers/net/wireless/rtlwifi/rtl8192cu/sw.c | 1 +
> 1 file changed, 1 insertion(+)
>
> diff --git a/drivers/net/wireless/rtlwifi/rtl8192cu/sw.c b/drivers/net/wireless/rtlwifi/rtl8192cu/sw.c
> index 23d640a..18da6de 100644
> --- a/drivers/net/wireless/rtlwifi/rtl8192cu/sw.c
> +++ b/drivers/net/wireless/rtlwifi/rtl8192cu/sw.c
> @@ -349,6 +349,7 @@ static struct usb_device_id rtl8192c_usb_ids[] = {
> {RTL_USB_DEVICE(0x07aa, 0x0056, rtl92cu_hal_cfg)}, /*ATKK-Gemtek*/
> {RTL_USB_DEVICE(0x07b8, 0x8178, rtl92cu_hal_cfg)}, /*Funai -Abocom*/
> {RTL_USB_DEVICE(0x0846, 0x9021, rtl92cu_hal_cfg)}, /*Netgear-Sercomm*/
> + {RTL_USB_DEVICE(0x0846, 0xf001, rtl92cu_hal_cfg)}, /*On Netwrks N300MA*/
"Networks", perhaps? Or does it hit 80 columns limit this way?
WBR, Sergei
^ permalink raw reply [flat|nested] 5+ messages in thread
* Re: [PATCH V3] rtlwifi: rtl8192cu: Add new USB ID
2013-05-15 20:23 ` Sergei Shtylyov
@ 2013-05-15 20:34 ` Larry Finger
2013-05-16 9:04 ` Albert Pool
0 siblings, 1 reply; 5+ messages in thread
From: Larry Finger @ 2013-05-15 20:34 UTC (permalink / raw)
To: Sergei Shtylyov; +Cc: linville, linux-wireless, Albert Pool, netdev
On 05/15/2013 03:23 PM, Sergei Shtylyov wrote:
> Hello.
>
> On 05/15/2013 07:03 PM, Larry Finger wrote:
>
>> From: Albert Pool <albertpool@solcon.nl>
>>
>> This adds the USB ID of the On Networks N300MA, clone of Netgear WNA3100M.
>>
>> Signed-off-by: Albert Pool <albertpool@solcon.nl>
>> Signed-off-by: Larry Finger <Larry.Finger@lwfinger.net>
>> Reported-by: Ana Rey <Anazul77@hotmail.com>
>> ---
>>
>> John,
>>
>> Please use this version. V2 still had some whitespace errors that I fixed.
>>
>> Albert,
>>
>> Please use scripts/checkpatch.pl to check the patch before you send it.
>>
>> Thanks,
>>
>> Larry
>> ---
>>
>> drivers/net/wireless/rtlwifi/rtl8192cu/sw.c | 1 +
>> 1 file changed, 1 insertion(+)
>>
>> diff --git a/drivers/net/wireless/rtlwifi/rtl8192cu/sw.c
>> b/drivers/net/wireless/rtlwifi/rtl8192cu/sw.c
>> index 23d640a..18da6de 100644
>> --- a/drivers/net/wireless/rtlwifi/rtl8192cu/sw.c
>> +++ b/drivers/net/wireless/rtlwifi/rtl8192cu/sw.c
>> @@ -349,6 +349,7 @@ static struct usb_device_id rtl8192c_usb_ids[] = {
>> {RTL_USB_DEVICE(0x07aa, 0x0056, rtl92cu_hal_cfg)}, /*ATKK-Gemtek*/
>> {RTL_USB_DEVICE(0x07b8, 0x8178, rtl92cu_hal_cfg)}, /*Funai -Abocom*/
>> {RTL_USB_DEVICE(0x0846, 0x9021, rtl92cu_hal_cfg)}, /*Netgear-Sercomm*/
>> + {RTL_USB_DEVICE(0x0846, 0xf001, rtl92cu_hal_cfg)}, /*On Netwrks N300MA*/
>
> "Networks", perhaps? Or does it hit 80 columns limit this way?
That is exactly the problem. I suppose I could allow one line to be 81
characters in length, but that would diminish the effectiveness of my suggestion
that checkpatch be used.
Thanks for noticing. At least someone is reading the patches.
Larry
^ permalink raw reply [flat|nested] 5+ messages in thread
* Re: [PATCH V3] rtlwifi: rtl8192cu: Add new USB ID
2013-05-15 20:34 ` Larry Finger
@ 2013-05-16 9:04 ` Albert Pool
2013-05-16 15:15 ` Larry Finger
0 siblings, 1 reply; 5+ messages in thread
From: Albert Pool @ 2013-05-16 9:04 UTC (permalink / raw)
To: Larry Finger; +Cc: Sergei Shtylyov, linville, linux-wireless, netdev
Op 15-05-13 22:34, Larry Finger schreef:
> On 05/15/2013 03:23 PM, Sergei Shtylyov wrote:
>> Hello.
>>
>> On 05/15/2013 07:03 PM, Larry Finger wrote:
>>
>>> From: Albert Pool <albertpool@solcon.nl>
>>>
>>> This adds the USB ID of the On Networks N300MA, clone of Netgear
>>> WNA3100M.
>>>
>>> Signed-off-by: Albert Pool <albertpool@solcon.nl>
>>> Signed-off-by: Larry Finger <Larry.Finger@lwfinger.net>
>>> Reported-by: Ana Rey <Anazul77@hotmail.com>
>>> ---
>>>
>>> John,
>>>
>>> Please use this version. V2 still had some whitespace errors that I
>>> fixed.
>>>
>>> Albert,
>>>
>>> Please use scripts/checkpatch.pl to check the patch before you send it.
>>>
>>> Thanks,
>>>
>>> Larry
>>> ---
>>>
>>> drivers/net/wireless/rtlwifi/rtl8192cu/sw.c | 1 +
>>> 1 file changed, 1 insertion(+)
>>>
>>> diff --git a/drivers/net/wireless/rtlwifi/rtl8192cu/sw.c
>>> b/drivers/net/wireless/rtlwifi/rtl8192cu/sw.c
>>> index 23d640a..18da6de 100644
>>> --- a/drivers/net/wireless/rtlwifi/rtl8192cu/sw.c
>>> +++ b/drivers/net/wireless/rtlwifi/rtl8192cu/sw.c
>>> @@ -349,6 +349,7 @@ static struct usb_device_id rtl8192c_usb_ids[] = {
>>> {RTL_USB_DEVICE(0x07aa, 0x0056, rtl92cu_hal_cfg)},
>>> /*ATKK-Gemtek*/
>>> {RTL_USB_DEVICE(0x07b8, 0x8178, rtl92cu_hal_cfg)}, /*Funai
>>> -Abocom*/
>>> {RTL_USB_DEVICE(0x0846, 0x9021, rtl92cu_hal_cfg)},
>>> /*Netgear-Sercomm*/
>>> + {RTL_USB_DEVICE(0x0846, 0xf001, rtl92cu_hal_cfg)}, /*On Netwrks
>>> N300MA*/
>>
>> "Networks", perhaps? Or does it hit 80 columns limit this way?
>
> That is exactly the problem. I suppose I could allow one line to be 81
> characters in length, but that would diminish the effectiveness of my
> suggestion that checkpatch be used.
>
> Thanks for noticing. At least someone is reading the patches.
>
> Larry
>
>
So my patch v2 could not be used because the line was longer than 80
chars? (It was 82, indeed)
Also the problems with bad signal were due to Ana Rey's AP. It's being
fixed or replaced today.
Albert
^ permalink raw reply [flat|nested] 5+ messages in thread
* Re: [PATCH V3] rtlwifi: rtl8192cu: Add new USB ID
2013-05-16 9:04 ` Albert Pool
@ 2013-05-16 15:15 ` Larry Finger
0 siblings, 0 replies; 5+ messages in thread
From: Larry Finger @ 2013-05-16 15:15 UTC (permalink / raw)
To: Albert Pool; +Cc: Sergei Shtylyov, linville, linux-wireless, netdev
On 05/16/2013 04:04 AM, Albert Pool wrote:
>
> Op 15-05-13 22:34, Larry Finger schreef:
>> On 05/15/2013 03:23 PM, Sergei Shtylyov wrote:
>>> Hello.
>>>
>>> On 05/15/2013 07:03 PM, Larry Finger wrote:
>>>
>>>> From: Albert Pool <albertpool@solcon.nl>
>>>>
>>>> This adds the USB ID of the On Networks N300MA, clone of Netgear WNA3100M.
>>>>
>>>> Signed-off-by: Albert Pool <albertpool@solcon.nl>
>>>> Signed-off-by: Larry Finger <Larry.Finger@lwfinger.net>
>>>> Reported-by: Ana Rey <Anazul77@hotmail.com>
>>>> ---
>>>>
>>>> John,
>>>>
>>>> Please use this version. V2 still had some whitespace errors that I fixed.
>>>>
>>>> Albert,
>>>>
>>>> Please use scripts/checkpatch.pl to check the patch before you send it.
>>>>
>>>> Thanks,
>>>>
>>>> Larry
>>>> ---
>>>>
>>>> drivers/net/wireless/rtlwifi/rtl8192cu/sw.c | 1 +
>>>> 1 file changed, 1 insertion(+)
>>>>
>>>> diff --git a/drivers/net/wireless/rtlwifi/rtl8192cu/sw.c
>>>> b/drivers/net/wireless/rtlwifi/rtl8192cu/sw.c
>>>> index 23d640a..18da6de 100644
>>>> --- a/drivers/net/wireless/rtlwifi/rtl8192cu/sw.c
>>>> +++ b/drivers/net/wireless/rtlwifi/rtl8192cu/sw.c
>>>> @@ -349,6 +349,7 @@ static struct usb_device_id rtl8192c_usb_ids[] = {
>>>> {RTL_USB_DEVICE(0x07aa, 0x0056, rtl92cu_hal_cfg)}, /*ATKK-Gemtek*/
>>>> {RTL_USB_DEVICE(0x07b8, 0x8178, rtl92cu_hal_cfg)}, /*Funai -Abocom*/
>>>> {RTL_USB_DEVICE(0x0846, 0x9021, rtl92cu_hal_cfg)}, /*Netgear-Sercomm*/
>>>> + {RTL_USB_DEVICE(0x0846, 0xf001, rtl92cu_hal_cfg)}, /*On Netwrks N300MA*/
>>>
>>> "Networks", perhaps? Or does it hit 80 columns limit this way?
>>
>> That is exactly the problem. I suppose I could allow one line to be 81
>> characters in length, but that would diminish the effectiveness of my
>> suggestion that checkpatch be used.
>>
>> Thanks for noticing. At least someone is reading the patches.
>>
>> Larry
>>
>>
> So my patch v2 could not be used because the line was longer than 80 chars? (It
> was 82, indeed)
>
> Also the problems with bad signal were due to Ana Rey's AP. It's being fixed or
> replaced today.
The long line was not the problem. If you run V2 through the checkpatch script,
ypu will see that there were a number of <space><tab> sequences in the patch.
Not only did they fail the check, but they also failed to apply on my source base.
Larry
^ permalink raw reply [flat|nested] 5+ messages in thread
end of thread, other threads:[~2013-05-16 15:15 UTC | newest]
Thread overview: 5+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2013-05-15 15:03 [PATCH V3] rtlwifi: rtl8192cu: Add new USB ID Larry Finger
2013-05-15 20:23 ` Sergei Shtylyov
2013-05-15 20:34 ` Larry Finger
2013-05-16 9:04 ` Albert Pool
2013-05-16 15:15 ` Larry Finger
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).