* [PATCH 1/2 V2] backports: Fix menuconfig build
@ 2013-05-19 16:43 Larry Finger
2013-05-19 16:43 ` [PATCH 2/2] backports: defconfig for rtlwifi family Larry Finger
2013-05-19 21:22 ` [PATCH 1/2 V2] backports: Fix menuconfig build Luis R. Rodriguez
0 siblings, 2 replies; 6+ messages in thread
From: Larry Finger @ 2013-05-19 16:43 UTC (permalink / raw)
To: mcgrof; +Cc: linux-wireless, Larry Finger
Using openSUSE 12.3 with x86_64 architecture, the 'make menuconfig'
command results in the following:
finger@larrylap:~/backports-3.10-rc1-1> make menuconfig
cc -Wl,--no-as-needed -lncurses mconf.o zconf.tab.o lxdialog/checklist.o lxdialog/inputbox.o lxdialog/menubox.o lxdialog/textbox.o lxdialog/util.o lxdialog/yesno.o -o mconf
/usr/lib64/gcc/x86_64-suse-linux/4.7/../../../../x86_64-suse-linux/bin/ld: /lib64/libncurses.so.5: undefined reference to symbol 'acs_map'
/usr/lib64/gcc/x86_64-suse-linux/4.7/../../../../x86_64-suse-linux/bin/ld: note: 'acs_map' is defined in DSO /usr/lib64/gcc/x86_64-suse-linux/4.7/../../../../lib64/libtinfo.so so try adding it to the linker command line
/usr/lib64/gcc/x86_64-suse-linux/4.7/../../../../lib64/libtinfo.so: could not read symbols: Invalid operation
collect2: error: ld returned 1 exit status
make[2]: *** [mconf] Error 1
make[1]: *** [menuconfig] Error 2
make: *** [menuconfig] Error 2
finger@larrylap:~/backports-3.10-rc1-1>
When "-ltinfo" is added to the LDFLAGS symbol as suggested by the linker,
it builds and runs correctly.
Signed-off-by: Larry Finger <Larry.Finger@lwfinger.net>
---
V2 in the proper format for git repository
Larry
---
backport/kconfig/Makefile | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/backport/kconfig/Makefile b/backport/kconfig/Makefile
index 5974e48..ff5c270 100644
--- a/backport/kconfig/Makefile
+++ b/backport/kconfig/Makefile
@@ -3,7 +3,7 @@ CFLAGS=-Wall -Wmissing-prototypes -Wstrict-prototypes -O2 -fomit-frame-pointer
LXDIALOG := lxdialog/checklist.o lxdialog/inputbox.o lxdialog/menubox.o lxdialog/textbox.o lxdialog/util.o lxdialog/yesno.o
conf: conf.o zconf.tab.o
-mconf: LDFLAGS = -Wl,--no-as-needed -lncurses
+mconf: LDFLAGS = -Wl,--no-as-needed -lncurses -ltinfo
mconf: CFLAGS += -DCURSES_LOC="<ncurses.h>" -DLOCALE
mconf: mconf.o zconf.tab.o $(LXDIALOG)
--
1.8.1.4
^ permalink raw reply related [flat|nested] 6+ messages in thread
* [PATCH 2/2] backports: defconfig for rtlwifi family
2013-05-19 16:43 [PATCH 1/2 V2] backports: Fix menuconfig build Larry Finger
@ 2013-05-19 16:43 ` Larry Finger
2013-05-19 22:54 ` Hauke Mehrtens
2013-05-19 21:22 ` [PATCH 1/2 V2] backports: Fix menuconfig build Luis R. Rodriguez
1 sibling, 1 reply; 6+ messages in thread
From: Larry Finger @ 2013-05-19 16:43 UTC (permalink / raw)
To: mcgrof; +Cc: linux-wireless, Larry Finger
Signed-off-by: Larry Finger <Larry.Finger@lwfinger.net>
---
V2 in proper format for git repo
Larry
backport/defconfigs/rtlwifi | 19 +++++++++++++++++++
1 file changed, 19 insertions(+)
create mode 100644 backport/defconfigs/rtlwifi
diff --git a/backport/defconfigs/rtlwifi b/backport/defconfigs/rtlwifi
new file mode 100644
index 0000000..c86d000
--- /dev/null
+++ b/backport/defconfigs/rtlwifi
@@ -0,0 +1,19 @@
+CPTCFG_CFG80211=m
+CPTCFG_CFG80211_DEFAULT_PS=y
+CPTCFG_CFG80211_DEBUGFS=y
+CPTCFG_MAC80211=m
+# CPTCFG_MAC80211_RC_PID is not set
+# CPTCFG_MAC80211_RC_MINSTREL is not set
+# CPTCFG_MAC80211_RC_DEFAULT_MINSTREL is not set
+CPTCFG_MAC80211_DEBUGFS=y
+CPTCFG_MAC80211_MESSAGE_TRACING=y
+CPTCFG_WLAN=y
+CPTCFG_RTLWIFI=m
+CPTCFG_RTLWIFI_DEBUG=y
+CPTCFG_RTL8192CE=m
+CPTCFG_RTL8192SE=m
+CPTCFG_RTL8192DE=m
+CPTCFG_RTL8723AE=m
+CPTCFG_RTL8188EE=m
+CPTCFG_RTL8192CU=m
+CPTCFG_RTL8192C_COMMON=m
--
1.8.1.4
^ permalink raw reply related [flat|nested] 6+ messages in thread
* Re: [PATCH 2/2] backports: defconfig for rtlwifi family
2013-05-19 16:43 ` [PATCH 2/2] backports: defconfig for rtlwifi family Larry Finger
@ 2013-05-19 22:54 ` Hauke Mehrtens
2013-05-20 1:08 ` Larry Finger
0 siblings, 1 reply; 6+ messages in thread
From: Hauke Mehrtens @ 2013-05-19 22:54 UTC (permalink / raw)
To: Larry Finger; +Cc: mcgrof, linux-wireless
On 05/19/2013 06:43 PM, Larry Finger wrote:
> Signed-off-by: Larry Finger <Larry.Finger@lwfinger.net>
> ---
>
> V2 in proper format for git repo
>
> Larry
>
> backport/defconfigs/rtlwifi | 19 +++++++++++++++++++
> 1 file changed, 19 insertions(+)
> create mode 100644 backport/defconfigs/rtlwifi
>
> diff --git a/backport/defconfigs/rtlwifi b/backport/defconfigs/rtlwifi
> new file mode 100644
> index 0000000..c86d000
> --- /dev/null
> +++ b/backport/defconfigs/rtlwifi
> @@ -0,0 +1,19 @@
> +CPTCFG_CFG80211=m
> +CPTCFG_CFG80211_DEFAULT_PS=y
> +CPTCFG_CFG80211_DEBUGFS=y
> +CPTCFG_MAC80211=m
> +# CPTCFG_MAC80211_RC_PID is not set
> +# CPTCFG_MAC80211_RC_MINSTREL is not set
> +# CPTCFG_MAC80211_RC_DEFAULT_MINSTREL is not set
This results in no rate control mechanism being selected is that intended?
MAC80211_MESH and MAC80211_LEDS are also not selected.
> +CPTCFG_MAC80211_DEBUGFS=y
> +CPTCFG_MAC80211_MESSAGE_TRACING=y
> +CPTCFG_WLAN=y
> +CPTCFG_RTLWIFI=m
> +CPTCFG_RTLWIFI_DEBUG=y
> +CPTCFG_RTL8192CE=m
> +CPTCFG_RTL8192SE=m
> +CPTCFG_RTL8192DE=m
> +CPTCFG_RTL8723AE=m
> +CPTCFG_RTL8188EE=m
> +CPTCFG_RTL8192CU=m
> +CPTCFG_RTL8192C_COMMON=m
>
^ permalink raw reply [flat|nested] 6+ messages in thread
* Re: [PATCH 2/2] backports: defconfig for rtlwifi family
2013-05-19 22:54 ` Hauke Mehrtens
@ 2013-05-20 1:08 ` Larry Finger
0 siblings, 0 replies; 6+ messages in thread
From: Larry Finger @ 2013-05-20 1:08 UTC (permalink / raw)
To: Hauke Mehrtens; +Cc: mcgrof, linux-wireless
On 05/19/2013 05:54 PM, Hauke Mehrtens wrote:
> On 05/19/2013 06:43 PM, Larry Finger wrote:
>> Signed-off-by: Larry Finger <Larry.Finger@lwfinger.net>
>> ---
>>
>> V2 in proper format for git repo
>>
>> Larry
>>
>> backport/defconfigs/rtlwifi | 19 +++++++++++++++++++
>> 1 file changed, 19 insertions(+)
>> create mode 100644 backport/defconfigs/rtlwifi
>>
>> diff --git a/backport/defconfigs/rtlwifi b/backport/defconfigs/rtlwifi
>> new file mode 100644
>> index 0000000..c86d000
>> --- /dev/null
>> +++ b/backport/defconfigs/rtlwifi
>> @@ -0,0 +1,19 @@
>> +CPTCFG_CFG80211=m
>> +CPTCFG_CFG80211_DEFAULT_PS=y
>> +CPTCFG_CFG80211_DEBUGFS=y
>> +CPTCFG_MAC80211=m
>> +# CPTCFG_MAC80211_RC_PID is not set
>> +# CPTCFG_MAC80211_RC_MINSTREL is not set
>> +# CPTCFG_MAC80211_RC_DEFAULT_MINSTREL is not set
>
> This results in no rate control mechanism being selected is that intended?
>
> MAC80211_MESH and MAC80211_LEDS are also not selected.
>
>> +CPTCFG_MAC80211_DEBUGFS=y
>> +CPTCFG_MAC80211_MESSAGE_TRACING=y
>> +CPTCFG_WLAN=y
>> +CPTCFG_RTLWIFI=m
>> +CPTCFG_RTLWIFI_DEBUG=y
>> +CPTCFG_RTL8192CE=m
>> +CPTCFG_RTL8192SE=m
>> +CPTCFG_RTL8192DE=m
>> +CPTCFG_RTL8723AE=m
>> +CPTCFG_RTL8188EE=m
>> +CPTCFG_RTL8192CU=m
>> +CPTCFG_RTL8192C_COMMON=m
The rtlwifi drivers do rate control in the firmware. That is OK, but LEDS and
MESH should be selected.
Thanks for noticing,
Larry
^ permalink raw reply [flat|nested] 6+ messages in thread
* Re: [PATCH 1/2 V2] backports: Fix menuconfig build
2013-05-19 16:43 [PATCH 1/2 V2] backports: Fix menuconfig build Larry Finger
2013-05-19 16:43 ` [PATCH 2/2] backports: defconfig for rtlwifi family Larry Finger
@ 2013-05-19 21:22 ` Luis R. Rodriguez
2013-05-19 21:22 ` Luis R. Rodriguez
1 sibling, 1 reply; 6+ messages in thread
From: Luis R. Rodriguez @ 2013-05-19 21:22 UTC (permalink / raw)
To: Larry Finger; +Cc: Luis R. Rodriguez, linux-wireless, backports@vger.kernel.org
On Sun, May 19, 2013 at 9:43 AM, Larry Finger <Larry.Finger@lwfinger.net> wrote:
> Signed-off-by: Larry Finger <Larry.Finger@lwfinger.net>
Thanks Larry, applied and pushed! Also kicked out a new release with these:
https://www.kernel.org/pub/linux/kernel/projects/backports/stable/v3.10-rc1/backports-3.10-rc1-2.tar.bz2
Luis
^ permalink raw reply [flat|nested] 6+ messages in thread
* Re: [PATCH 1/2 V2] backports: Fix menuconfig build
2013-05-19 21:22 ` [PATCH 1/2 V2] backports: Fix menuconfig build Luis R. Rodriguez
@ 2013-05-19 21:22 ` Luis R. Rodriguez
0 siblings, 0 replies; 6+ messages in thread
From: Luis R. Rodriguez @ 2013-05-19 21:22 UTC (permalink / raw)
To: Larry Finger; +Cc: Luis R. Rodriguez, linux-wireless, backports@vger.kernel.org
On Sun, May 19, 2013 at 2:22 PM, Luis R. Rodriguez
<mcgrof@do-not-panic.com> wrote:
> On Sun, May 19, 2013 at 9:43 AM, Larry Finger <Larry.Finger@lwfinger.net> wrote:
>> Signed-off-by: Larry Finger <Larry.Finger@lwfinger.net>
>
> Thanks Larry, applied and pushed! Also kicked out a new release with these:
>
> https://www.kernel.org/pub/linux/kernel/projects/backports/stable/v3.10-rc1/backports-3.10-rc1-2.tar.bz2
I forgot to mention, please Cc backports list for patches, whether or
not other lists get Cc'd is up to you.
Luis
^ permalink raw reply [flat|nested] 6+ messages in thread
end of thread, other threads:[~2013-05-20 1:08 UTC | newest]
Thread overview: 6+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2013-05-19 16:43 [PATCH 1/2 V2] backports: Fix menuconfig build Larry Finger
2013-05-19 16:43 ` [PATCH 2/2] backports: defconfig for rtlwifi family Larry Finger
2013-05-19 22:54 ` Hauke Mehrtens
2013-05-20 1:08 ` Larry Finger
2013-05-19 21:22 ` [PATCH 1/2 V2] backports: Fix menuconfig build Luis R. Rodriguez
2013-05-19 21:22 ` Luis R. Rodriguez
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).