linux-wireless.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: "Arend van Spriel" <arend@broadcom.com>
To: "Johannes Berg" <johannes@sipsolutions.net>
Cc: "Jouni Malinen" <j@w1.fi>,
	"hostap@lists.shmoo.com" <hostap@lists.shmoo.com>,
	linux-wireless <linux-wireless@vger.kernel.org>,
	"Jithu Jance" <jithu@broadcom.com>
Subject: Re: P2P Device support: how to deal with p2p_no_group_iface option
Date: Mon, 27 May 2013 16:03:55 +0200	[thread overview]
Message-ID: <51A367CB.9080503@broadcom.com> (raw)
In-Reply-To: <1369663161.14740.13.camel@jlt4.sipsolutions.net>

On 05/27/2013 03:59 PM, Johannes Berg wrote:
> On Mon, 2013-05-27 at 15:56 +0200, Arend van Spriel wrote:
>
>>> I don't think I'd do either of those. Not creating P2P_DEVICE will
>>> simply not work with drivers expecting it, and changing iftype to/from
>>> P2P-Device isn't supported since it would delete/create the netdev.
>>
>> So should we check that in cfg80211 upon wiphy_register().
>
> Check what?

Check that the interface combinations contain a iface limit with only 
P2P_DEVICE:

	{
		.max = 1,
		.types = BIT(NL80211_IFTYPE_P2P_DEVICE)
	}

>>> I don't really see much choice but reject (or ignore) this option for
>>> drivers using P2P_DEVICE. Why would anyone *really* want P2P operation
>>> on wlan0 when another interface can be used?
>>
>> In this mac80211_hwsim is a special case. We could make P2P_DEVICE
>> support in mac80211_hwsim optional using module parameter to allow
>> testing both cases.
>
> Yes, that we could do.
>
> johannes
>
>



  reply	other threads:[~2013-05-27 14:04 UTC|newest]

Thread overview: 12+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2013-05-25 11:23 P2P Device support: how to deal with p2p_no_group_iface option Arend van Spriel
2013-05-27  9:03 ` Johannes Berg
2013-05-27 13:56   ` Arend van Spriel
2013-05-27 13:59     ` Johannes Berg
2013-05-27 14:03       ` Arend van Spriel [this message]
2013-05-27 15:53         ` Johannes Berg
2013-05-27 17:40           ` Arend van Spriel
2013-05-27 18:11     ` Jouni Malinen
2013-05-27 19:15       ` Johannes Berg
2013-05-27 19:20         ` Arend van Spriel
2013-05-27 19:27           ` Johannes Berg
2013-05-27 18:51     ` Marcel Holtmann

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=51A367CB.9080503@broadcom.com \
    --to=arend@broadcom.com \
    --cc=hostap@lists.shmoo.com \
    --cc=j@w1.fi \
    --cc=jithu@broadcom.com \
    --cc=johannes@sipsolutions.net \
    --cc=linux-wireless@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).