From: "Arend van Spriel" <arend@broadcom.com>
To: "Joe Perches" <joe@perches.com>
Cc: "John Greene" <jogreene@redhat.com>,
linville@tuxdriver.com, linux-wireless@vger.kernel.org
Subject: Re: [PATCH] brcmsmac: Reduce log spam in heavy tx, make err print in debug
Date: Mon, 3 Jun 2013 19:06:22 +0200 [thread overview]
Message-ID: <51ACCD0E.10407@broadcom.com> (raw)
In-Reply-To: <1370278476.2025.41.camel@joe-AO722>
On 06/03/2013 06:54 PM, Joe Perches wrote:
> On Mon, 2013-06-03 at 09:47 -0400, John Greene wrote:
>> Move message to debug mode to reduce log spam under heavy tx (iperf) load.
> []
>> diff --git a/drivers/net/wireless/brcm80211/brcmsmac/ampdu.c b/drivers/net/wireless/brcm80211/brcmsmac/ampdu.c
> []
>> @@ -900,7 +900,7 @@ brcms_c_ampdu_dotxstatus_complete(struct ampdu_info *ampdu, struct scb *scb,
>> if (supr_status) {
>> update_rate = false;
>> if (supr_status == TX_STATUS_SUPR_BADCH) {
>> - brcms_err(wlc->hw->d11core,
>> + brcms_dbg_ht(wlc->hw->d11core,
>> "%s: Pkt tx suppressed, illegal channel possibly %d\n",
>> __func__, CHSPEC_CHANNEL(
>> wlc->default_bss->chanspec));
>
> net_ratelimited instead?
Yes and only when driver debug level is set.
Regards,
Arend
next prev parent reply other threads:[~2013-06-03 17:06 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-06-03 13:47 [PATCH] brcmsmac: Reduce log spam in heavy tx, make err print in debug John Greene
2013-06-03 16:54 ` Joe Perches
2013-06-03 17:06 ` Arend van Spriel [this message]
2013-06-04 14:10 ` John Greene
2013-06-03 17:07 ` Arend van Spriel
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=51ACCD0E.10407@broadcom.com \
--to=arend@broadcom.com \
--cc=joe@perches.com \
--cc=jogreene@redhat.com \
--cc=linux-wireless@vger.kernel.org \
--cc=linville@tuxdriver.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).