* [PATCH] brcmsmac: Reduce log spam in heavy tx, make err print in debug
@ 2013-06-03 13:47 John Greene
2013-06-03 16:54 ` Joe Perches
2013-06-03 17:07 ` Arend van Spriel
0 siblings, 2 replies; 5+ messages in thread
From: John Greene @ 2013-06-03 13:47 UTC (permalink / raw)
To: linville; +Cc: arend, linux-wireless
Move message to debug mode to reduce log spam under heavy tx (iperf) load.
This message prints in ht debug mode only:
brcms_c_ampdu_dotxstatus_complete: Pkt tx suppressed, illegal channel
possibly 153
Signed-off-by: John Greene <jogreene@redhat.com>
---
drivers/net/wireless/brcm80211/brcmsmac/ampdu.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/net/wireless/brcm80211/brcmsmac/ampdu.c b/drivers/net/wireless/brcm80211/brcmsmac/ampdu.c
index 1585cc5..bd98285 100644
--- a/drivers/net/wireless/brcm80211/brcmsmac/ampdu.c
+++ b/drivers/net/wireless/brcm80211/brcmsmac/ampdu.c
@@ -900,7 +900,7 @@ brcms_c_ampdu_dotxstatus_complete(struct ampdu_info *ampdu, struct scb *scb,
if (supr_status) {
update_rate = false;
if (supr_status == TX_STATUS_SUPR_BADCH) {
- brcms_err(wlc->hw->d11core,
+ brcms_dbg_ht(wlc->hw->d11core,
"%s: Pkt tx suppressed, illegal channel possibly %d\n",
__func__, CHSPEC_CHANNEL(
wlc->default_bss->chanspec));
--
1.8.1.4
^ permalink raw reply related [flat|nested] 5+ messages in thread* Re: [PATCH] brcmsmac: Reduce log spam in heavy tx, make err print in debug
2013-06-03 13:47 [PATCH] brcmsmac: Reduce log spam in heavy tx, make err print in debug John Greene
@ 2013-06-03 16:54 ` Joe Perches
2013-06-03 17:06 ` Arend van Spriel
2013-06-03 17:07 ` Arend van Spriel
1 sibling, 1 reply; 5+ messages in thread
From: Joe Perches @ 2013-06-03 16:54 UTC (permalink / raw)
To: John Greene; +Cc: linville, arend, linux-wireless
On Mon, 2013-06-03 at 09:47 -0400, John Greene wrote:
> Move message to debug mode to reduce log spam under heavy tx (iperf) load.
[]
> diff --git a/drivers/net/wireless/brcm80211/brcmsmac/ampdu.c b/drivers/net/wireless/brcm80211/brcmsmac/ampdu.c
[]
> @@ -900,7 +900,7 @@ brcms_c_ampdu_dotxstatus_complete(struct ampdu_info *ampdu, struct scb *scb,
> if (supr_status) {
> update_rate = false;
> if (supr_status == TX_STATUS_SUPR_BADCH) {
> - brcms_err(wlc->hw->d11core,
> + brcms_dbg_ht(wlc->hw->d11core,
> "%s: Pkt tx suppressed, illegal channel possibly %d\n",
> __func__, CHSPEC_CHANNEL(
> wlc->default_bss->chanspec));
net_ratelimited instead?
^ permalink raw reply [flat|nested] 5+ messages in thread* Re: [PATCH] brcmsmac: Reduce log spam in heavy tx, make err print in debug
2013-06-03 16:54 ` Joe Perches
@ 2013-06-03 17:06 ` Arend van Spriel
2013-06-04 14:10 ` John Greene
0 siblings, 1 reply; 5+ messages in thread
From: Arend van Spriel @ 2013-06-03 17:06 UTC (permalink / raw)
To: Joe Perches; +Cc: John Greene, linville, linux-wireless
On 06/03/2013 06:54 PM, Joe Perches wrote:
> On Mon, 2013-06-03 at 09:47 -0400, John Greene wrote:
>> Move message to debug mode to reduce log spam under heavy tx (iperf) load.
> []
>> diff --git a/drivers/net/wireless/brcm80211/brcmsmac/ampdu.c b/drivers/net/wireless/brcm80211/brcmsmac/ampdu.c
> []
>> @@ -900,7 +900,7 @@ brcms_c_ampdu_dotxstatus_complete(struct ampdu_info *ampdu, struct scb *scb,
>> if (supr_status) {
>> update_rate = false;
>> if (supr_status == TX_STATUS_SUPR_BADCH) {
>> - brcms_err(wlc->hw->d11core,
>> + brcms_dbg_ht(wlc->hw->d11core,
>> "%s: Pkt tx suppressed, illegal channel possibly %d\n",
>> __func__, CHSPEC_CHANNEL(
>> wlc->default_bss->chanspec));
>
> net_ratelimited instead?
Yes and only when driver debug level is set.
Regards,
Arend
^ permalink raw reply [flat|nested] 5+ messages in thread* Re: [PATCH] brcmsmac: Reduce log spam in heavy tx, make err print in debug
2013-06-03 17:06 ` Arend van Spriel
@ 2013-06-04 14:10 ` John Greene
0 siblings, 0 replies; 5+ messages in thread
From: John Greene @ 2013-06-04 14:10 UTC (permalink / raw)
To: Arend van Spriel; +Cc: Joe Perches, linville, linux-wireless
On 06/03/2013 01:06 PM, Arend van Spriel wrote:
> On 06/03/2013 06:54 PM, Joe Perches wrote:
>> On Mon, 2013-06-03 at 09:47 -0400, John Greene wrote:
>>> Move message to debug mode to reduce log spam under heavy tx (iperf)
>>> load.
>> []
>>> diff --git a/drivers/net/wireless/brcm80211/brcmsmac/ampdu.c
>>> b/drivers/net/wireless/brcm80211/brcmsmac/ampdu.c
>> []
>>> @@ -900,7 +900,7 @@ brcms_c_ampdu_dotxstatus_complete(struct
>>> ampdu_info *ampdu, struct scb *scb,
>>> if (supr_status) {
>>> update_rate = false;
>>> if (supr_status == TX_STATUS_SUPR_BADCH) {
>>> - brcms_err(wlc->hw->d11core,
>>> + brcms_dbg_ht(wlc->hw->d11core,
>>> "%s: Pkt tx suppressed, illegal channel
>>> possibly %d\n",
>>> __func__, CHSPEC_CHANNEL(
>>> wlc->default_bss->chanspec));
>>
>> net_ratelimited instead?
>
> Yes and only when driver debug level is set.
>
> Regards,
> Arend
>
>
Thanks for the ACK, Arend. And comments..live and learn.
Certainly they would be reasonable also. Issue (confined to an
annoyance level, hence the workaround) is why this comes up when the
channel being flagged is the same as the one the AP I'm connected with
is on. That is the root of the problem, more work needed on that point
which probably would render this moot.
--
John Greene
^ permalink raw reply [flat|nested] 5+ messages in thread
* Re: [PATCH] brcmsmac: Reduce log spam in heavy tx, make err print in debug
2013-06-03 13:47 [PATCH] brcmsmac: Reduce log spam in heavy tx, make err print in debug John Greene
2013-06-03 16:54 ` Joe Perches
@ 2013-06-03 17:07 ` Arend van Spriel
1 sibling, 0 replies; 5+ messages in thread
From: Arend van Spriel @ 2013-06-03 17:07 UTC (permalink / raw)
To: John Greene; +Cc: linville, linux-wireless
On 06/03/2013 03:47 PM, John Greene wrote:
> Move message to debug mode to reduce log spam under heavy tx (iperf) load.
> This message prints in ht debug mode only:
> brcms_c_ampdu_dotxstatus_complete: Pkt tx suppressed, illegal channel
> possibly 153
Acked-by: Arend van Spriel <arend@broadcom.com>
> Signed-off-by: John Greene <jogreene@redhat.com>
> ---
> drivers/net/wireless/brcm80211/brcmsmac/ampdu.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
^ permalink raw reply [flat|nested] 5+ messages in thread
end of thread, other threads:[~2013-06-04 14:10 UTC | newest]
Thread overview: 5+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2013-06-03 13:47 [PATCH] brcmsmac: Reduce log spam in heavy tx, make err print in debug John Greene
2013-06-03 16:54 ` Joe Perches
2013-06-03 17:06 ` Arend van Spriel
2013-06-04 14:10 ` John Greene
2013-06-03 17:07 ` Arend van Spriel
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).