From: Felix Fietkau <nbd@openwrt.org>
To: Sujith Manoharan <sujith@msujith.org>
Cc: John Linville <linville@tuxdriver.com>, linux-wireless@vger.kernel.org
Subject: Re: [PATCH 2/6] ath9k: Fix ANI monitoring
Date: Tue, 04 Jun 2013 13:32:40 +0200 [thread overview]
Message-ID: <51ADD058.5000003@openwrt.org> (raw)
In-Reply-To: <1370340695-29003-2-git-send-email-sujith@msujith.org>
On 2013-06-04 12:11 PM, Sujith Manoharan wrote:
> From: Sujith Manoharan <c_manoha@qca.qualcomm.com>
>
> The commit "ath9k_hw: improve ANI processing and rx desensitizing parameters"
> changed various ANI operational parameters to address a specific
> card/environment. This is not really applicable for other cards
> in general usage.
>
> As per internal documentation, lowering the immunity level can be
> done only after 5 periods have passed and the CCK/OFDM errors are
> below the low watermak threshold - which have been fixed at 300 and
> 400 respectively by the sytems team.
>
> Raising the immunity level can be done when CCK/OFDM errors exceed
> 600 and 1000 (per second).
>
> Set these values once during attach.
> ---
> diff --git a/drivers/net/wireless/ath/ath9k/ani.h b/drivers/net/wireless/ath/ath9k/ani.h
> index 78b9fa9..1088472 100644
> --- a/drivers/net/wireless/ath/ath9k/ani.h
> +++ b/drivers/net/wireless/ath/ath9k/ani.h
> @@ -21,11 +21,9 @@
>
> /* units are errors per second */
> #define ATH9K_ANI_OFDM_TRIG_HIGH 3500
> -#define ATH9K_ANI_OFDM_TRIG_HIGH_BELOW_INI 1000
>
> /* units are errors per second */
> #define ATH9K_ANI_OFDM_TRIG_LOW 400
> -#define ATH9K_ANI_OFDM_TRIG_LOW_ABOVE_INI 900
>
> /* units are errors per second */
> #define ATH9K_ANI_CCK_TRIG_HIGH 600
>
With this patch, the raise-limit is always 3500, you should change it to
1000 when removing the above-/below-INI distinction.
- Felix
next prev parent reply other threads:[~2013-06-04 11:32 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-06-04 10:11 [PATCH 1/6] ath9k: Fix OFDM weak signal detection for AP mode Sujith Manoharan
2013-06-04 10:11 ` [PATCH 2/6] ath9k: Fix ANI monitoring Sujith Manoharan
2013-06-04 11:32 ` Felix Fietkau [this message]
2013-06-04 11:47 ` Sujith Manoharan
2013-06-04 11:56 ` Sujith Manoharan
2013-06-04 12:04 ` Sujith Manoharan
2013-06-04 10:11 ` [PATCH 3/6] ath9k: Fix ANI levels Sujith Manoharan
2013-06-04 10:11 ` [PATCH 4/6] ath9k: Fix ofdm weak signal configuration Sujith Manoharan
2013-06-04 10:11 ` [PATCH 5/6] ath9k: Remove redundant code Sujith Manoharan
2013-06-04 10:11 ` [PATCH 6/6] ath9k: Remove unused ANI macros Sujith Manoharan
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=51ADD058.5000003@openwrt.org \
--to=nbd@openwrt.org \
--cc=linux-wireless@vger.kernel.org \
--cc=linville@tuxdriver.com \
--cc=sujith@msujith.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox